[PATCH v2] staging: mt7621-eth: add SPDX GPL-2.0 license identifier ---added punctuation to v1 changelog text

[PATCH v2] staging: mt7621-eth: add SPDX GPL-2.0 license identifier ---added punctuation to v1 changelog text

[Jules Irenge]

Add SPDX GPL-2.0 license to fix missing SPDX warning
 reported by checkpatch.pl.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/mt7621-eth/ethtool.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
index 40b4cf011660..d0e97ae0d82e 100644
--- a/drivers/staging/mt7621-eth/ethtool.h
+++ b/drivers/staging/mt7621-eth/ethtool.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*   This program is free software; you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
  *   the Free Software Foundation; version 2 of the License
-- 
2.20.1

Re: [Outreachy kernel] [PATCH v2] staging: mt7621-eth: add SPDX GPL-2.0 license identifier ---added punctuation to v1 changelog text

[Julia Lawall]

The subject line is still not correct.  You can't describe your changes
since the previous patch in the subject line.  That goes under the ---

v2: added punctuation to v1 changelog text

Please go back and read the outreachy tutorial again thoroughly.  That
contains all of the information you need to know to send patches in the
right way.  You shouldn't need to make things up yourself.

julia

On Mon, 25 Feb 2019, Jules Irenge wrote:

> Add SPDX GPL-2.0 license to fix missing SPDX warning
>  reported by checkpatch.pl.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-eth/ethtool.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
> index 40b4cf011660..d0e97ae0d82e 100644
> --- a/drivers/staging/mt7621-eth/ethtool.h
> +++ b/drivers/staging/mt7621-eth/ethtool.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*   This program is free software; you can redistribute it and/or modify
>   *   it under the terms of the GNU General Public License as published by
>   *   the Free Software Foundation; version 2 of the License
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225230929.3861-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH v2] staging: mt7621-eth: add SPDX GPL-2.0 license identifier ---added punctuation to v1 changelog text

[Greg KH]

On Mon, Feb 25, 2019 at 11:09:29PM +0000, Jules Irenge wrote:
> Add SPDX GPL-2.0 license to fix missing SPDX warning
>  reported by checkpatch.pl.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-eth/ethtool.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
> index 40b4cf011660..d0e97ae0d82e 100644
> --- a/drivers/staging/mt7621-eth/ethtool.h
> +++ b/drivers/staging/mt7621-eth/ethtool.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*   This program is free software; you can redistribute it and/or modify
>   *   it under the terms of the GNU General Public License as published by
>   *   the Free Software Foundation; version 2 of the License


When you do this, the follow-on patch afterward should remove the two
paragraphs of the license "boiler plate" text.

thanks,

greg k-h