All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] autotools: Always build VC4 helpers with the library
@ 2019-02-26  9:30 Paul Kocialkowski
  2019-02-26  9:39 ` Maxime Ripard
  2019-02-26 10:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Kocialkowski @ 2019-02-26  9:30 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

With recent changes to the igt_fb code, VC4 support is now integrated
in common helpers. As a result, VC4 helpers have to be built as part
of the library.

This is already the case with meson, but VC4 support was removed from
autotools. Bring it back unconditionally to match meson behaviour.

This fixes a build error with autotools.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
 lib/Makefile.sources | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/Makefile.sources b/lib/Makefile.sources
index 808b9617eca2..9711fef34469 100644
--- a/lib/Makefile.sources
+++ b/lib/Makefile.sources
@@ -109,6 +109,8 @@ lib_source_list =	 	\
 	igt_psr.h		\
 	igt_v3d.c		\
 	igt_v3d.h		\
+	igt_vc4.c		\
+	igt_vc4.h		\
 	$(NULL)
 
 .PHONY: version.h.tmp
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] autotools: Always build VC4 helpers with the library
  2019-02-26  9:30 [igt-dev] [PATCH i-g-t] autotools: Always build VC4 helpers with the library Paul Kocialkowski
@ 2019-02-26  9:39 ` Maxime Ripard
  2019-02-26 10:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2019-02-26  9:39 UTC (permalink / raw)
  To: Paul Kocialkowski; +Cc: Petri Latvala, igt-dev


[-- Attachment #1.1: Type: text/plain, Size: 658 bytes --]

On Tue, Feb 26, 2019 at 10:30:44AM +0100, Paul Kocialkowski wrote:
> With recent changes to the igt_fb code, VC4 support is now integrated
> in common helpers. As a result, VC4 helpers have to be built as part
> of the library.
> 
> This is already the case with meson, but VC4 support was removed from
> autotools. Bring it back unconditionally to match meson behaviour.
> 
> This fixes a build error with autotools.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>

Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for autotools: Always build VC4 helpers with the library
  2019-02-26  9:30 [igt-dev] [PATCH i-g-t] autotools: Always build VC4 helpers with the library Paul Kocialkowski
  2019-02-26  9:39 ` Maxime Ripard
@ 2019-02-26 10:25 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-02-26 10:25 UTC (permalink / raw)
  To: igt-dev

== Series Details ==

Series: autotools: Always build VC4 helpers with the library
URL   : https://patchwork.freedesktop.org/series/57243/
State : failure

== Summary ==

Series 57243 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-26 10:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26  9:30 [igt-dev] [PATCH i-g-t] autotools: Always build VC4 helpers with the library Paul Kocialkowski
2019-02-26  9:39 ` Maxime Ripard
2019-02-26 10:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.