* [PATCH] Staging: rtlwifi: rtl8822be: Use __func__ instead of func name
@ 2019-02-26 0:22 Bhanusree Pola
2019-02-26 10:42 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Bhanusree Pola @ 2019-02-26 0:22 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Larry Finger
Fix checkpatch warning:
WARNING: Prefer using '"%s...", __func__' to using 'rtl8822be_set_fw_rsvdpagepkt', this function's name, in a string
Use __func__ instead of using complete function name.
Avoid line over 80 characters
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
drivers/staging/rtlwifi/rtl8822be/fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c
index f061dd1382aa..43a56962e37a 100644
--- a/drivers/staging/rtlwifi/rtl8822be/fw.c
+++ b/drivers/staging/rtlwifi/rtl8822be/fw.c
@@ -736,10 +736,10 @@ void rtl8822be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
totalpacketlen = TOTAL_RESERVED_PKT_LEN;
RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD,
- "rtl8822be_set_fw_rsvdpagepkt(): HW_VAR_SET_TX_CMD: ALL\n",
+ ("%s: HW_VAR_SET_TX_CMD: ALL\n", __func__),
&reserved_page_packet[0], totalpacketlen);
RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD,
- "rtl8822be_set_fw_rsvdpagepkt(): HW_VAR_SET_TX_CMD: ALL\n",
+ ("%s: HW_VAR_SET_TX_CMD: ALL\n", __func__),
u1_rsvd_page_loc, 3);
skb = dev_alloc_skb(totalpacketlen);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rtlwifi: rtl8822be: Use __func__ instead of func name
2019-02-26 0:22 [PATCH] Staging: rtlwifi: rtl8822be: Use __func__ instead of func name Bhanusree Pola
@ 2019-02-26 10:42 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-02-26 10:42 UTC (permalink / raw)
To: Bhanusree Pola; +Cc: outreachy-kernel, Larry Finger
On Tue, Feb 26, 2019 at 05:52:43AM +0530, Bhanusree Pola wrote:
> Fix checkpatch warning:
> WARNING: Prefer using '"%s...", __func__' to using 'rtl8822be_set_fw_rsvdpagepkt', this function's name, in a string
>
> Use __func__ instead of using complete function name.
> Avoid line over 80 characters
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
> drivers/staging/rtlwifi/rtl8822be/fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c
> index f061dd1382aa..43a56962e37a 100644
> --- a/drivers/staging/rtlwifi/rtl8822be/fw.c
> +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c
> @@ -736,10 +736,10 @@ void rtl8822be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished)
> totalpacketlen = TOTAL_RESERVED_PKT_LEN;
>
> RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD,
> - "rtl8822be_set_fw_rsvdpagepkt(): HW_VAR_SET_TX_CMD: ALL\n",
> + ("%s: HW_VAR_SET_TX_CMD: ALL\n", __func__),
You did not even compile your change :(
This is not correct C, please fix up and always test your patches before
sending them out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 0:22 [PATCH] Staging: rtlwifi: rtl8822be: Use __func__ instead of func name Bhanusree Pola
2019-02-26 10:42 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.