All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface
@ 2019-02-26 11:21 Andy Shevchenko
  2019-02-26 11:21 ` [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board Andy Shevchenko
  2019-02-28  3:38 ` [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface Bin Meng
  0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-02-26 11:21 UTC (permalink / raw)
  To: u-boot

The console is actually serial #2. When we would like to enable other ports,
this would be not okay to mess up with the ordering.

Thus, fix the number of default console interface to be 2.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/dts/edison.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index 0dd72407ea..b59171cb50 100644
--- a/arch/x86/dts/edison.dts
+++ b/arch/x86/dts/edison.dts
@@ -17,11 +17,11 @@
 	compatible = "intel,edison";
 
 	aliases {
-		serial0 = &serial0;
+		serial2 = &serial2;
 	};
 
 	chosen {
-		stdout-path = &serial0;
+		stdout-path = &serial2;
 	};
 
 	cpus {
@@ -53,7 +53,7 @@
 			  0x01000000 0x0 0x2000 0x2000 0 0xe000>;
 	};
 
-	serial0: serial at ff010180 {
+	serial2: serial at ff010180 {
 		compatible = "intel,mid-uart";
 		reg = <0xff010180 0x100>;
 		reg-shift = <0>;
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board
  2019-02-26 11:21 [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface Andy Shevchenko
@ 2019-02-26 11:21 ` Andy Shevchenko
  2019-02-28  3:38   ` Bin Meng
  2019-02-28  3:38 ` [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface Bin Meng
  1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2019-02-26 11:21 UTC (permalink / raw)
  To: u-boot

Intel Edison has three UART ports, i.e.
 port 0 - Bluetooth
 port 1 - auxiliary, available for general purpose use
 port 2 - debugging, usually console output is here

Enable all of them for future use.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/dts/edison.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index b59171cb50..8629f7bcf2 100644
--- a/arch/x86/dts/edison.dts
+++ b/arch/x86/dts/edison.dts
@@ -17,6 +17,8 @@
 	compatible = "intel,edison";
 
 	aliases {
+		serial0 = &serial0;
+		serial1 = &serial1;
 		serial2 = &serial2;
 	};
 
@@ -53,6 +55,22 @@
 			  0x01000000 0x0 0x2000 0x2000 0 0xe000>;
 	};
 
+	serial0: serial at ff010180 {
+		compatible = "intel,mid-uart";
+		reg = <0xff010080 0x100>;
+		reg-shift = <0>;
+		clock-frequency = <29491200>;
+		current-speed = <115200>;
+	};
+
+	serial1: serial at ff010180 {
+		compatible = "intel,mid-uart";
+		reg = <0xff010100 0x100>;
+		reg-shift = <0>;
+		clock-frequency = <29491200>;
+		current-speed = <115200>;
+	};
+
 	serial2: serial at ff010180 {
 		compatible = "intel,mid-uart";
 		reg = <0xff010180 0x100>;
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface
  2019-02-26 11:21 [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface Andy Shevchenko
  2019-02-26 11:21 ` [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board Andy Shevchenko
@ 2019-02-28  3:38 ` Bin Meng
  1 sibling, 0 replies; 4+ messages in thread
From: Bin Meng @ 2019-02-28  3:38 UTC (permalink / raw)
  To: u-boot

On Tue, Feb 26, 2019 at 7:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The console is actually serial #2. When we would like to enable other ports,
> this would be not okay to mess up with the ordering.
>
> Thus, fix the number of default console interface to be 2.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/dts/edison.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board
  2019-02-26 11:21 ` [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board Andy Shevchenko
@ 2019-02-28  3:38   ` Bin Meng
  0 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2019-02-28  3:38 UTC (permalink / raw)
  To: u-boot

Hi Andy,

On Tue, Feb 26, 2019 at 7:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Intel Edison has three UART ports, i.e.
>  port 0 - Bluetooth
>  port 1 - auxiliary, available for general purpose use
>  port 2 - debugging, usually console output is here
>
> Enable all of them for future use.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/dts/edison.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
> index b59171cb50..8629f7bcf2 100644
> --- a/arch/x86/dts/edison.dts
> +++ b/arch/x86/dts/edison.dts
> @@ -17,6 +17,8 @@
>         compatible = "intel,edison";
>
>         aliases {
> +               serial0 = &serial0;
> +               serial1 = &serial1;
>                 serial2 = &serial2;
>         };
>
> @@ -53,6 +55,22 @@
>                           0x01000000 0x0 0x2000 0x2000 0 0xe000>;
>         };
>
> +       serial0: serial at ff010180 {

The reg base is wrong here, should be @ff010080

> +               compatible = "intel,mid-uart";
> +               reg = <0xff010080 0x100>;
> +               reg-shift = <0>;
> +               clock-frequency = <29491200>;
> +               current-speed = <115200>;
> +       };
> +
> +       serial1: serial at ff010180 {

ditto

> +               compatible = "intel,mid-uart";
> +               reg = <0xff010100 0x100>;
> +               reg-shift = <0>;
> +               clock-frequency = <29491200>;
> +               current-speed = <115200>;
> +       };
> +
>         serial2: serial at ff010180 {
>                 compatible = "intel,mid-uart";
>                 reg = <0xff010180 0x100>;
> --

Regards,
Bin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-28  3:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 11:21 [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface Andy Shevchenko
2019-02-26 11:21 ` [U-Boot] [PATCH v1 2/2] x86: edison: Add the rest of UARTs present on board Andy Shevchenko
2019-02-28  3:38   ` Bin Meng
2019-02-28  3:38 ` [U-Boot] [PATCH v1 1/2] x86: edison: Use proper number of serial interface Bin Meng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.