From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
Peter Chen <peter.chen@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device()
Date: Tue, 26 Feb 2019 16:21:44 +0100 [thread overview]
Message-ID: <20190226152144.GA17948@kroah.com> (raw)
In-Reply-To: <d5e80295-977e-79b0-4f27-2134c52a6e6e@gmail.com>
On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote:
> 26.02.2019 17:58, Greg Kroah-Hartman пишет:
> > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote:
> >> 26.02.2019 13:56, Greg Kroah-Hartman пишет:
> >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote:
> >>>> В Mon, 25 Feb 2019 02:27:19 +0000
> >>>> Peter Chen <peter.chen@nxp.com> пишет:
> >>>>
> >>>>>
> >>>>>>
> >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for
> >>>>>> Tegra20/30/114/124")
> >>>>>
> >>>>> I suppose you need to apply at stable tree too, right?
> >>>>>
> >>>>
> >>>> It is enough to have the "Fixes" tag to get patch backported into all
> >>>> relevant kernel versions.
> >>>
> >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please
> >>> read:
> >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> >>> for how to do this properly.
> >>
> >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread.
> >
> > Why? It's allowed to put fixes: tags for a patch that does not belong
> > in a stable tree. That happens all the time, and is encouraged. Look
> > at some of the stuff in linux-next now, we have Fixes: for commits that
> > are still in linux-next as well, because we do not rebase our trees.
> > When they all merge into Linus's tree, all is good.
> >
> > So this is not something that checkpatch needs to do anything about.
>
> At least that might help in cases like this if maintainer is also oblivious.
If the maintainer is "oblivious", they are not going to be running
checkpatch :)
Remember, the "Fixes:" tag is a relatively new thing compared to the cc:
stable tag, which has been a documented requirement for over a decade.
Yes, some subsystems do not even do cc: stable, but that is because
those subsystem maintainers do not want to do it, or do not care.
Again, checkpatch is not going to help them.
checkpatch is not a panacea, people still have to use their brains.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
Peter Chen <peter.chen@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device()
Date: Tue, 26 Feb 2019 16:21:44 +0100 [thread overview]
Message-ID: <20190226152144.GA17948@kroah.com> (raw)
On Tue, Feb 26, 2019 at 06:08:17PM +0300, Dmitry Osipenko wrote:
> 26.02.2019 17:58, Greg Kroah-Hartman пишет:
> > On Tue, Feb 26, 2019 at 05:33:05PM +0300, Dmitry Osipenko wrote:
> >> 26.02.2019 13:56, Greg Kroah-Hartman пишет:
> >>> On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote:
> >>>> В Mon, 25 Feb 2019 02:27:19 +0000
> >>>> Peter Chen <peter.chen@nxp.com> пишет:
> >>>>
> >>>>>
> >>>>>>
> >>>>>> Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for
> >>>>>> Tegra20/30/114/124")
> >>>>>
> >>>>> I suppose you need to apply at stable tree too, right?
> >>>>>
> >>>>
> >>>> It is enough to have the "Fixes" tag to get patch backported into all
> >>>> relevant kernel versions.
> >>>
> >>> No it is not. My scripts do NOT trigger off of the fixes: tag, please
> >>> read:
> >>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> >>> for how to do this properly.
> >>
> >> Okay, my bad then. Maybe this is something that could warned by checkpatch.. adding Joe and Andy to the thread.
> >
> > Why? It's allowed to put fixes: tags for a patch that does not belong
> > in a stable tree. That happens all the time, and is encouraged. Look
> > at some of the stuff in linux-next now, we have Fixes: for commits that
> > are still in linux-next as well, because we do not rebase our trees.
> > When they all merge into Linus's tree, all is good.
> >
> > So this is not something that checkpatch needs to do anything about.
>
> At least that might help in cases like this if maintainer is also oblivious.
If the maintainer is "oblivious", they are not going to be running
checkpatch :)
Remember, the "Fixes:" tag is a relatively new thing compared to the cc:
stable tag, which has been a documented requirement for over a decade.
Yes, some subsystems do not even do cc: stable, but that is because
those subsystem maintainers do not want to do it, or do not care.
Again, checkpatch is not going to help them.
checkpatch is not a panacea, people still have to use their brains.
greg k-h
next prev parent reply other threads:[~2019-02-26 15:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 15:36 [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Dmitry Osipenko
2019-02-24 15:36 ` [v1] " Dmitry Osipenko
2019-02-25 2:27 ` [PATCH v1] " Peter Chen
2019-02-25 2:27 ` [v1] " Peter Chen
2019-02-25 5:07 ` [PATCH v1] " Dmitry Osipenko
2019-02-25 5:07 ` [v1] " Dmitry Osipenko
2019-02-26 10:56 ` [PATCH v1] " Greg Kroah-Hartman
2019-02-26 10:56 ` [v1] " Greg Kroah-Hartman
2019-02-26 14:33 ` [PATCH v1] " Dmitry Osipenko
2019-02-26 14:33 ` [v1] " Dmitry Osipenko
2019-02-26 14:58 ` [PATCH v1] " Greg Kroah-Hartman
2019-02-26 14:58 ` [v1] " Greg Kroah-Hartman
2019-02-26 15:08 ` [PATCH v1] " Dmitry Osipenko
2019-02-26 15:08 ` [v1] " Dmitry Osipenko
2019-02-26 15:21 ` Greg Kroah-Hartman [this message]
2019-02-26 15:21 ` Greg Kroah-Hartman
2019-02-26 15:40 ` [PATCH v1] " Dmitry Osipenko
2019-02-26 15:40 ` [v1] " Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226152144.GA17948@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=digetx@gmail.com \
--cc=joe@perches.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.