* [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-edac, linux-arm-kernel, linux-kernel
From: Thor Thayer <thor.thayer@linux.intel.com>
Most users want EDAC support so make it the default.
SOCFPGA SDRAM EDAC reporting was enabled by the parent EDAC
config (CONFIG_ALTERA_EDAC) since initial customers always
wanted SDRAM EDAC enabled.
There are cases where the SDRAM needs to be disabled while
the other block EDACs remain enabled.
This patch set 1) splits out the SDRAM EDAC into a separate
config and 2) enables all the EDAC blocks by default for
32 bit SOCFPGA.
V2 Changes
Rebase socfpga_defconfig against arm-soc/arm/defconfig
Thor Thayer (2):
EDAC, altera: Add separate SDRAM EDAC config
ARM: socfpga_defconfig: enable EDAC by default
arch/arm/configs/socfpga_defconfig | 12 +++++++
drivers/edac/Kconfig | 14 ++++++--
drivers/edac/altera_edac.c | 67 ++++++++++++++++++++------------------
3 files changed, 59 insertions(+), 34 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-kernel, linux-arm-kernel, linux-edac
From: Thor Thayer <thor.thayer@linux.intel.com>
Most users want EDAC support so make it the default.
SOCFPGA SDRAM EDAC reporting was enabled by the parent EDAC
config (CONFIG_ALTERA_EDAC) since initial customers always
wanted SDRAM EDAC enabled.
There are cases where the SDRAM needs to be disabled while
the other block EDACs remain enabled.
This patch set 1) splits out the SDRAM EDAC into a separate
config and 2) enables all the EDAC blocks by default for
32 bit SOCFPGA.
V2 Changes
Rebase socfpga_defconfig against arm-soc/arm/defconfig
Thor Thayer (2):
EDAC, altera: Add separate SDRAM EDAC config
ARM: socfpga_defconfig: enable EDAC by default
arch/arm/configs/socfpga_defconfig | 12 +++++++
drivers/edac/Kconfig | 14 ++++++--
drivers/edac/altera_edac.c | 67 ++++++++++++++++++++------------------
3 files changed, 59 insertions(+), 34 deletions(-)
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCHv2 1/2] EDAC, altera: Add separate SDRAM EDAC config
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-edac, linux-arm-kernel, linux-kernel
From: Thor Thayer <thor.thayer@linux.intel.com>
The CONFIG_ALTERA_EDAC flag always enables the SDRAM
EDAC. On the newer architectures, there are cases where
the peripheral EDACs are enabled but SDRAM needs to be
disabled.
This change moves SDRAM functions so they can be contained
inside the conditional CONFIG.
Create new CONFIG option just for SDRAM.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 No change
---
drivers/edac/Kconfig | 14 +++++++---
drivers/edac/altera_edac.c | 67 +++++++++++++++++++++++++---------------------
2 files changed, 47 insertions(+), 34 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 102a47a09f25..47eb4d13ed5f 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -391,9 +391,17 @@ config EDAC_ALTERA
depends on EDAC=y && (ARCH_SOCFPGA || ARCH_STRATIX10)
help
Support for error detection and correction on the
- Altera SOCs. This must be selected for SDRAM ECC.
- Note that the preloader must initialize the SDRAM
- before loading the kernel.
+ Altera SOCs. This is the global enable for the
+ various Altera peripherals.
+
+config EDAC_ALTERA_SDRAM
+ bool "Altera SDRAM ECC"
+ depends on EDAC_ALTERA=y
+ help
+ Support for error detection and correction on the
+ Altera SDRAM Memory for Altera SoCs. Note that the
+ preloader must initialize the SDRAM before loading
+ the kernel.
config EDAC_ALTERA_L2C
bool "Altera L2 Cache ECC"
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 98e0bd8d9f50..1bcf9aea0cdf 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -29,6 +29,7 @@
#define EDAC_MOD_STR "altera_edac"
#define EDAC_DEVICE "Altera"
+#ifdef CONFIG_EDAC_ALTERA_SDRAM
static const struct altr_sdram_prv_data c5_data = {
.ecc_ctrl_offset = CV_CTLCFG_OFST,
.ecc_ctl_en_mask = CV_CTLCFG_ECC_AUTO_EN,
@@ -468,6 +469,39 @@ static int altr_sdram_remove(struct platform_device *pdev)
return 0;
}
+/*
+ * If you want to suspend, need to disable EDAC by removing it
+ * from the device tree or defconfig.
+ */
+#ifdef CONFIG_PM
+static int altr_sdram_prepare(struct device *dev)
+{
+ pr_err("Suspend not allowed when EDAC is enabled.\n");
+
+ return -EPERM;
+}
+
+static const struct dev_pm_ops altr_sdram_pm_ops = {
+ .prepare = altr_sdram_prepare,
+};
+#endif
+
+static struct platform_driver altr_sdram_edac_driver = {
+ .probe = altr_sdram_probe,
+ .remove = altr_sdram_remove,
+ .driver = {
+ .name = "altr_sdram_edac",
+#ifdef CONFIG_PM
+ .pm = &altr_sdram_pm_ops,
+#endif
+ .of_match_table = altr_sdram_ctrl_of_match,
+ },
+};
+
+module_platform_driver(altr_sdram_edac_driver);
+
+#endif /* CONFIG_EDAC_ALTERA_SDRAM */
+
/**************** Stratix 10 EDAC Memory Controller Functions ************/
/**
@@ -530,37 +564,6 @@ static const struct regmap_config s10_sdram_regmap_cfg = {
/************** </Stratix10 EDAC Memory Controller Functions> ***********/
-/*
- * If you want to suspend, need to disable EDAC by removing it
- * from the device tree or defconfig.
- */
-#ifdef CONFIG_PM
-static int altr_sdram_prepare(struct device *dev)
-{
- pr_err("Suspend not allowed when EDAC is enabled.\n");
-
- return -EPERM;
-}
-
-static const struct dev_pm_ops altr_sdram_pm_ops = {
- .prepare = altr_sdram_prepare,
-};
-#endif
-
-static struct platform_driver altr_sdram_edac_driver = {
- .probe = altr_sdram_probe,
- .remove = altr_sdram_remove,
- .driver = {
- .name = "altr_sdram_edac",
-#ifdef CONFIG_PM
- .pm = &altr_sdram_pm_ops,
-#endif
- .of_match_table = altr_sdram_ctrl_of_match,
- },
-};
-
-module_platform_driver(altr_sdram_edac_driver);
-
/************************* EDAC Parent Probe *************************/
static const struct of_device_id altr_edac_device_of_match[];
@@ -2143,11 +2146,13 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
altr_edac_a10_device_add(edac, child);
+#ifdef CONFIG_EDAC_ALTERA_SDRAM
else if ((of_device_is_compatible(child, "altr,sdram-edac-a10")) ||
(of_device_is_compatible(child, "altr,sdram-edac-s10")))
of_platform_populate(pdev->dev.of_node,
altr_sdram_ctrl_of_match,
NULL, &pdev->dev);
+#endif
}
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCHv2,1/2] EDAC, altera: Add separate SDRAM EDAC config
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-edac, linux-arm-kernel, linux-kernel
From: Thor Thayer <thor.thayer@linux.intel.com>
The CONFIG_ALTERA_EDAC flag always enables the SDRAM
EDAC. On the newer architectures, there are cases where
the peripheral EDACs are enabled but SDRAM needs to be
disabled.
This change moves SDRAM functions so they can be contained
inside the conditional CONFIG.
Create new CONFIG option just for SDRAM.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 No change
---
drivers/edac/Kconfig | 14 +++++++---
drivers/edac/altera_edac.c | 67 +++++++++++++++++++++++++---------------------
2 files changed, 47 insertions(+), 34 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 102a47a09f25..47eb4d13ed5f 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -391,9 +391,17 @@ config EDAC_ALTERA
depends on EDAC=y && (ARCH_SOCFPGA || ARCH_STRATIX10)
help
Support for error detection and correction on the
- Altera SOCs. This must be selected for SDRAM ECC.
- Note that the preloader must initialize the SDRAM
- before loading the kernel.
+ Altera SOCs. This is the global enable for the
+ various Altera peripherals.
+
+config EDAC_ALTERA_SDRAM
+ bool "Altera SDRAM ECC"
+ depends on EDAC_ALTERA=y
+ help
+ Support for error detection and correction on the
+ Altera SDRAM Memory for Altera SoCs. Note that the
+ preloader must initialize the SDRAM before loading
+ the kernel.
config EDAC_ALTERA_L2C
bool "Altera L2 Cache ECC"
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 98e0bd8d9f50..1bcf9aea0cdf 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -29,6 +29,7 @@
#define EDAC_MOD_STR "altera_edac"
#define EDAC_DEVICE "Altera"
+#ifdef CONFIG_EDAC_ALTERA_SDRAM
static const struct altr_sdram_prv_data c5_data = {
.ecc_ctrl_offset = CV_CTLCFG_OFST,
.ecc_ctl_en_mask = CV_CTLCFG_ECC_AUTO_EN,
@@ -468,6 +469,39 @@ static int altr_sdram_remove(struct platform_device *pdev)
return 0;
}
+/*
+ * If you want to suspend, need to disable EDAC by removing it
+ * from the device tree or defconfig.
+ */
+#ifdef CONFIG_PM
+static int altr_sdram_prepare(struct device *dev)
+{
+ pr_err("Suspend not allowed when EDAC is enabled.\n");
+
+ return -EPERM;
+}
+
+static const struct dev_pm_ops altr_sdram_pm_ops = {
+ .prepare = altr_sdram_prepare,
+};
+#endif
+
+static struct platform_driver altr_sdram_edac_driver = {
+ .probe = altr_sdram_probe,
+ .remove = altr_sdram_remove,
+ .driver = {
+ .name = "altr_sdram_edac",
+#ifdef CONFIG_PM
+ .pm = &altr_sdram_pm_ops,
+#endif
+ .of_match_table = altr_sdram_ctrl_of_match,
+ },
+};
+
+module_platform_driver(altr_sdram_edac_driver);
+
+#endif /* CONFIG_EDAC_ALTERA_SDRAM */
+
/**************** Stratix 10 EDAC Memory Controller Functions ************/
/**
@@ -530,37 +564,6 @@ static const struct regmap_config s10_sdram_regmap_cfg = {
/************** </Stratix10 EDAC Memory Controller Functions> ***********/
-/*
- * If you want to suspend, need to disable EDAC by removing it
- * from the device tree or defconfig.
- */
-#ifdef CONFIG_PM
-static int altr_sdram_prepare(struct device *dev)
-{
- pr_err("Suspend not allowed when EDAC is enabled.\n");
-
- return -EPERM;
-}
-
-static const struct dev_pm_ops altr_sdram_pm_ops = {
- .prepare = altr_sdram_prepare,
-};
-#endif
-
-static struct platform_driver altr_sdram_edac_driver = {
- .probe = altr_sdram_probe,
- .remove = altr_sdram_remove,
- .driver = {
- .name = "altr_sdram_edac",
-#ifdef CONFIG_PM
- .pm = &altr_sdram_pm_ops,
-#endif
- .of_match_table = altr_sdram_ctrl_of_match,
- },
-};
-
-module_platform_driver(altr_sdram_edac_driver);
-
/************************* EDAC Parent Probe *************************/
static const struct of_device_id altr_edac_device_of_match[];
@@ -2143,11 +2146,13 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
altr_edac_a10_device_add(edac, child);
+#ifdef CONFIG_EDAC_ALTERA_SDRAM
else if ((of_device_is_compatible(child, "altr,sdram-edac-a10")) ||
(of_device_is_compatible(child, "altr,sdram-edac-s10")))
of_platform_populate(pdev->dev.of_node,
altr_sdram_ctrl_of_match,
NULL, &pdev->dev);
+#endif
}
return 0;
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCHv2 1/2] EDAC, altera: Add separate SDRAM EDAC config
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-kernel, linux-arm-kernel, linux-edac
From: Thor Thayer <thor.thayer@linux.intel.com>
The CONFIG_ALTERA_EDAC flag always enables the SDRAM
EDAC. On the newer architectures, there are cases where
the peripheral EDACs are enabled but SDRAM needs to be
disabled.
This change moves SDRAM functions so they can be contained
inside the conditional CONFIG.
Create new CONFIG option just for SDRAM.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 No change
---
drivers/edac/Kconfig | 14 +++++++---
drivers/edac/altera_edac.c | 67 +++++++++++++++++++++++++---------------------
2 files changed, 47 insertions(+), 34 deletions(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 102a47a09f25..47eb4d13ed5f 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -391,9 +391,17 @@ config EDAC_ALTERA
depends on EDAC=y && (ARCH_SOCFPGA || ARCH_STRATIX10)
help
Support for error detection and correction on the
- Altera SOCs. This must be selected for SDRAM ECC.
- Note that the preloader must initialize the SDRAM
- before loading the kernel.
+ Altera SOCs. This is the global enable for the
+ various Altera peripherals.
+
+config EDAC_ALTERA_SDRAM
+ bool "Altera SDRAM ECC"
+ depends on EDAC_ALTERA=y
+ help
+ Support for error detection and correction on the
+ Altera SDRAM Memory for Altera SoCs. Note that the
+ preloader must initialize the SDRAM before loading
+ the kernel.
config EDAC_ALTERA_L2C
bool "Altera L2 Cache ECC"
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 98e0bd8d9f50..1bcf9aea0cdf 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -29,6 +29,7 @@
#define EDAC_MOD_STR "altera_edac"
#define EDAC_DEVICE "Altera"
+#ifdef CONFIG_EDAC_ALTERA_SDRAM
static const struct altr_sdram_prv_data c5_data = {
.ecc_ctrl_offset = CV_CTLCFG_OFST,
.ecc_ctl_en_mask = CV_CTLCFG_ECC_AUTO_EN,
@@ -468,6 +469,39 @@ static int altr_sdram_remove(struct platform_device *pdev)
return 0;
}
+/*
+ * If you want to suspend, need to disable EDAC by removing it
+ * from the device tree or defconfig.
+ */
+#ifdef CONFIG_PM
+static int altr_sdram_prepare(struct device *dev)
+{
+ pr_err("Suspend not allowed when EDAC is enabled.\n");
+
+ return -EPERM;
+}
+
+static const struct dev_pm_ops altr_sdram_pm_ops = {
+ .prepare = altr_sdram_prepare,
+};
+#endif
+
+static struct platform_driver altr_sdram_edac_driver = {
+ .probe = altr_sdram_probe,
+ .remove = altr_sdram_remove,
+ .driver = {
+ .name = "altr_sdram_edac",
+#ifdef CONFIG_PM
+ .pm = &altr_sdram_pm_ops,
+#endif
+ .of_match_table = altr_sdram_ctrl_of_match,
+ },
+};
+
+module_platform_driver(altr_sdram_edac_driver);
+
+#endif /* CONFIG_EDAC_ALTERA_SDRAM */
+
/**************** Stratix 10 EDAC Memory Controller Functions ************/
/**
@@ -530,37 +564,6 @@ static const struct regmap_config s10_sdram_regmap_cfg = {
/************** </Stratix10 EDAC Memory Controller Functions> ***********/
-/*
- * If you want to suspend, need to disable EDAC by removing it
- * from the device tree or defconfig.
- */
-#ifdef CONFIG_PM
-static int altr_sdram_prepare(struct device *dev)
-{
- pr_err("Suspend not allowed when EDAC is enabled.\n");
-
- return -EPERM;
-}
-
-static const struct dev_pm_ops altr_sdram_pm_ops = {
- .prepare = altr_sdram_prepare,
-};
-#endif
-
-static struct platform_driver altr_sdram_edac_driver = {
- .probe = altr_sdram_probe,
- .remove = altr_sdram_remove,
- .driver = {
- .name = "altr_sdram_edac",
-#ifdef CONFIG_PM
- .pm = &altr_sdram_pm_ops,
-#endif
- .of_match_table = altr_sdram_ctrl_of_match,
- },
-};
-
-module_platform_driver(altr_sdram_edac_driver);
-
/************************* EDAC Parent Probe *************************/
static const struct of_device_id altr_edac_device_of_match[];
@@ -2143,11 +2146,13 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
altr_edac_a10_device_add(edac, child);
+#ifdef CONFIG_EDAC_ALTERA_SDRAM
else if ((of_device_is_compatible(child, "altr,sdram-edac-a10")) ||
(of_device_is_compatible(child, "altr,sdram-edac-s10")))
of_platform_populate(pdev->dev.of_node,
altr_sdram_ctrl_of_match,
NULL, &pdev->dev);
+#endif
}
return 0;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCHv2 2/2] ARM: socfpga_defconfig: enable EDAC by default
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-edac, linux-arm-kernel, linux-kernel
From: Thor Thayer <thor.thayer@linux.intel.com>
Enable the different ECC blocks by default on Cyclone5
and Arria10.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 Rebase patch to the arm/defconfig on the arm-soc tree
---
arch/arm/configs/socfpga_defconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index 08d1b3e11d68..1f2056c76ef1 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -122,11 +122,23 @@ CONFIG_LEDS_GPIO=y
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=y
CONFIG_LEDS_TRIGGER_CPU=y
+CONFIG_EDAC=y
+CONFIG_EDAC_ALTERA=y
+CONFIG_EDAC_ALTERA_SDRAM=y
+CONFIG_EDAC_ALTERA_L2C=y
+CONFIG_EDAC_ALTERA_OCRAM=y
+CONFIG_EDAC_ALTERA_ETHERNET=y
+CONFIG_EDAC_ALTERA_NAND=y
+CONFIG_EDAC_ALTERA_DMA=y
+CONFIG_EDAC_ALTERA_USB=y
+CONFIG_EDAC_ALTERA_QSPI=y
+CONFIG_EDAC_ALTERA_SDMMC=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_DS1307=y
CONFIG_DMADEVICES=y
CONFIG_PL330_DMA=y
CONFIG_DMATEST=m
+CONFIG_RAS=y
CONFIG_FPGA=y
CONFIG_FPGA_MGR_SOCFPGA=y
CONFIG_FPGA_MGR_SOCFPGA_A10=y
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCHv2,2/2] ARM: socfpga_defconfig: enable EDAC by default
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-edac, linux-arm-kernel, linux-kernel
From: Thor Thayer <thor.thayer@linux.intel.com>
Enable the different ECC blocks by default on Cyclone5
and Arria10.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 Rebase patch to the arm/defconfig on the arm-soc tree
---
arch/arm/configs/socfpga_defconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index 08d1b3e11d68..1f2056c76ef1 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -122,11 +122,23 @@ CONFIG_LEDS_GPIO=y
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=y
CONFIG_LEDS_TRIGGER_CPU=y
+CONFIG_EDAC=y
+CONFIG_EDAC_ALTERA=y
+CONFIG_EDAC_ALTERA_SDRAM=y
+CONFIG_EDAC_ALTERA_L2C=y
+CONFIG_EDAC_ALTERA_OCRAM=y
+CONFIG_EDAC_ALTERA_ETHERNET=y
+CONFIG_EDAC_ALTERA_NAND=y
+CONFIG_EDAC_ALTERA_DMA=y
+CONFIG_EDAC_ALTERA_USB=y
+CONFIG_EDAC_ALTERA_QSPI=y
+CONFIG_EDAC_ALTERA_SDMMC=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_DS1307=y
CONFIG_DMADEVICES=y
CONFIG_PL330_DMA=y
CONFIG_DMATEST=m
+CONFIG_RAS=y
CONFIG_FPGA=y
CONFIG_FPGA_MGR_SOCFPGA=y
CONFIG_FPGA_MGR_SOCFPGA_A10=y
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCHv2 2/2] ARM: socfpga_defconfig: enable EDAC by default
@ 2019-02-25 18:56 ` thor.thayer
0 siblings, 0 replies; 14+ messages in thread
From: thor.thayer @ 2019-02-25 18:56 UTC (permalink / raw)
To: bp, dinguyen, linux, mchehab, james.morse
Cc: thor.thayer, linux-kernel, linux-arm-kernel, linux-edac
From: Thor Thayer <thor.thayer@linux.intel.com>
Enable the different ECC blocks by default on Cyclone5
and Arria10.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 Rebase patch to the arm/defconfig on the arm-soc tree
---
arch/arm/configs/socfpga_defconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index 08d1b3e11d68..1f2056c76ef1 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -122,11 +122,23 @@ CONFIG_LEDS_GPIO=y
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=y
CONFIG_LEDS_TRIGGER_CPU=y
+CONFIG_EDAC=y
+CONFIG_EDAC_ALTERA=y
+CONFIG_EDAC_ALTERA_SDRAM=y
+CONFIG_EDAC_ALTERA_L2C=y
+CONFIG_EDAC_ALTERA_OCRAM=y
+CONFIG_EDAC_ALTERA_ETHERNET=y
+CONFIG_EDAC_ALTERA_NAND=y
+CONFIG_EDAC_ALTERA_DMA=y
+CONFIG_EDAC_ALTERA_USB=y
+CONFIG_EDAC_ALTERA_QSPI=y
+CONFIG_EDAC_ALTERA_SDMMC=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_DS1307=y
CONFIG_DMADEVICES=y
CONFIG_PL330_DMA=y
CONFIG_DMATEST=m
+CONFIG_RAS=y
CONFIG_FPGA=y
CONFIG_FPGA_MGR_SOCFPGA=y
CONFIG_FPGA_MGR_SOCFPGA_A10=y
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
2019-02-25 18:56 ` thor.thayer
@ 2019-02-25 20:42 ` Borislav Petkov
-1 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2019-02-25 20:42 UTC (permalink / raw)
To: thor.thayer
Cc: dinguyen, linux, mchehab, james.morse, linux-edac,
linux-arm-kernel, linux-kernel
On Mon, Feb 25, 2019 at 12:56:44PM -0600, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
>
> Most users want EDAC support so make it the default.
>
> SOCFPGA SDRAM EDAC reporting was enabled by the parent EDAC
> config (CONFIG_ALTERA_EDAC) since initial customers always
> wanted SDRAM EDAC enabled.
> There are cases where the SDRAM needs to be disabled while
> the other block EDACs remain enabled.
> This patch set 1) splits out the SDRAM EDAC into a separate
> config and 2) enables all the EDAC blocks by default for
> 32 bit SOCFPGA.
>
> V2 Changes
> Rebase socfpga_defconfig against arm-soc/arm/defconfig
>
> Thor Thayer (2):
> EDAC, altera: Add separate SDRAM EDAC config
> ARM: socfpga_defconfig: enable EDAC by default
Am I supposed to take the second patch too or is it going through Dinh's
tree?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
@ 2019-02-25 20:42 ` Borislav Petkov
0 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2019-02-25 20:42 UTC (permalink / raw)
To: thor.thayer
Cc: linux, linux-kernel, dinguyen, james.morse, mchehab,
linux-arm-kernel, linux-edac
On Mon, Feb 25, 2019 at 12:56:44PM -0600, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
>
> Most users want EDAC support so make it the default.
>
> SOCFPGA SDRAM EDAC reporting was enabled by the parent EDAC
> config (CONFIG_ALTERA_EDAC) since initial customers always
> wanted SDRAM EDAC enabled.
> There are cases where the SDRAM needs to be disabled while
> the other block EDACs remain enabled.
> This patch set 1) splits out the SDRAM EDAC into a separate
> config and 2) enables all the EDAC blocks by default for
> 32 bit SOCFPGA.
>
> V2 Changes
> Rebase socfpga_defconfig against arm-soc/arm/defconfig
>
> Thor Thayer (2):
> EDAC, altera: Add separate SDRAM EDAC config
> ARM: socfpga_defconfig: enable EDAC by default
Am I supposed to take the second patch too or is it going through Dinh's
tree?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
2019-02-25 20:42 ` Borislav Petkov
@ 2019-02-26 14:59 ` Dinh Nguyen
-1 siblings, 0 replies; 14+ messages in thread
From: Dinh Nguyen @ 2019-02-26 14:59 UTC (permalink / raw)
To: Borislav Petkov, thor.thayer
Cc: linux, mchehab, james.morse, linux-edac, linux-arm-kernel, linux-kernel
Hi Boris,
On 2/25/19 2:42 PM, Borislav Petkov wrote:
> On Mon, Feb 25, 2019 at 12:56:44PM -0600, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Most users want EDAC support so make it the default.
>>
>> SOCFPGA SDRAM EDAC reporting was enabled by the parent EDAC
>> config (CONFIG_ALTERA_EDAC) since initial customers always
>> wanted SDRAM EDAC enabled.
>> There are cases where the SDRAM needs to be disabled while
>> the other block EDACs remain enabled.
>> This patch set 1) splits out the SDRAM EDAC into a separate
>> config and 2) enables all the EDAC blocks by default for
>> 32 bit SOCFPGA.
>>
>> V2 Changes
>> Rebase socfpga_defconfig against arm-soc/arm/defconfig
>>
>> Thor Thayer (2):
>> EDAC, altera: Add separate SDRAM EDAC config
>> ARM: socfpga_defconfig: enable EDAC by default
>
> Am I supposed to take the second patch too or is it going through Dinh's
> tree?
>
If you don't mind, I'll take the defconfig patch to avoid any conflicts.
Thanks,
Dinh
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
@ 2019-02-26 14:59 ` Dinh Nguyen
0 siblings, 0 replies; 14+ messages in thread
From: Dinh Nguyen @ 2019-02-26 14:59 UTC (permalink / raw)
To: Borislav Petkov, thor.thayer
Cc: linux-kernel, linux, james.morse, mchehab, linux-arm-kernel, linux-edac
Hi Boris,
On 2/25/19 2:42 PM, Borislav Petkov wrote:
> On Mon, Feb 25, 2019 at 12:56:44PM -0600, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Most users want EDAC support so make it the default.
>>
>> SOCFPGA SDRAM EDAC reporting was enabled by the parent EDAC
>> config (CONFIG_ALTERA_EDAC) since initial customers always
>> wanted SDRAM EDAC enabled.
>> There are cases where the SDRAM needs to be disabled while
>> the other block EDACs remain enabled.
>> This patch set 1) splits out the SDRAM EDAC into a separate
>> config and 2) enables all the EDAC blocks by default for
>> 32 bit SOCFPGA.
>>
>> V2 Changes
>> Rebase socfpga_defconfig against arm-soc/arm/defconfig
>>
>> Thor Thayer (2):
>> EDAC, altera: Add separate SDRAM EDAC config
>> ARM: socfpga_defconfig: enable EDAC by default
>
> Am I supposed to take the second patch too or is it going through Dinh's
> tree?
>
If you don't mind, I'll take the defconfig patch to avoid any conflicts.
Thanks,
Dinh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
2019-02-26 14:59 ` Dinh Nguyen
@ 2019-02-26 17:47 ` Borislav Petkov
-1 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2019-02-26 17:47 UTC (permalink / raw)
To: Dinh Nguyen
Cc: thor.thayer, linux, mchehab, james.morse, linux-edac,
linux-arm-kernel, linux-kernel
On Tue, Feb 26, 2019 at 08:59:43AM -0600, Dinh Nguyen wrote:
> If you don't mind, I'll take the defconfig patch to avoid any conflicts.
Ok, thanks. Applied the first one.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config
@ 2019-02-26 17:47 ` Borislav Petkov
0 siblings, 0 replies; 14+ messages in thread
From: Borislav Petkov @ 2019-02-26 17:47 UTC (permalink / raw)
To: Dinh Nguyen
Cc: thor.thayer, linux, linux-kernel, james.morse, mchehab,
linux-arm-kernel, linux-edac
On Tue, Feb 26, 2019 at 08:59:43AM -0600, Dinh Nguyen wrote:
> If you don't mind, I'll take the defconfig patch to avoid any conflicts.
Ok, thanks. Applied the first one.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-02-26 17:47 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 18:56 [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config thor.thayer
2019-02-25 18:56 ` thor.thayer
2019-02-25 18:56 ` [PATCHv2 1/2] EDAC, altera: Add separate " thor.thayer
2019-02-25 18:56 ` thor.thayer
2019-02-25 18:56 ` [PATCHv2,1/2] " thor.thayer
2019-02-25 18:56 ` [PATCHv2 2/2] ARM: socfpga_defconfig: enable EDAC by default thor.thayer
2019-02-25 18:56 ` thor.thayer
2019-02-25 18:56 ` [PATCHv2,2/2] " thor.thayer
2019-02-25 20:42 ` [PATCHv2 0/2] Independent SOCFPGA SDRAM EDAC config Borislav Petkov
2019-02-25 20:42 ` Borislav Petkov
2019-02-26 14:59 ` Dinh Nguyen
2019-02-26 14:59 ` Dinh Nguyen
2019-02-26 17:47 ` Borislav Petkov
2019-02-26 17:47 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.