* [PATCH v3] Staging: vt6655: Alignment of function declaration
@ 2019-02-27 16:12 Madhumitha Prabakaran
2019-02-27 16:29 ` Greg KH
2019-02-27 19:44 ` [Outreachy kernel] " Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: Madhumitha Prabakaran @ 2019-02-27 16:12 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Align function arguments and function type to improve readability.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
Changes in v3-
-Included driver name in subject line
Changes in v2-
- Modified subject line and commit log
---
drivers/staging/vt6655/card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2996bf614caa..8d0182f5725c 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
return bResult;
}
-void CARDvSafeResetTx(truct vnt_private *priv)
+void CARDvSafeResetTx(struct vnt_private *priv)
{
unsigned int uu;
struct vnt_tx_desc *pCurrTD;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Staging: vt6655: Alignment of function declaration
2019-02-27 16:12 [PATCH v3] Staging: vt6655: Alignment of function declaration Madhumitha Prabakaran
@ 2019-02-27 16:29 ` Greg KH
2019-02-27 19:44 ` [Outreachy kernel] " Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-02-27 16:29 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel
On Wed, Feb 27, 2019 at 10:12:27AM -0600, Madhumitha Prabakaran wrote:
> Align function arguments and function type to improve readability.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v3-
> -Included driver name in subject line
>
> Changes in v2-
> - Modified subject line and commit log
> ---
> drivers/staging/vt6655/card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 2996bf614caa..8d0182f5725c 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
> return bResult;
> }
>
> -void CARDvSafeResetTx(truct vnt_private *priv)
> +void CARDvSafeResetTx(struct vnt_private *priv)
Are you sure about this patch???
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] Staging: vt6655: Alignment of function declaration
2019-02-27 16:12 [PATCH v3] Staging: vt6655: Alignment of function declaration Madhumitha Prabakaran
2019-02-27 16:29 ` Greg KH
@ 2019-02-27 19:44 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-02-27 19:44 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, gregkh, outreachy-kernel
On Wed, 27 Feb 2019, Madhumitha Prabakaran wrote:
> Align function arguments and function type to improve readability.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v3-
> -Included driver name in subject line
>
> Changes in v2-
> - Modified subject line and commit log
> ---
> drivers/staging/vt6655/card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 2996bf614caa..8d0182f5725c 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -499,7 +499,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
> return bResult;
> }
>
> -void CARDvSafeResetTx(truct vnt_private *priv)
This is invalid code and clearly was not in the kernel previously. I
think that you are making your changes based on some change you previously
made, rather than based on the code in Greg's tree.
julia
> +void CARDvSafeResetTx(struct vnt_private *priv)
> {
> unsigned int uu;
> struct vnt_tx_desc *pCurrTD;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227161227.22128-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-27 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 16:12 [PATCH v3] Staging: vt6655: Alignment of function declaration Madhumitha Prabakaran
2019-02-27 16:29 ` Greg KH
2019-02-27 19:44 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.