[PATCH v4] Staging: vt6655: Alignment of function declaration

[PATCH v4] Staging: vt6655: Alignment of function declaration

[Madhumitha Prabakaran]

Align function arguments and function type to improve readability.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
Changes in v4-
- Log message and git diff are matching. Change is made on code in
Greg's tree

Changes in v3-
- Included driver name in subject line

Changes in v2-
- Modified subject line and commit log
---
 drivers/staging/vt6655/card.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 52e9e6b90b56..3226dbaab3bb 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -506,10 +506,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
 	return bResult;
 }
 
-void
-CARDvSafeResetTx(
-	struct vnt_private *priv
-)
+void CARDvSafeResetTx(struct vnt_private *priv)
 {
 	unsigned int uu;
 	struct vnt_tx_desc *pCurrTD;
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v4] Staging: vt6655: Alignment of function declaration

[Julia Lawall]

On Wed, 27 Feb 2019, Madhumitha Prabakaran wrote:

> Align function arguments and function type to improve readability.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> Changes in v4-
> - Log message and git diff are matching. Change is made on code in
> Greg's tree
>
> Changes in v3-
> - Included driver name in subject line
>
> Changes in v2-
> - Modified subject line and commit log
> ---
>  drivers/staging/vt6655/card.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 52e9e6b90b56..3226dbaab3bb 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -506,10 +506,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv)
>  	return bResult;
>  }
>
> -void
> -CARDvSafeResetTx(
> -	struct vnt_private *priv
> -)
> +void CARDvSafeResetTx(struct vnt_private *priv)

This looks better.  I pulled Greg's tree and this applied fine.

julia

>  {
>  	unsigned int uu;
>  	struct vnt_tx_desc *pCurrTD;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190227205040.9881-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>