* [PATCH] crypto: stm32 drop pointless static qualifier in stm32_hash_remove()
@ 2019-02-18 14:49 ` Mao Wenan
0 siblings, 0 replies; 4+ messages in thread
From: Mao Wenan @ 2019-02-18 14:49 UTC (permalink / raw)
To: linux-crypto, kernel-janitors, mcoquelin.stm32, clabbe.montjoie,
gilad, ebiggers, keescook, alexandre.torgue
There is no need to have the struct stm32_hash_dev *hdev static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/crypto/stm32/stm32-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index 590d7352837e..4a6cc8a3045d 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -1564,7 +1564,7 @@ static int stm32_hash_probe(struct platform_device *pdev)
static int stm32_hash_remove(struct platform_device *pdev)
{
- static struct stm32_hash_dev *hdev;
+ struct stm32_hash_dev *hdev;
int ret;
hdev = platform_get_drvdata(pdev);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] crypto: stm32 drop pointless static qualifier in stm32_hash_remove()
@ 2019-02-18 14:49 ` Mao Wenan
0 siblings, 0 replies; 4+ messages in thread
From: Mao Wenan @ 2019-02-18 14:49 UTC (permalink / raw)
To: linux-crypto, kernel-janitors, mcoquelin.stm32, clabbe.montjoie,
gilad, ebiggers, keescook, alexandre.torgue
There is no need to have the struct stm32_hash_dev *hdev static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/crypto/stm32/stm32-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index 590d7352837e..4a6cc8a3045d 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -1564,7 +1564,7 @@ static int stm32_hash_probe(struct platform_device *pdev)
static int stm32_hash_remove(struct platform_device *pdev)
{
- static struct stm32_hash_dev *hdev;
+ struct stm32_hash_dev *hdev;
int ret;
hdev = platform_get_drvdata(pdev);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: stm32 - drop pointless static qualifier in stm32_hash_remove()
2019-02-18 14:49 ` Mao Wenan
@ 2019-02-28 6:28 ` Herbert Xu
-1 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-02-28 6:28 UTC (permalink / raw)
To: Mao Wenan
Cc: linux-crypto, kernel-janitors, mcoquelin.stm32, clabbe.montjoie,
gilad, ebiggers, keescook, alexandre.torgue
On Mon, Feb 18, 2019 at 10:49:00PM +0800, Mao Wenan wrote:
> There is no need to have the struct stm32_hash_dev *hdev static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/crypto/stm32/stm32-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: stm32 - drop pointless static qualifier in stm32_hash_remove()
@ 2019-02-28 6:28 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-02-28 6:28 UTC (permalink / raw)
To: Mao Wenan
Cc: linux-crypto, kernel-janitors, mcoquelin.stm32, clabbe.montjoie,
gilad, ebiggers, keescook, alexandre.torgue
On Mon, Feb 18, 2019 at 10:49:00PM +0800, Mao Wenan wrote:
> There is no need to have the struct stm32_hash_dev *hdev static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/crypto/stm32/stm32-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-28 6:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 14:49 [PATCH] crypto: stm32 drop pointless static qualifier in stm32_hash_remove() Mao Wenan
2019-02-18 14:49 ` Mao Wenan
2019-02-28 6:28 ` [PATCH] crypto: stm32 - " Herbert Xu
2019-02-28 6:28 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.