[U-Boot] [PATCH v2 1/2] x86: edison: Use proper number of serial interface

[U-Boot] [PATCH v2 1/2] x86: edison: Use proper number of serial interface

[Andy Shevchenko]

The console is actually serial #2. When we would like to enable other ports,
this would be not okay to mess up with the ordering.

Thus, fix the number of default console interface to be 2.

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/dts/edison.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index 0dd72407ea..b59171cb50 100644
--- a/arch/x86/dts/edison.dts
+++ b/arch/x86/dts/edison.dts
@@ -17,11 +17,11 @@
 	compatible = "intel,edison";
 
 	aliases {
-		serial0 = &serial0;
+		serial2 = &serial2;
 	};
 
 	chosen {
-		stdout-path = &serial0;
+		stdout-path = &serial2;
 	};
 
 	cpus {
@@ -53,7 +53,7 @@
 			  0x01000000 0x0 0x2000 0x2000 0 0xe000>;
 	};
 
-	serial0: serial at ff010180 {
+	serial2: serial at ff010180 {
 		compatible = "intel,mid-uart";
 		reg = <0xff010180 0x100>;
 		reg-shift = <0>;
-- 
2.20.1

[U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board

[Andy Shevchenko]

Intel Edison has three UART ports, i.e.
 port 0 - Bluetooth
 port 1 - auxiliary, available for general purpose use
 port 2 - debugging, usually console output is here

Enable all of them for future use.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/dts/edison.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index b59171cb50..ea336eac19 100644
--- a/arch/x86/dts/edison.dts
+++ b/arch/x86/dts/edison.dts
@@ -17,6 +17,8 @@
 	compatible = "intel,edison";
 
 	aliases {
+		serial0 = &serial0;
+		serial1 = &serial1;
 		serial2 = &serial2;
 	};
 
@@ -53,6 +55,22 @@
 			  0x01000000 0x0 0x2000 0x2000 0 0xe000>;
 	};
 
+	serial0: serial at ff010080 {
+		compatible = "intel,mid-uart";
+		reg = <0xff010080 0x100>;
+		reg-shift = <0>;
+		clock-frequency = <29491200>;
+		current-speed = <115200>;
+	};
+
+	serial1: serial at ff010100 {
+		compatible = "intel,mid-uart";
+		reg = <0xff010100 0x100>;
+		reg-shift = <0>;
+		clock-frequency = <29491200>;
+		current-speed = <115200>;
+	};
+
 	serial2: serial at ff010180 {
 		compatible = "intel,mid-uart";
 		reg = <0xff010180 0x100>;
-- 
2.20.1

[U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board

[Bin Meng]

On Thu, Feb 28, 2019 at 4:12 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Intel Edison has three UART ports, i.e.
>  port 0 - Bluetooth
>  port 1 - auxiliary, available for general purpose use
>  port 2 - debugging, usually console output is here
>
> Enable all of them for future use.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/dts/edison.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board

[Andy Shevchenko]

On Thu, Feb 28, 2019 at 04:21:48PM +0800, Bin Meng wrote:
> On Thu, Feb 28, 2019 at 4:12 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Intel Edison has three UART ports, i.e.
> >  port 0 - Bluetooth
> >  port 1 - auxiliary, available for general purpose use
> >  port 2 - debugging, usually console output is here
> >
> > Enable all of them for future use.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/dts/edison.dts | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> 
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Thanks, but please defer this series. It made a regression.

-- 
With Best Regards,
Andy Shevchenko

[U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board

[Andy Shevchenko]

On Thu, Feb 28, 2019 at 01:29:57PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 28, 2019 at 04:21:48PM +0800, Bin Meng wrote:
> > On Thu, Feb 28, 2019 at 4:12 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > Intel Edison has three UART ports, i.e.
> > >  port 0 - Bluetooth
> > >  port 1 - auxiliary, available for general purpose use
> > >  port 2 - debugging, usually console output is here
> > >
> > > Enable all of them for future use.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  arch/x86/dts/edison.dts | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> > 
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> 
> Thanks, but please defer this series. It made a regression.

I found the root cause.

It's a regression in the

commit a61cbad78e67963944e7d719f0aee27b8aef6c02
Author: Simon Glass <sjg@chromium.org>
Date:   Fri Dec 28 14:23:10 2018 -0700

    dm: serial: Adjust serial_getinfo() to use proper API

I will send a fix soon.

This series is okay as long as future fix will be applied.

Should I make a fix as patch 1 in the series and resend as v3?

-- 
With Best Regards,
Andy Shevchenko

[U-Boot] [PATCH v2 1/2] x86: edison: Use proper number of serial interface

[Bin Meng]

On Thu, Feb 28, 2019 at 4:12 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The console is actually serial #2. When we would like to enable other ports,
> this would be not okay to mess up with the ordering.
>
> Thus, fix the number of default console interface to be 2.
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/dts/edison.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

applied to u-boot-x86, thanks!

[U-Boot] [PATCH v2 2/2] x86: edison: Add the rest of UARTs present on board

[Bin Meng]

On Thu, Feb 28, 2019 at 4:21 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Thu, Feb 28, 2019 at 4:12 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Intel Edison has three UART ports, i.e.
> >  port 0 - Bluetooth
> >  port 1 - auxiliary, available for general purpose use
> >  port 2 - debugging, usually console output is here
> >
> > Enable all of them for future use.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/dts/edison.dts | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!