All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port
@ 2019-02-19 13:37 Michal Vokáč
  2019-03-01  2:13 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Vokáč @ 2019-02-19 13:37 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Andrew Lunn, Vinod Koul, devicetree, linux-kernel,
	Michal Vokáč

The PHY must add delays to both Tx and Rx clock on the cpu port
to work propperly.

It worked with the rgmii mode before beacause the qca8k driver
(incorrecly) enabled delays in that mode.

Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
This imx6dl-yapp4 platform is currently waiting in linux-next.

Commit 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode"), now
also in linux-next removed the delays from the RGMII mode so the networking
stopped working.

Recently Koul submitted a patch that implements the rgmii-id mode to fix
the issue [1].

As the networking is broken at this moment it does not matter which patch
goes in first. It is not neccessary to wait until the Koul's patch is
applied/merged if that should be the case.

[1] http://patchwork.ozlabs.org/patch/1044505/

 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
index b715ab0fa1ff..091d829f6b05 100644
--- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -125,7 +125,7 @@
 				ethphy0: port@0 {
 					reg = <0>;
 					label = "cpu";
-					phy-mode = "rgmii";
+					phy-mode = "rgmii-id";
 					ethernet = <&fec>;
 
 					fixed-link {
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port
  2019-02-19 13:37 [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port Michal Vokáč
@ 2019-03-01  2:13 ` Shawn Guo
  2019-03-01  6:29   ` Michal Vokáč
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-03-01  2:13 UTC (permalink / raw)
  To: Michal Vokáč
  Cc: Rob Herring, Andrew Lunn, Vinod Koul, devicetree, linux-kernel

On Tue, Feb 19, 2019 at 02:37:00PM +0100, Michal Vokáč wrote:
> The PHY must add delays to both Tx and Rx clock on the cpu port
> to work propperly.
> 
> It worked with the rgmii mode before beacause the qca8k driver
> (incorrecly) enabled delays in that mode.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> ---
> This imx6dl-yapp4 platform is currently waiting in linux-next.
> 
> Commit 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode"), now
> also in linux-next removed the delays from the RGMII mode so the networking
> stopped working.
> 
> Recently Koul submitted a patch that implements the rgmii-id mode to fix
> the issue [1].
> 
> As the networking is broken at this moment it does not matter which patch
> goes in first. It is not neccessary to wait until the Koul's patch is
> applied/merged if that should be the case.
> 
> [1] http://patchwork.ozlabs.org/patch/1044505/

Can we have such useful info in the commit log in some proper form?

Shawn

> 
>  arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index b715ab0fa1ff..091d829f6b05 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -125,7 +125,7 @@
>  				ethphy0: port@0 {
>  					reg = <0>;
>  					label = "cpu";
> -					phy-mode = "rgmii";
> +					phy-mode = "rgmii-id";
>  					ethernet = <&fec>;
>  
>  					fixed-link {
> -- 
> 2.1.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port
  2019-03-01  2:13 ` Shawn Guo
@ 2019-03-01  6:29   ` Michal Vokáč
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Vokáč @ 2019-03-01  6:29 UTC (permalink / raw)
  To: Shawn Guo; +Cc: Rob Herring, Andrew Lunn, Vinod Koul, devicetree, linux-kernel

On 01. 03. 19 3:13, Shawn Guo wrote:
> On Tue, Feb 19, 2019 at 02:37:00PM +0100, Michal Vokáč wrote:
>> The PHY must add delays to both Tx and Rx clock on the cpu port
>> to work propperly.
>>
>> It worked with the rgmii mode before beacause the qca8k driver
>> (incorrecly) enabled delays in that mode.
>>
>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>> ---
>> This imx6dl-yapp4 platform is currently waiting in linux-next.
>>
>> Commit 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode"), now
>> also in linux-next removed the delays from the RGMII mode so the networking
>> stopped working.
>>
>> Recently Koul submitted a patch that implements the rgmii-id mode to fix
>> the issue [1].
>>
>> As the networking is broken at this moment it does not matter which patch
>> goes in first. It is not neccessary to wait until the Koul's patch is
>> applied/merged if that should be the case.
>>
>> [1] http://patchwork.ozlabs.org/patch/1044505/
> 
> Can we have such useful info in the commit log in some proper form?

Sure, I will transplant relevant parts of the message into the commit
log. I just thought that most of this info will be outdated immediately
after applying.

BTW the patch[1] from Vinod is already merged.

Michal

>>
>>   arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> index b715ab0fa1ff..091d829f6b05 100644
>> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> @@ -125,7 +125,7 @@
>>   				ethphy0: port@0 {
>>   					reg = <0>;
>>   					label = "cpu";
>> -					phy-mode = "rgmii";
>> +					phy-mode = "rgmii-id";
>>   					ethernet = <&fec>;
>>   
>>   					fixed-link {
>> -- 
>> 2.1.4
>>


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-01  6:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 13:37 [PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port Michal Vokáč
2019-03-01  2:13 ` Shawn Guo
2019-03-01  6:29   ` Michal Vokáč

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.