All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: linville@tuxdriver.com,
	Nicholas Nunley <nicholas.d.nunley@intel.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v3 6/6] ethtool: fix up dump_coalesce output to match actual option names
Date: Fri, 1 Mar 2019 15:38:01 +0100	[thread overview]
Message-ID: <20190301143801.GL29992@unicorn.suse.cz> (raw)
In-Reply-To: <20190301081532.11771-6-jeffrey.t.kirsher@intel.com>

On Fri, Mar 01, 2019 at 12:15:32AM -0800, Jeff Kirsher wrote:
> From: Nicholas Nunley <nicholas.d.nunley@intel.com>
> 
> When the coalesce settings are printed with --show-coalesce a few of the
> option names lack the pluralization that is present in the man page and
> usage info, but are otherwise identical.
> 
> This inconsistency could lead to some confusion if a user attempts to set
> the coalesce settings by matching the output they see from --show-coalesce,
> so fix this.
> 
> Signed-off-by: Nicholas Nunley <nicholas.d.nunley@intel.com>

Reviewed-by: Michal Kubecek <mkubecek@suse.cz>

  reply	other threads:[~2019-03-01 14:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01  8:15 [PATCH v3 1/6] ethtool: move option parsing related code into function Jeff Kirsher
2019-03-01  8:15 ` [PATCH v3 2/6] ethtool: move cmdline_coalesce out of do_scoalesce Jeff Kirsher
2019-03-01 13:50   ` Michal Kubecek
2019-03-01  8:15 ` [PATCH v3 3/6] ethtool: introduce new ioctl for per-queue settings Jeff Kirsher
2019-03-01 14:18   ` Michal Kubecek
2019-03-01 23:35     ` Nunley, Nicholas D
2019-03-01  8:15 ` [PATCH v3 4/6] ethtool: support per-queue sub command --show-coalesce Jeff Kirsher
2019-03-01 14:26   ` Michal Kubecek
2019-03-01  8:15 ` [PATCH v3 5/6] ethtool: support per-queue sub command --coalesce Jeff Kirsher
2019-03-01 14:28   ` Michal Kubecek
2019-03-01  8:15 ` [PATCH v3 6/6] ethtool: fix up dump_coalesce output to match actual option names Jeff Kirsher
2019-03-01 14:38   ` Michal Kubecek [this message]
2019-03-01 13:42 ` [PATCH v3 1/6] ethtool: move option parsing related code into function Michal Kubecek
2019-03-14 18:37 ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301143801.GL29992@unicorn.suse.cz \
    --to=mkubecek@suse.cz \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicholas.d.nunley@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.