From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: anarsoul@gmail.com, alex_lu@realsil.com.cn Cc: beagleboard@davidjohnsummers.uk, davem@davemloft.net, devicetree@vger.kernel.org, johan.hedberg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, marcel@holtmann.org, mark.rutland@arm.com, maxime.ripard@bootlin.com, netdev@vger.kernel.org, robh@kernel.org, stefan.wahren@i2se.com, wens@csie.org, Martin Blumenstingl <martin.blumenstingl@googlemail.com> Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Date: Fri, 1 Mar 2019 21:15:19 +0100 [thread overview] Message-ID: <20190301201519.21953-1-martin.blumenstingl@googlemail.com> (raw) In-Reply-To: <CA+E=qVdsU7sBkOQUmMprhD-Sdw7TdFnwFdGCv=4iRe++y1AwOg@mail.gmail.com> Hi Vasily, Hi Alex, On 22/02/2019 11:21, Vasily Khoruzhick wrote: > I agree with Rob that we should probably use firmware-name here instead. Have you considered skipping this property for v1 of this series? We can still add that property (as optional one) later on if we really see the need for it. (The btrtl code should already support the case where NULL is passed as "postfix") I checked the public rtl8723bs_bt [0] and rtl8723ds_bt [1] git repos and they each contain only one config blob. The blob from the rtl8723bs_bt repo worked on my two Amlogic boards (data only, sound input/output not tested), even though Amlogic seems to ship different blobs: [2] >> Is there a need to have the board name? > > As far as I understand firmware config depends on board, so I think > it's a good idea to use board name here. I also added Alex Lu from Realtek / Realsil to this email. Alex, I hope that you can help us with the "Bluetooth config" format for the Realtek WiFi and Bluetooth combo chips - mainly the ones which connect to the host using SDIO. This is important for us because the question came up whether we can describe everything that's part of the "config blob" as device-tree properties. If we knew the format we could generate the "config blob" on-the-fly (either by fully generating it, taking a blob - maybe with only the smallest set of config data - as "template" and update values on-the-fly, etc.) Marcel wrote a tool [3] which handles the basic config format. However, we're still missing a lot of details (only 3 offsets are known, "UART_CONFIG" contains 16 bytes but we only know the purpose of 4 of these, ...). I would highly appreciate if you give us enough details so we can extend Marcel's tool to display the human-readable representation of the config blobs from rtl8723bs_bt [0] and rtl8723ds_bt [1]. Vasily, thank you for your effort on this topic so far! If you keep me CC'ed on v2 of your series then I can test it on two of my Amlogic boards (which come with a RTL8723BS). [0] https://github.com/lwfinger/rtl8723bs_bt/tree/09eb91f52a639ec5e4c5c4c98dc2afede046cf20 [1] https://github.com/ayufan-pine64/rtl8723ds_bt/tree/fab21b52250d67857b694f961e1ff8618e678d89/8723D [2] https://github.com/khadas/android_hardware_realtek/tree/bd3b113266c353aafcbf528a0334d28090ff249b/rtkbt/system/etc/firmware [3] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/rtlfw.c?id=261948090e9073514ac4b5f64c8715cf0a71eafa
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: anarsoul@gmail.com, alex_lu@realsil.com.cn Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, johan.hedberg@gmail.com, robh@kernel.org, maxime.ripard@bootlin.com, netdev@vger.kernel.org, marcel@holtmann.org, stefan.wahren@i2se.com, beagleboard@davidjohnsummers.uk, linux-bluetooth@vger.kernel.org, wens@csie.org, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Date: Fri, 1 Mar 2019 21:15:19 +0100 [thread overview] Message-ID: <20190301201519.21953-1-martin.blumenstingl@googlemail.com> (raw) In-Reply-To: <CA+E=qVdsU7sBkOQUmMprhD-Sdw7TdFnwFdGCv=4iRe++y1AwOg@mail.gmail.com> Hi Vasily, Hi Alex, On 22/02/2019 11:21, Vasily Khoruzhick wrote: > I agree with Rob that we should probably use firmware-name here instead. Have you considered skipping this property for v1 of this series? We can still add that property (as optional one) later on if we really see the need for it. (The btrtl code should already support the case where NULL is passed as "postfix") I checked the public rtl8723bs_bt [0] and rtl8723ds_bt [1] git repos and they each contain only one config blob. The blob from the rtl8723bs_bt repo worked on my two Amlogic boards (data only, sound input/output not tested), even though Amlogic seems to ship different blobs: [2] >> Is there a need to have the board name? > > As far as I understand firmware config depends on board, so I think > it's a good idea to use board name here. I also added Alex Lu from Realtek / Realsil to this email. Alex, I hope that you can help us with the "Bluetooth config" format for the Realtek WiFi and Bluetooth combo chips - mainly the ones which connect to the host using SDIO. This is important for us because the question came up whether we can describe everything that's part of the "config blob" as device-tree properties. If we knew the format we could generate the "config blob" on-the-fly (either by fully generating it, taking a blob - maybe with only the smallest set of config data - as "template" and update values on-the-fly, etc.) Marcel wrote a tool [3] which handles the basic config format. However, we're still missing a lot of details (only 3 offsets are known, "UART_CONFIG" contains 16 bytes but we only know the purpose of 4 of these, ...). I would highly appreciate if you give us enough details so we can extend Marcel's tool to display the human-readable representation of the config blobs from rtl8723bs_bt [0] and rtl8723ds_bt [1]. Vasily, thank you for your effort on this topic so far! If you keep me CC'ed on v2 of your series then I can test it on two of my Amlogic boards (which come with a RTL8723BS). [0] https://github.com/lwfinger/rtl8723bs_bt/tree/09eb91f52a639ec5e4c5c4c98dc2afede046cf20 [1] https://github.com/ayufan-pine64/rtl8723ds_bt/tree/fab21b52250d67857b694f961e1ff8618e678d89/8723D [2] https://github.com/khadas/android_hardware_realtek/tree/bd3b113266c353aafcbf528a0334d28090ff249b/rtkbt/system/etc/firmware [3] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/rtlfw.c?id=261948090e9073514ac4b5f64c8715cf0a71eafa _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-01 20:15 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-18 17:02 [PATCH 0/8] Add support for rtl8723bs/rtl8723cs bluetooth Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-18 17:02 ` [PATCH 1/8] Bluetooth: Add new quirk for broken local ext features max_page Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-18 17:02 ` [PATCH 2/8] Bluetooth: hci_h5: Add support for reset GPIO Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-18 17:13 ` Chen-Yu Tsai 2019-01-18 17:13 ` Chen-Yu Tsai 2019-01-18 17:02 ` [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-02-18 21:10 ` Rob Herring 2019-02-18 21:10 ` Rob Herring 2019-02-18 21:24 ` Vasily Khoruzhick 2019-02-18 21:24 ` Vasily Khoruzhick 2019-02-18 22:08 ` Stefan Wahren 2019-02-18 22:08 ` Stefan Wahren 2019-02-18 22:08 ` Stefan Wahren 2019-02-18 22:10 ` Stefan Wahren 2019-02-18 22:10 ` Stefan Wahren 2019-02-18 22:28 ` Vasily Khoruzhick 2019-02-18 22:28 ` Vasily Khoruzhick 2019-02-19 14:17 ` Rob Herring 2019-02-19 14:17 ` Rob Herring 2019-02-19 21:09 ` David Summers 2019-02-19 21:09 ` David Summers 2019-02-19 21:09 ` David Summers 2019-02-20 2:59 ` Chen-Yu Tsai 2019-02-20 2:59 ` Chen-Yu Tsai 2019-02-22 19:14 ` David Summers 2019-02-22 19:14 ` David Summers 2019-02-22 19:21 ` Vasily Khoruzhick 2019-02-22 19:21 ` Vasily Khoruzhick 2019-02-23 20:16 ` David Summers 2019-02-23 20:16 ` David Summers 2019-02-23 20:16 ` David Summers 2019-03-01 20:15 ` Martin Blumenstingl [this message] 2019-03-01 20:15 ` Martin Blumenstingl 2019-03-02 9:28 ` 答复: " 陆朱伟 2019-03-02 9:28 ` 陆朱伟 2019-03-02 9:28 ` 陆朱伟 2019-03-02 16:43 ` Martin Blumenstingl 2019-03-02 16:43 ` Martin Blumenstingl 2019-03-02 16:43 ` Martin Blumenstingl 2019-03-04 5:17 ` 答复: " 陆朱伟 2019-03-04 5:17 ` 陆朱伟 2019-03-04 5:17 ` 陆朱伟 2019-02-19 8:56 ` Stefan Wahren 2019-02-19 8:56 ` Stefan Wahren 2019-02-19 14:14 ` Rob Herring 2019-02-19 14:14 ` Rob Herring 2019-02-19 21:25 ` Vasily Khoruzhick 2019-02-19 21:25 ` Vasily Khoruzhick 2019-06-02 9:33 ` Luca Weiss 2019-06-02 9:33 ` Luca Weiss 2019-01-18 17:02 ` [PATCH 4/8] Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-21 14:44 ` kbuild test robot 2019-01-21 14:44 ` kbuild test robot 2019-01-21 14:44 ` kbuild test robot 2019-01-21 15:09 ` kbuild test robot 2019-01-21 15:09 ` kbuild test robot 2019-01-21 15:09 ` kbuild test robot 2019-01-18 17:02 ` [PATCH 5/8] Bluetooth: btrtl: add support for the RTL8723CS Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-21 14:31 ` kbuild test robot 2019-01-21 14:31 ` kbuild test robot 2019-01-21 14:31 ` kbuild test robot 2019-01-18 17:02 ` [PATCH 6/8] arm64: allwinner: a64: enable Bluetooth On Pinebook Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-18 17:02 ` [PATCH 7/8] DO-NOT-MERGE: arm64: allwinner: a64: enable Bluetooth On Pine64 Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick 2019-01-18 17:02 ` [PATCH 8/8] DO-NOT-MERGE: arm64: allwinner: a64: enable Bluetooth On SoPine baseboard Vasily Khoruzhick 2019-01-18 17:02 ` Vasily Khoruzhick
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190301201519.21953-1-martin.blumenstingl@googlemail.com \ --to=martin.blumenstingl@googlemail.com \ --cc=alex_lu@realsil.com.cn \ --cc=anarsoul@gmail.com \ --cc=beagleboard@davidjohnsummers.uk \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=johan.hedberg@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-bluetooth@vger.kernel.org \ --cc=marcel@holtmann.org \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=netdev@vger.kernel.org \ --cc=robh@kernel.org \ --cc=stefan.wahren@i2se.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.