* [Qemu-devel] [PATCH v5 0/2] CODING_STYLE: trivial update @ 2019-03-01 2:01 Wei Yang 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code Wei Yang 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 2/2] CODING_STYLE: indent example code as all others Wei Yang 0 siblings, 2 replies; 5+ messages in thread From: Wei Yang @ 2019-03-01 2:01 UTC (permalink / raw) To: qemu-devel, qemu-trivial Cc: mjt, imammedo, philmd, eblake, peter.maydell, Wei Yang The first one is suggested by Igor Mammedov to provide rule for multiline code. The second is a trivial fix to make example code all indented with 4 spaces. v5: * mostly address function variants v4: * one exception case for function v3: * fix typo in both changelog and example v2: * adjust Patch 1 as suggested by Eric Wei Yang (2): CODING_STYLE: specify the indent rule for multiline code CODING_STYLE: indent example code as all others CODING_STYLE | 47 +++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 43 insertions(+), 4 deletions(-) -- 2.19.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code 2019-03-01 2:01 [Qemu-devel] [PATCH v5 0/2] CODING_STYLE: trivial update Wei Yang @ 2019-03-01 2:01 ` Wei Yang 2019-03-01 9:55 ` Stefano Garzarella 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 2/2] CODING_STYLE: indent example code as all others Wei Yang 1 sibling, 1 reply; 5+ messages in thread From: Wei Yang @ 2019-03-01 2:01 UTC (permalink / raw) To: qemu-devel, qemu-trivial Cc: mjt, imammedo, philmd, eblake, peter.maydell, Wei Yang We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Suggested-by: Igor Mammedov <imammedo@redhat.com> --- v5: * different rules -> various styles * describe function variants separately * take struct out v4: * widths -> width * add an exception example for function v3: * misleading -> mislead * add comma after arg2 in example v2: * rephrase changelog suggested by Eric Blake - remove one redundant line - fix some awkward grammar - add { ; at the end of example --- CODING_STYLE | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index ec075dedc4..e175e6ea9a 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -29,6 +29,45 @@ Spaces of course are superior to tabs because: Do not leave whitespace dangling off the ends of lines. +1.1 Multiline Indent + +There are several places where indent is necessary: + + - if/else + - while/for + - function definition & call + +When breaking up a long line to fit within line width, we need a proper indent +for the following lines. + +In case of if/else, while/for, align the secondary lines just after the +opening parenthesis of the first. + +For example: + + if (a == 1 && + b == 2) { + + while (a == 1 && + b == 2) { + +In case of function, there are several variants: + + * 4 spaces indent from the beginning + * align the secondary lines just after the opening parenthesis of the + first + +For example: + + do_something(x, y, + z); + + do_something(x, y, + z); + + do_something(x, do_another(y, + z); + 2. Line width Lines should be 80 characters; try not to make them longer. -- 2.19.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code Wei Yang @ 2019-03-01 9:55 ` Stefano Garzarella 2019-03-02 11:13 ` Wei Yang 0 siblings, 1 reply; 5+ messages in thread From: Stefano Garzarella @ 2019-03-01 9:55 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-devel, qemu-trivial, peter.maydell, philmd, mjt, imammedo On Fri, Mar 01, 2019 at 10:01:46AM +0800, Wei Yang wrote: > We didn't specify the indent rule for multiline code here, which may > mislead users. And in current code, the code use various styles. > > Add this rule in CODING_STYLE to make sure this is clear to every one. > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> > Suggested-by: Igor Mammedov <imammedo@redhat.com> > > --- > v5: > * different rules -> various styles > * describe function variants separately > * take struct out > v4: > * widths -> width > * add an exception example for function > v3: > * misleading -> mislead > * add comma after arg2 in example > v2: > * rephrase changelog suggested by Eric Blake > - remove one redundant line > - fix some awkward grammar > - add { ; at the end of example > --- > CODING_STYLE | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/CODING_STYLE b/CODING_STYLE > index ec075dedc4..e175e6ea9a 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -29,6 +29,45 @@ Spaces of course are superior to tabs because: > > Do not leave whitespace dangling off the ends of lines. > > +1.1 Multiline Indent > + > +There are several places where indent is necessary: > + > + - if/else > + - while/for > + - function definition & call > + > +When breaking up a long line to fit within line width, we need a proper indent > +for the following lines. > + > +In case of if/else, while/for, align the secondary lines just after the > +opening parenthesis of the first. > + > +For example: > + > + if (a == 1 && > + b == 2) { > + > + while (a == 1 && > + b == 2) { > + > +In case of function, there are several variants: > + > + * 4 spaces indent from the beginning > + * align the secondary lines just after the opening parenthesis of the > + first > + > +For example: > + > + do_something(x, y, > + z); > + > + do_something(x, y, > + z); > + > + do_something(x, do_another(y, > + z); Should we close another parenthesis after the "z"? The rest LGTM! Thanks, Stefano ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code 2019-03-01 9:55 ` Stefano Garzarella @ 2019-03-02 11:13 ` Wei Yang 0 siblings, 0 replies; 5+ messages in thread From: Wei Yang @ 2019-03-02 11:13 UTC (permalink / raw) To: Stefano Garzarella Cc: Wei Yang, peter.maydell, qemu-trivial, mjt, qemu-devel, imammedo, philmd On Fri, Mar 01, 2019 at 10:55:22AM +0100, Stefano Garzarella wrote: >On Fri, Mar 01, 2019 at 10:01:46AM +0800, Wei Yang wrote: >> We didn't specify the indent rule for multiline code here, which may >> mislead users. And in current code, the code use various styles. >> >> Add this rule in CODING_STYLE to make sure this is clear to every one. >> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> >> Suggested-by: Igor Mammedov <imammedo@redhat.com> >> >> --- >> v5: >> * different rules -> various styles >> * describe function variants separately >> * take struct out >> v4: >> * widths -> width >> * add an exception example for function >> v3: >> * misleading -> mislead >> * add comma after arg2 in example >> v2: >> * rephrase changelog suggested by Eric Blake >> - remove one redundant line >> - fix some awkward grammar >> - add { ; at the end of example >> --- >> CODING_STYLE | 39 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/CODING_STYLE b/CODING_STYLE >> index ec075dedc4..e175e6ea9a 100644 >> --- a/CODING_STYLE >> +++ b/CODING_STYLE >> @@ -29,6 +29,45 @@ Spaces of course are superior to tabs because: >> >> Do not leave whitespace dangling off the ends of lines. >> >> +1.1 Multiline Indent >> + >> +There are several places where indent is necessary: >> + >> + - if/else >> + - while/for >> + - function definition & call >> + >> +When breaking up a long line to fit within line width, we need a proper indent >> +for the following lines. >> + >> +In case of if/else, while/for, align the secondary lines just after the >> +opening parenthesis of the first. >> + >> +For example: >> + >> + if (a == 1 && >> + b == 2) { >> + >> + while (a == 1 && >> + b == 2) { >> + >> +In case of function, there are several variants: >> + >> + * 4 spaces indent from the beginning >> + * align the secondary lines just after the opening parenthesis of the >> + first >> + >> +For example: >> + >> + do_something(x, y, >> + z); >> + >> + do_something(x, y, >> + z); >> + >> + do_something(x, do_another(y, >> + z); > >Should we close another parenthesis after the "z"? > :-( >The rest LGTM! > >Thanks, >Stefano -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH v5 2/2] CODING_STYLE: indent example code as all others 2019-03-01 2:01 [Qemu-devel] [PATCH v5 0/2] CODING_STYLE: trivial update Wei Yang 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code Wei Yang @ 2019-03-01 2:01 ` Wei Yang 1 sibling, 0 replies; 5+ messages in thread From: Wei Yang @ 2019-03-01 2:01 UTC (permalink / raw) To: qemu-devel, qemu-trivial Cc: mjt, imammedo, philmd, eblake, peter.maydell, Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index e175e6ea9a..465acf8bee 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=', -- 2.19.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-02 11:13 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-01 2:01 [Qemu-devel] [PATCH v5 0/2] CODING_STYLE: trivial update Wei Yang 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 1/2] CODING_STYLE: specify the indent rule for multiline code Wei Yang 2019-03-01 9:55 ` Stefano Garzarella 2019-03-02 11:13 ` Wei Yang 2019-03-01 2:01 ` [Qemu-devel] [PATCH v5 2/2] CODING_STYLE: indent example code as all others Wei Yang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.