* [PATCH v2] staging: gdm724x: Add brackets around parameter
@ 2019-03-04 16:58 Nishka Dasgupta
2019-03-05 7:41 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Nishka Dasgupta @ 2019-03-04 16:58 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Nishka Dasgupta
Add brackets around macro parameter to avoid confusion. Issue detected
by Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
Changes in v2:
- Driver name added to subject line.
drivers/staging/gdm724x/netlink_k.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c
index 92440c3f055b..36d88f49c922 100644
--- a/drivers/staging/gdm724x/netlink_k.c
+++ b/drivers/staging/gdm724x/netlink_k.c
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
#define ND_NLMSG_SPACE(len) (NLMSG_SPACE(len) + ND_IFINDEX_LEN)
#define ND_NLMSG_DATA(nlh) ((void *)((char *)NLMSG_DATA(nlh) + \
ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len) ((len) + ND_IFINDEX_LEN)
+#define ND_NLMSG_R_LEN(nlh) ((nlh)->nlmsg_len - ND_IFINDEX_LEN)
#define ND_NLMSG_IFIDX(nlh) NLMSG_DATA(nlh)
#define ND_MAX_MSG_LEN (1024 * 32)
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: gdm724x: Add brackets around parameter
2019-03-04 16:58 [PATCH v2] staging: gdm724x: Add brackets around parameter Nishka Dasgupta
@ 2019-03-05 7:41 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-03-05 7:41 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: outreachy-kernel
On Mon, Mar 04, 2019 at 10:28:53PM +0530, Nishka Dasgupta wrote:
> Add brackets around macro parameter to avoid confusion. Issue detected
> by Checkpatch.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
> Changes in v2:
> - Driver name added to subject line.
>
> drivers/staging/gdm724x/netlink_k.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c
> index 92440c3f055b..36d88f49c922 100644
> --- a/drivers/staging/gdm724x/netlink_k.c
> +++ b/drivers/staging/gdm724x/netlink_k.c
> @@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
> #define ND_NLMSG_SPACE(len) (NLMSG_SPACE(len) + ND_IFINDEX_LEN)
> #define ND_NLMSG_DATA(nlh) ((void *)((char *)NLMSG_DATA(nlh) + \
> ND_IFINDEX_LEN))
> -#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN)
> -#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN)
> +#define ND_NLMSG_S_LEN(len) ((len) + ND_IFINDEX_LEN)
> +#define ND_NLMSG_R_LEN(nlh) ((nlh)->nlmsg_len - ND_IFINDEX_LEN)
This change is not needed.
Also, you sent two copies of this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: gdm724x: Add brackets around parameter
@ 2019-03-04 16:57 Nishka Dasgupta
0 siblings, 0 replies; 3+ messages in thread
From: Nishka Dasgupta @ 2019-03-04 16:57 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Nishka Dasgupta
Add brackets around macro parameter to avoid confusion. Issue detected
by Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
Changes in v2:
- Add driver name to subject line.
drivers/staging/gdm724x/netlink_k.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c
index 92440c3f055b..36d88f49c922 100644
--- a/drivers/staging/gdm724x/netlink_k.c
+++ b/drivers/staging/gdm724x/netlink_k.c
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
#define ND_NLMSG_SPACE(len) (NLMSG_SPACE(len) + ND_IFINDEX_LEN)
#define ND_NLMSG_DATA(nlh) ((void *)((char *)NLMSG_DATA(nlh) + \
ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len) ((len) + ND_IFINDEX_LEN)
+#define ND_NLMSG_R_LEN(nlh) ((nlh)->nlmsg_len - ND_IFINDEX_LEN)
#define ND_NLMSG_IFIDX(nlh) NLMSG_DATA(nlh)
#define ND_MAX_MSG_LEN (1024 * 32)
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-05 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 16:58 [PATCH v2] staging: gdm724x: Add brackets around parameter Nishka Dasgupta
2019-03-05 7:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-03-04 16:57 Nishka Dasgupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.