Re: [Outreachy kernel] [PATCH] Staging: vt6655: Fix line over 80 characters

From: Madhumthia Prabakaran <madhumithabiw@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: vt6655: Fix line over 80 characters
Date: Mon, 4 Mar 2019 11:23:46 -0600	[thread overview]
Message-ID: <20190304172344.GA22591@madhuleo> (raw)
In-Reply-To: <alpine.DEB.2.21.1903040842080.2559@hadrien>

On Mon, Mar 04, 2019 at 08:42:54AM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 3 Mar 2019, Madhumitha Prabakaran wrote:
> 
> > Fix the warning issued by checkpatch.pl
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> > ---
> >  drivers/staging/vt6655/card.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
> > index d71022aa3f86..6bbbbe1314d5 100644
> > --- a/drivers/staging/vt6655/card.h
> > +++ b/drivers/staging/vt6655/card.h
> > @@ -44,7 +44,8 @@ struct vnt_private;
> >  void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
> >  void CARDvUpdateBasicTopRate(struct vnt_private *priv);
> >  bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
> > -void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
> > +void CARDvSetLoopbackMode(struct vnt_private *priv,
> > +			  unsigned short wLoopbackMode);
> 
> I have the impression that this function is actually never used.  Maybe
> you can try to get rid of it.
> 
> julia
> 
> >  bool CARDbSoftwareReset(struct vnt_private *priv);
> >  void CARDvSetFirstNextTBTT(struct vnt_private *priv,
> >  			   unsigned short wBeaconInterval);
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304011949.17148-1-madhumithabiw%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903040842080.2559%40hadrien.
> For more options, visit https://groups.google.com/d/optout.

None of the function declarations in card.h is used with itself. But the CARDvSetLoopbackMode function is used in card.c. Whether we can remove it, considering the fact that it is used in card.c or not. I'm not sure regarding it. 

thanks,
madhumitha