From: Julia Lawall <julia.lawall@lip6.fr>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: vt6655: Fix line over 80 characters
Date: Mon, 4 Mar 2019 08:42:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1903040842080.2559@hadrien> (raw)
In-Reply-To: <20190304011949.17148-1-madhumithabiw@gmail.com>
On Sun, 3 Mar 2019, Madhumitha Prabakaran wrote:
> Fix the warning issued by checkpatch.pl
> WARNING: line over 80 characters
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/vt6655/card.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
> index d71022aa3f86..6bbbbe1314d5 100644
> --- a/drivers/staging/vt6655/card.h
> +++ b/drivers/staging/vt6655/card.h
> @@ -44,7 +44,8 @@ struct vnt_private;
> void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
> void CARDvUpdateBasicTopRate(struct vnt_private *priv);
> bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
> -void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
> +void CARDvSetLoopbackMode(struct vnt_private *priv,
> + unsigned short wLoopbackMode);
I have the impression that this function is actually never used. Maybe
you can try to get rid of it.
julia
> bool CARDbSoftwareReset(struct vnt_private *priv);
> void CARDvSetFirstNextTBTT(struct vnt_private *priv,
> unsigned short wBeaconInterval);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304011949.17148-1-madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2019-03-04 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 1:19 [PATCH] Staging: vt6655: Fix line over 80 characters Madhumitha Prabakaran
2019-03-04 7:42 ` Julia Lawall [this message]
2019-03-04 16:02 ` [Outreachy kernel] " Madhumthia Prabakaran
2019-03-04 17:23 ` Madhumthia Prabakaran
2019-03-04 7:45 ` Greg KH
2019-03-04 16:00 ` Madhumthia Prabakaran
2019-03-04 16:27 ` [Outreachy kernel] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1903040842080.2559@hadrien \
--to=julia.lawall@lip6.fr \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=madhumithabiw@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.