* [PATCH V3 1/2] init i2c already in it930x_frontend_attach
@ 2019-03-05 18:37 Jose Alberto Reguero
2019-03-05 20:00 ` Andreas Kemnade
0 siblings, 1 reply; 2+ messages in thread
From: Jose Alberto Reguero @ 2019-03-05 18:37 UTC (permalink / raw)
To: Linux media, Sean Young, Antti Palosaari, Andreas Kemnade,
jose.alberto.reguero
i2c bus is already needed when the frontend is probed, so init it already in it930x_frontend_attach.That prevents errors like
si2168: probe of 6-0067 failed with error -5
Andreas, can I have your Signed-off-by?
From: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Jose Alberto Reguero <jose.alberto.reguero@gmail.com>
diff -upr linux/drivers/media/usb/dvb-usb-v2/af9035.c linux.new/drivers/media/usb/dvb-usb-v2/af9035.c
--- linux/drivers/media/usb/dvb-usb-v2/af9035.c 2018-09-12 07:40:12.000000000 +0200
+++ linux.new/drivers/media/usb/dvb-usb-v2/af9035.c 2019-02-20 16:45:17.467869437 +0100
@@ -1218,6 +1218,48 @@ static int it930x_frontend_attach(struct
dev_dbg(&intf->dev, "adap->id=%d\n", adap->id);
+ /* I2C master bus 2 clock speed 300k */
+ ret = af9035_wr_reg(d, 0x00f6a7, 0x07);
+ if (ret < 0)
+ goto err;
+
+ /* I2C master bus 1,3 clock speed 300k */
+ ret = af9035_wr_reg(d, 0x00f103, 0x07);
+ if (ret < 0)
+ goto err;
+
+ /* set gpio11 low */
+ ret = af9035_wr_reg_mask(d, 0xd8d4, 0x01, 0x01);
+ if (ret < 0)
+ goto err;
+
+ ret = af9035_wr_reg_mask(d, 0xd8d5, 0x01, 0x01);
+ if (ret < 0)
+ goto err;
+
+ ret = af9035_wr_reg_mask(d, 0xd8d3, 0x01, 0x01);
+ if (ret < 0)
+ goto err;
+
+ /* Tuner enable using gpiot2_en, gpiot2_on and gpiot2_o (reset) */
+ ret = af9035_wr_reg_mask(d, 0xd8b8, 0x01, 0x01);
+ if (ret < 0)
+ goto err;
+
+ ret = af9035_wr_reg_mask(d, 0xd8b9, 0x01, 0x01);
+ if (ret < 0)
+ goto err;
+
+ ret = af9035_wr_reg_mask(d, 0xd8b7, 0x00, 0x01);
+ if (ret < 0)
+ goto err;
+
+ msleep(200);
+
+ ret = af9035_wr_reg_mask(d, 0xd8b7, 0x01, 0x01);
+ if (ret < 0)
+ goto err;
+
memset(&si2168_config, 0, sizeof(si2168_config));
si2168_config.i2c_adapter = &adapter;
si2168_config.fe = &adap->fe[0];
@@ -1575,48 +1617,6 @@ static int it930x_tuner_attach(struct dv
dev_dbg(&intf->dev, "adap->id=%d\n", adap->id);
- /* I2C master bus 2 clock speed 300k */
- ret = af9035_wr_reg(d, 0x00f6a7, 0x07);
- if (ret < 0)
- goto err;
-
- /* I2C master bus 1,3 clock speed 300k */
- ret = af9035_wr_reg(d, 0x00f103, 0x07);
- if (ret < 0)
- goto err;
-
- /* set gpio11 low */
- ret = af9035_wr_reg_mask(d, 0xd8d4, 0x01, 0x01);
- if (ret < 0)
- goto err;
-
- ret = af9035_wr_reg_mask(d, 0xd8d5, 0x01, 0x01);
- if (ret < 0)
- goto err;
-
- ret = af9035_wr_reg_mask(d, 0xd8d3, 0x01, 0x01);
- if (ret < 0)
- goto err;
-
- /* Tuner enable using gpiot2_en, gpiot2_on and gpiot2_o (reset) */
- ret = af9035_wr_reg_mask(d, 0xd8b8, 0x01, 0x01);
- if (ret < 0)
- goto err;
-
- ret = af9035_wr_reg_mask(d, 0xd8b9, 0x01, 0x01);
- if (ret < 0)
- goto err;
-
- ret = af9035_wr_reg_mask(d, 0xd8b7, 0x00, 0x01);
- if (ret < 0)
- goto err;
-
- msleep(200);
-
- ret = af9035_wr_reg_mask(d, 0xd8b7, 0x01, 0x01);
- if (ret < 0)
- goto err;
-
memset(&si2157_config, 0, sizeof(si2157_config));
si2157_config.fe = adap->fe[0];
si2157_config.if_port = 1;
--
Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V3 1/2] init i2c already in it930x_frontend_attach
2019-03-05 18:37 [PATCH V3 1/2] init i2c already in it930x_frontend_attach Jose Alberto Reguero
@ 2019-03-05 20:00 ` Andreas Kemnade
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Kemnade @ 2019-03-05 20:00 UTC (permalink / raw)
To: Jose Alberto Reguero
Cc: Linux media, Sean Young, Antti Palosaari, jose.alberto.reguero
[-- Attachment #1: Type: text/plain, Size: 3432 bytes --]
Hi Jose,
On Tue, 05 Mar 2019 19:37:25 +0100
Jose Alberto Reguero <jareguero@telefonica.net> wrote:
> i2c bus is already needed when the frontend is probed, so init it already in it930x_frontend_attach.That prevents errors like
> si2168: probe of 6-0067 failed with error -5
>
> Andreas, can I have your Signed-off-by?
>
ok, it was already there, but again:
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>
> From: Andreas Kemnade <andreas@kemnade.info>
> Signed-off-by: Jose Alberto Reguero <jose.alberto.reguero@gmail.com>
>
> diff -upr linux/drivers/media/usb/dvb-usb-v2/af9035.c linux.new/drivers/media/usb/dvb-usb-v2/af9035.c
> --- linux/drivers/media/usb/dvb-usb-v2/af9035.c 2018-09-12 07:40:12.000000000 +0200
> +++ linux.new/drivers/media/usb/dvb-usb-v2/af9035.c 2019-02-20 16:45:17.467869437 +0100
> @@ -1218,6 +1218,48 @@ static int it930x_frontend_attach(struct
>
> dev_dbg(&intf->dev, "adap->id=%d\n", adap->id);
>
> + /* I2C master bus 2 clock speed 300k */
> + ret = af9035_wr_reg(d, 0x00f6a7, 0x07);
> + if (ret < 0)
> + goto err;
> +
> + /* I2C master bus 1,3 clock speed 300k */
> + ret = af9035_wr_reg(d, 0x00f103, 0x07);
> + if (ret < 0)
> + goto err;
> +
> + /* set gpio11 low */
> + ret = af9035_wr_reg_mask(d, 0xd8d4, 0x01, 0x01);
> + if (ret < 0)
> + goto err;
> +
> + ret = af9035_wr_reg_mask(d, 0xd8d5, 0x01, 0x01);
> + if (ret < 0)
> + goto err;
> +
> + ret = af9035_wr_reg_mask(d, 0xd8d3, 0x01, 0x01);
> + if (ret < 0)
> + goto err;
> +
> + /* Tuner enable using gpiot2_en, gpiot2_on and gpiot2_o (reset) */
> + ret = af9035_wr_reg_mask(d, 0xd8b8, 0x01, 0x01);
> + if (ret < 0)
> + goto err;
> +
> + ret = af9035_wr_reg_mask(d, 0xd8b9, 0x01, 0x01);
> + if (ret < 0)
> + goto err;
> +
> + ret = af9035_wr_reg_mask(d, 0xd8b7, 0x00, 0x01);
> + if (ret < 0)
> + goto err;
> +
> + msleep(200);
> +
> + ret = af9035_wr_reg_mask(d, 0xd8b7, 0x01, 0x01);
> + if (ret < 0)
> + goto err;
> +
> memset(&si2168_config, 0, sizeof(si2168_config));
> si2168_config.i2c_adapter = &adapter;
> si2168_config.fe = &adap->fe[0];
> @@ -1575,48 +1617,6 @@ static int it930x_tuner_attach(struct dv
>
> dev_dbg(&intf->dev, "adap->id=%d\n", adap->id);
>
> - /* I2C master bus 2 clock speed 300k */
> - ret = af9035_wr_reg(d, 0x00f6a7, 0x07);
> - if (ret < 0)
> - goto err;
> -
> - /* I2C master bus 1,3 clock speed 300k */
> - ret = af9035_wr_reg(d, 0x00f103, 0x07);
> - if (ret < 0)
> - goto err;
> -
> - /* set gpio11 low */
> - ret = af9035_wr_reg_mask(d, 0xd8d4, 0x01, 0x01);
> - if (ret < 0)
> - goto err;
> -
> - ret = af9035_wr_reg_mask(d, 0xd8d5, 0x01, 0x01);
> - if (ret < 0)
> - goto err;
> -
> - ret = af9035_wr_reg_mask(d, 0xd8d3, 0x01, 0x01);
> - if (ret < 0)
> - goto err;
> -
> - /* Tuner enable using gpiot2_en, gpiot2_on and gpiot2_o (reset) */
> - ret = af9035_wr_reg_mask(d, 0xd8b8, 0x01, 0x01);
> - if (ret < 0)
> - goto err;
> -
> - ret = af9035_wr_reg_mask(d, 0xd8b9, 0x01, 0x01);
> - if (ret < 0)
> - goto err;
> -
> - ret = af9035_wr_reg_mask(d, 0xd8b7, 0x00, 0x01);
> - if (ret < 0)
> - goto err;
> -
> - msleep(200);
> -
> - ret = af9035_wr_reg_mask(d, 0xd8b7, 0x01, 0x01);
> - if (ret < 0)
> - goto err;
> -
> memset(&si2157_config, 0, sizeof(si2157_config));
> si2157_config.fe = adap->fe[0];
> si2157_config.if_port = 1;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-05 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 18:37 [PATCH V3 1/2] init i2c already in it930x_frontend_attach Jose Alberto Reguero
2019-03-05 20:00 ` Andreas Kemnade
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.