* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
@ 2019-03-07 2:26 ` Patchwork
2019-03-07 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-03-07 2:26 UTC (permalink / raw)
To: Nischala Yelchuri; +Cc: igt-dev
== Series Details ==
Series: tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
URL : https://patchwork.freedesktop.org/series/57673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5713 -> IGTPW_2562
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57673/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2562 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] +106
* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: SKIP [fdo#109271] -> PASS
- fi-bsw-kefka: SKIP [fdo#109271] -> PASS
* igt@i915_pm_rpm@basic-rte:
- fi-byt-j1900: FAIL [fdo#108800] -> PASS
- fi-bsw-kefka: FAIL [fdo#108800] -> PASS
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: WARN [fdo#109380] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: SKIP [fdo#109271] -> PASS +33
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: FAIL [fdo#104008] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u3: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569]
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
Participating hosts (44 -> 40)
------------------------------
Additional (1): fi-gdg-551
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-r
Build changes
-------------
* IGT: IGT_4875 -> IGTPW_2562
CI_DRM_5713: 29a41cf5dd10ee68873c16b67d6212b3bd470906 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2562: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2562/
IGT_4875: 91908d36d0d5c90eea86e29736d2748d5ec55335 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2562/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
2019-03-07 2:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-07 3:47 ` Patchwork
2019-03-07 15:32 ` [igt-dev] [PATCH] " Summers, Stuart
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-03-07 3:47 UTC (permalink / raw)
To: Nischala Yelchuri; +Cc: igt-dev
== Series Details ==
Series: tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
URL : https://patchwork.freedesktop.org/series/57673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5713_full -> IGTPW_2562_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57673/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2562_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vecs0-none:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +22
* igt@gem_ctx_param@invalid-param-get:
- shard-glk: NOTRUN -> FAIL [fdo#109559]
* igt@gem_exec_schedule@fifo-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +105
* igt@gem_pwrite@huge-gtt-forwards:
- shard-kbl: NOTRUN -> SKIP [fdo#109271]
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: PASS -> FAIL [fdo#109660]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_busy@extended-modeset-hang-newfb-render-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232] +2
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-apl: NOTRUN -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> FAIL [fdo#109350]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-snb: PASS -> DMESG-WARN [fdo#102365]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +18
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
- shard-glk: PASS -> FAIL [fdo#108948] +1
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +7
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-glk: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-e:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-apl: NOTRUN -> FAIL [fdo#103166] +1
* igt@kms_vblank@pipe-c-wait-busy:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +9
* igt@prime_nv_pcopy@test3_5:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +45
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] -> PASS
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +5
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4875 -> IGTPW_2562
* Piglit: piglit_4509 -> None
CI_DRM_5713: 29a41cf5dd10ee68873c16b67d6212b3bd470906 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2562: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2562/
IGT_4875: 91908d36d0d5c90eea86e29736d2748d5ec55335 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2562/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
2019-03-07 2:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-07 3:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-07 15:32 ` Summers, Stuart
2019-03-13 20:16 ` Nischala Yelchuri
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Summers, Stuart @ 2019-03-07 15:32 UTC (permalink / raw)
To: igt-dev, Yelchuri, Nischala; +Cc: Lankhorst, Maarten
[-- Attachment #1.1: Type: text/plain, Size: 1291 bytes --]
On Wed, 2019-03-06 at 18:44 -0800, Nischala Yelchuri wrote:
> For the modeset case, the vblank counter can increment by more than
> 1.
Per my comment below, it would be great to have a little more detail
about why this is needed in the commit message.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
> Signed-off-by: Nischala Yelchuri <nischala.yelchuri@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105454
> ---
> tests/kms_cursor_legacy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index d6987eea..8652047f 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -978,7 +978,7 @@ static void
> two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
> if (!modeset)
> igt_assert_eq(vbl.sequence, vblank_start + 1);
>
> - if (vblank_start && vbl.sequence == vblank_start + 1)
> + if (vblank_start && vbl.sequence >= vblank_start + 1)
Great find, but as we discussed in person, it would be interesting to
know why this can be incremented by more than once per modeset. Is this
expected?
Thanks,
Stuart
> vblank_matches = true;
>
> /* Do not requeue on the last 2 events. */
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread* [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
` (2 preceding siblings ...)
2019-03-07 15:32 ` [igt-dev] [PATCH] " Summers, Stuart
@ 2019-03-13 20:16 ` Nischala Yelchuri
2019-03-13 20:41 ` Chris Wilson
2019-03-13 20:30 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2) Patchwork
2019-03-14 3:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 1 reply; 10+ messages in thread
From: Nischala Yelchuri @ 2019-03-13 20:16 UTC (permalink / raw)
To: igt-dev; +Cc: Maarten Lankhorst
For the !modeset case, after a pageflip is performed on both crtc's,
vblank counter is advanced by 1 when compared to its original value.
For the modeset case, when pageflips and modesets are interleaved,
vblank counter does not always advance by 1 as nonblocking modeset
could fail, in which case we do not need vblank_matches.
v2: Remove the assert statement instead of changing the condition
Cc: Maarten Lankhorst <maarten.lankhorst@intel.com>
Signed-off-by: Nischala Yelchuri <nischala.yelchuri@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105454
---
tests/kms_cursor_legacy.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index d6987eea..9febf6e9 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -859,7 +859,7 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
enum pipe pipe = find_connected_pipe(display, false);
enum pipe pipe2 = find_connected_pipe(display, true);
igt_output_t *output, *output2;
- bool vblank_matches, enabled = false;
+ bool enabled = false;
volatile unsigned long *shared;
unsigned flags = 0, vblank_start;
struct drm_event_vblank vbl;
@@ -963,7 +963,6 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
flip_nonblocking(display, pipe2, atomic, &fb2_info, (void*)(ptrdiff_t)vblank_start);
}
- vblank_matches = false;
while (nloops) {
shared[1] = nloops & 1;
@@ -978,9 +977,6 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
if (!modeset)
igt_assert_eq(vbl.sequence, vblank_start + 1);
- if (vblank_start && vbl.sequence == vblank_start + 1)
- vblank_matches = true;
-
/* Do not requeue on the last 2 events. */
if (nloops <= 2) {
nloops--;
@@ -1013,8 +1009,6 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
}
}
- igt_assert_f(vblank_matches, "During modeset at least 1 page flip needs to match!\n");
-
done:
shared[0] = 1;
igt_waitchildren();
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-13 20:16 ` Nischala Yelchuri
@ 2019-03-13 20:41 ` Chris Wilson
2019-03-20 15:44 ` Maarten Lankhorst
0 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2019-03-13 20:41 UTC (permalink / raw)
To: Nischala Yelchuri, igt-dev; +Cc: Maarten Lankhorst
Quoting Nischala Yelchuri (2019-03-13 20:16:35)
> For the !modeset case, after a pageflip is performed on both crtc's,
> vblank counter is advanced by 1 when compared to its original value.
>
> For the modeset case, when pageflips and modesets are interleaved,
> vblank counter does not always advance by 1 as nonblocking modeset
> could fail, in which case we do not need vblank_matches.
Having acknowledged the bug, try fixing it.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-13 20:41 ` Chris Wilson
@ 2019-03-20 15:44 ` Maarten Lankhorst
2019-03-20 15:50 ` Chris Wilson
0 siblings, 1 reply; 10+ messages in thread
From: Maarten Lankhorst @ 2019-03-20 15:44 UTC (permalink / raw)
To: Chris Wilson, Nischala Yelchuri, igt-dev; +Cc: Maarten Lankhorst
Op 13-03-2019 om 21:41 schreef Chris Wilson:
> Quoting Nischala Yelchuri (2019-03-13 20:16:35)
>> For the !modeset case, after a pageflip is performed on both crtc's,
>> vblank counter is advanced by 1 when compared to its original value.
>>
>> For the modeset case, when pageflips and modesets are interleaved,
>> vblank counter does not always advance by 1 as nonblocking modeset
>> could fail, in which case we do not need vblank_matches.
> Having acknowledged the bug, try fixing it.
> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
Hey,
Not sure that's possible. We need access to all crtc_state's when reallocating ddb, and this means a pageflip on the first crtc is stalled while doing a modeset on another.
The page flip will be blocked on the nonblocking modeset to complete.
~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch
2019-03-20 15:44 ` Maarten Lankhorst
@ 2019-03-20 15:50 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-03-20 15:50 UTC (permalink / raw)
To: Maarten Lankhorst, Nischala Yelchuri, igt-dev; +Cc: Maarten Lankhorst
Quoting Maarten Lankhorst (2019-03-20 15:44:36)
> Op 13-03-2019 om 21:41 schreef Chris Wilson:
> > Quoting Nischala Yelchuri (2019-03-13 20:16:35)
> >> For the !modeset case, after a pageflip is performed on both crtc's,
> >> vblank counter is advanced by 1 when compared to its original value.
> >>
> >> For the modeset case, when pageflips and modesets are interleaved,
> >> vblank counter does not always advance by 1 as nonblocking modeset
> >> could fail, in which case we do not need vblank_matches.
> > Having acknowledged the bug, try fixing it.
> > -Chris
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> Hey,
>
> Not sure that's possible. We need access to all crtc_state's when reallocating ddb, and this means a pageflip on the first crtc is stalled while doing a modeset on another.
>
> The page flip will be blocked on the nonblocking modeset to complete.
And it should still only take a vblank... Right? (That is what the test
is complaining about that it takes more than a vblank to update iirc.)
But I'll leave it in your hands if you think the test is too demanding,
you came up with it after all :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2)
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
` (3 preceding siblings ...)
2019-03-13 20:16 ` Nischala Yelchuri
@ 2019-03-13 20:30 ` Patchwork
2019-03-14 3:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-03-13 20:30 UTC (permalink / raw)
To: Nischala Yelchuri; +Cc: igt-dev
== Series Details ==
Series: tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2)
URL : https://patchwork.freedesktop.org/series/57673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5740 -> IGTPW_2610
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57673/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2610 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +55
* igt@gem_ctx_create@basic-files:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] +106
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@gem_exec_store@basic-bsd2:
- fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +41
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#107362]
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: DMESG-WARN [fdo#105128] / [fdo#107139] -> PASS
* igt@i915_module_load@reload:
- fi-ilk-650: DMESG-WARN [fdo#106387] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#109779]: https://bugs.freedesktop.org/show_bug.cgi?id=109779
[fdo#110028]: https://bugs.freedesktop.org/show_bug.cgi?id=110028
Participating hosts (39 -> 38)
------------------------------
Additional (6): fi-byt-clapper fi-hsw-4770 fi-gdg-551 fi-pnv-d510 fi-icl-y fi-bsw-kefka
Missing (7): fi-ilk-m540 fi-bxt-dsi fi-bsw-n3050 fi-hsw-4200u fi-icl-u2 fi-snb-2520m fi-bdw-samus
Build changes
-------------
* IGT: IGT_4884 -> IGTPW_2610
CI_DRM_5740: a9decdcc27ca0e8dbdb538cf58e3840274110c17 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2610: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2610/
IGT_4884: c46051337b972f8b5a302afb6f603df06fea527d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2610/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2)
2019-03-07 2:44 [igt-dev] [PATCH] tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch Nischala Yelchuri
` (4 preceding siblings ...)
2019-03-13 20:30 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2) Patchwork
@ 2019-03-14 3:13 ` Patchwork
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-03-14 3:13 UTC (permalink / raw)
To: Nischala Yelchuri; +Cc: igt-dev
== Series Details ==
Series: tests/kms_cursor_legacy: Fix assertion failure due to vblank mismatch (rev2)
URL : https://patchwork.freedesktop.org/series/57673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5740_full -> IGTPW_2610_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2610_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2610_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57673/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2610_full:
### IGT changes ###
#### Warnings ####
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2610_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@deep-bsd:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +79
* igt@gem_softpin@noreloc-s3:
- shard-snb: PASS -> FAIL [fdo#103375]
* igt@gen3_render_tiledx_blits:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +15
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-hsw: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-c-degamma:
- shard-glk: NOTRUN -> FAIL [fdo#104782]
- shard-kbl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-pwrite:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +12
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +2
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +9
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: PASS -> FAIL [fdo#104894] +1
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: FAIL [fdo#109660] -> PASS
- shard-kbl: FAIL [fdo#109660] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_chv_cursor_fail@pipe-c-256x256-right-edge:
- shard-hsw: FAIL [fdo#107814] -> PASS
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_color@pipe-b-legacy-gamma:
- shard-glk: FAIL [fdo#104782] -> PASS
- shard-apl: FAIL [fdo#104782] -> PASS
- shard-kbl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-glk: FAIL [fdo#109350] -> PASS
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: FAIL [fdo#103167] -> PASS +1
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +3
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS +1
* igt@kms_plane@plane-position-hole-pipe-a-planes:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-a-tiling-x}:
- shard-apl: FAIL [fdo#110037] -> PASS +1
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-yf}:
- shard-kbl: FAIL [fdo#110037] -> PASS +2
* {igt@kms_plane_multiple@atomic-pipe-c-tiling-y}:
- shard-glk: FAIL [fdo#110037] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4884 -> IGTPW_2610
* Piglit: piglit_4509 -> None
CI_DRM_5740: a9decdcc27ca0e8dbdb538cf58e3840274110c17 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2610: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2610/
IGT_4884: c46051337b972f8b5a302afb6f603df06fea527d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2610/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 10+ messages in thread