* [PATCH] mmc: davinci: remove extraneous __init annotation
@ 2019-03-07 10:10 Arnd Bergmann
2019-03-07 10:13 ` Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2019-03-07 10:10 UTC (permalink / raw)
To: Ulf Hansson
Cc: Nick Desaulniers, Arnd Bergmann, Linus Walleij, Wolfram Sang,
linux-mmc, linux-kernel
Building with clang finds a mistaken __init tag:
WARNING: vmlinux.o(.text+0x5e4250): Section mismatch in reference from the function davinci_mmcsd_probe() to the function .init.text:init_mmcsd_host()
The function davinci_mmcsd_probe() references
the function __init init_mmcsd_host().
This is often because davinci_mmcsd_probe lacks a __init
annotation or the annotation of init_mmcsd_host is wrong.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mmc/host/davinci_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 49e0daf2ef5e..f37003df1e01 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1117,7 +1117,7 @@ static inline void mmc_davinci_cpufreq_deregister(struct mmc_davinci_host *host)
{
}
#endif
-static void __init init_mmcsd_host(struct mmc_davinci_host *host)
+static void init_mmcsd_host(struct mmc_davinci_host *host)
{
mmc_davinci_reset_ctrl(host, 1);
--
2.20.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: davinci: remove extraneous __init annotation
2019-03-07 10:10 [PATCH] mmc: davinci: remove extraneous __init annotation Arnd Bergmann
@ 2019-03-07 10:13 ` Wolfram Sang
2019-03-07 15:21 ` Nathan Chancellor
2019-03-18 10:51 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2019-03-07 10:13 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Nick Desaulniers, Linus Walleij, Wolfram Sang,
linux-mmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Thu, Mar 07, 2019 at 11:10:11AM +0100, Arnd Bergmann wrote:
> Building with clang finds a mistaken __init tag:
>
> WARNING: vmlinux.o(.text+0x5e4250): Section mismatch in reference from the function davinci_mmcsd_probe() to the function .init.text:init_mmcsd_host()
> The function davinci_mmcsd_probe() references
> the function __init init_mmcsd_host().
> This is often because davinci_mmcsd_probe lacks a __init
> annotation or the annotation of init_mmcsd_host is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: davinci: remove extraneous __init annotation
2019-03-07 10:10 [PATCH] mmc: davinci: remove extraneous __init annotation Arnd Bergmann
2019-03-07 10:13 ` Wolfram Sang
@ 2019-03-07 15:21 ` Nathan Chancellor
2019-03-18 10:51 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2019-03-07 15:21 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Hansson, Nick Desaulniers, Linus Walleij, Wolfram Sang,
linux-mmc, linux-kernel
On Thu, Mar 07, 2019 at 11:10:11AM +0100, Arnd Bergmann wrote:
> Building with clang finds a mistaken __init tag:
>
> WARNING: vmlinux.o(.text+0x5e4250): Section mismatch in reference from the function davinci_mmcsd_probe() to the function .init.text:init_mmcsd_host()
> The function davinci_mmcsd_probe() references
> the function __init init_mmcsd_host().
> This is often because davinci_mmcsd_probe lacks a __init
> annotation or the annotation of init_mmcsd_host is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/mmc/host/davinci_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 49e0daf2ef5e..f37003df1e01 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1117,7 +1117,7 @@ static inline void mmc_davinci_cpufreq_deregister(struct mmc_davinci_host *host)
> {
> }
> #endif
> -static void __init init_mmcsd_host(struct mmc_davinci_host *host)
> +static void init_mmcsd_host(struct mmc_davinci_host *host)
> {
>
> mmc_davinci_reset_ctrl(host, 1);
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: davinci: remove extraneous __init annotation
2019-03-07 10:10 [PATCH] mmc: davinci: remove extraneous __init annotation Arnd Bergmann
2019-03-07 10:13 ` Wolfram Sang
2019-03-07 15:21 ` Nathan Chancellor
@ 2019-03-18 10:51 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2019-03-18 10:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Nick Desaulniers, Linus Walleij, Wolfram Sang, linux-mmc,
Linux Kernel Mailing List
On Thu, 7 Mar 2019 at 11:10, Arnd Bergmann <arnd@arndb.de> wrote:
>
> Building with clang finds a mistaken __init tag:
>
> WARNING: vmlinux.o(.text+0x5e4250): Section mismatch in reference from the function davinci_mmcsd_probe() to the function .init.text:init_mmcsd_host()
> The function davinci_mmcsd_probe() references
> the function __init init_mmcsd_host().
> This is often because davinci_mmcsd_probe lacks a __init
> annotation or the annotation of init_mmcsd_host is wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/davinci_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 49e0daf2ef5e..f37003df1e01 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1117,7 +1117,7 @@ static inline void mmc_davinci_cpufreq_deregister(struct mmc_davinci_host *host)
> {
> }
> #endif
> -static void __init init_mmcsd_host(struct mmc_davinci_host *host)
> +static void init_mmcsd_host(struct mmc_davinci_host *host)
> {
>
> mmc_davinci_reset_ctrl(host, 1);
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-18 10:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 10:10 [PATCH] mmc: davinci: remove extraneous __init annotation Arnd Bergmann
2019-03-07 10:13 ` Wolfram Sang
2019-03-07 15:21 ` Nathan Chancellor
2019-03-18 10:51 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.