All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-07 15:53 ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-03-07 15:53 UTC (permalink / raw)
  To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
	Vincent Abriou, David Airlie, Daniel Vetter, Maxime Coquelin,
	Alexandre Torgue
  Cc: Arnd Bergmann, dri-devel, linux-stm32, linux-arm-kernel, linux-kernel

The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@ config DRM_STM
 	select DRM_KMS_CMA_HELPER
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
-	select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+	select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB
 
 	help
 	  Enable support for the on-chip display controller on
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-07 15:53 ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-03-07 15:53 UTC (permalink / raw)
  To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
	Vincent Abriou, David Airlie, Daniel Vetter, Maxime Coquelin,
	Alexandre Torgue
  Cc: linux-arm-kernel, linux-kernel, dri-devel, Arnd Bergmann, linux-stm32

The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@ config DRM_STM
 	select DRM_KMS_CMA_HELPER
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
-	select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+	select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB
 
 	help
 	  Enable support for the on-chip display controller on
-- 
2.20.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-07 15:53 ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-03-07 15:53 UTC (permalink / raw)
  To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
	Vincent Abriou, David Airlie, Daniel Vetter, Maxime Coquelin,
	Alexandre Torgue
  Cc: linux-arm-kernel, linux-kernel, dri-devel, Arnd Bergmann, linux-stm32

The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@ config DRM_STM
 	select DRM_KMS_CMA_HELPER
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
-	select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+	select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB
 
 	help
 	  Enable support for the on-chip display controller on
-- 
2.20.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
  2019-03-07 15:53 ` Arnd Bergmann
  (?)
  (?)
@ 2019-03-08 15:50 ` Yannick FERTRE
  2019-03-11 14:24     ` Arnd Bergmann
  -1 siblings, 1 reply; 10+ messages in thread
From: Yannick FERTRE @ 2019-03-08 15:50 UTC (permalink / raw)
  To: Arnd Bergmann, Philippe CORNU, Benjamin Gaignard, Vincent ABRIOU,
	David Airlie, Daniel Vetter, Maxime Coquelin, Alexandre TORGUE
  Cc: linux-arm-kernel, linux-stm32, dri-devel, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1563 bytes --]

Reviewed-by: Yannick Fertré <yannick.fertre@st.com><mailto:yannick.fertre@st.com>


Arnd,
could you merge the patch?
I think that Benjamin could also merge it.

Best regards

Yannick Fertré


On 3/7/19 4:53 PM, Arnd Bergmann wrote:

The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de><mailto:arnd@arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@ config DRM_STM
        select DRM_KMS_CMA_HELPER
        select DRM_PANEL_BRIDGE
        select VIDEOMODE_HELPERS
-       select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+       select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB

        help
          Enable support for the on-chip display controller on


--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division

[-- Attachment #1.2: Type: text/html, Size: 2414 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
  2019-03-08 15:50 ` Yannick FERTRE
  2019-03-11 14:24     ` Arnd Bergmann
@ 2019-03-11 14:24     ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-03-11 14:24 UTC (permalink / raw)
  To: Yannick FERTRE
  Cc: Philippe CORNU, Benjamin Gaignard, Vincent ABRIOU, David Airlie,
	Daniel Vetter, Maxime Coquelin, Alexandre TORGUE, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel

On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
>
> Reviewed-by: Yannick Fertré <yannick.fertre@st.com>

Thanks,

> Arnd,
> could you merge the patch?
> I think that Benjamin could also merge it.

I think this should go through the drm tree, so someone with
access to that should merge it, not me.

     Arnd

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-11 14:24     ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-03-11 14:24 UTC (permalink / raw)
  To: Yannick FERTRE
  Cc: Benjamin Gaignard, Maxime Coquelin, David Airlie, Philippe CORNU,
	dri-devel, linux-kernel, Daniel Vetter, Vincent ABRIOU,
	linux-stm32, linux-arm-kernel, Alexandre TORGUE

On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
>
> Reviewed-by: Yannick Fertré <yannick.fertre@st.com>

Thanks,

> Arnd,
> could you merge the patch?
> I think that Benjamin could also merge it.

I think this should go through the drm tree, so someone with
access to that should merge it, not me.

     Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-11 14:24     ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2019-03-11 14:24 UTC (permalink / raw)
  To: Yannick FERTRE
  Cc: Philippe CORNU, Benjamin Gaignard, Vincent ABRIOU, David Airlie,
	Daniel Vetter, Maxime Coquelin, Alexandre TORGUE, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel

On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
>
> Reviewed-by: Yannick Fertré <yannick.fertre@st.com>

Thanks,

> Arnd,
> could you merge the patch?
> I think that Benjamin could also merge it.

I think this should go through the drm tree, so someone with
access to that should merge it, not me.

     Arnd

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
  2019-03-11 14:24     ` Arnd Bergmann
  (?)
@ 2019-03-11 14:49       ` Benjamin Gaignard
  -1 siblings, 0 replies; 10+ messages in thread
From: Benjamin Gaignard @ 2019-03-11 14:49 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Yannick FERTRE, Philippe CORNU, Vincent ABRIOU, David Airlie,
	Daniel Vetter, Maxime Coquelin, Alexandre TORGUE, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel

Le lun. 11 mars 2019 à 15:24, Arnd Bergmann <arnd@arndb.de> a écrit :
>
> On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
> >
> > Reviewed-by: Yannick Fertré <yannick.fertre@st.com>
>
> Thanks,
>
> > Arnd,
> > could you merge the patch?
> > I think that Benjamin could also merge it.
>
> I think this should go through the drm tree, so someone with
> access to that should merge it, not me.

Applied on drm-misc-next,
Thanks,

Benjamin
>
>      Arnd

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-11 14:49       ` Benjamin Gaignard
  0 siblings, 0 replies; 10+ messages in thread
From: Benjamin Gaignard @ 2019-03-11 14:49 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Daniel Vetter, David Airlie, Philippe CORNU, dri-devel,
	linux-kernel, Yannick FERTRE, Maxime Coquelin, Vincent ABRIOU,
	linux-stm32, linux-arm-kernel, Alexandre TORGUE

Le lun. 11 mars 2019 à 15:24, Arnd Bergmann <arnd@arndb.de> a écrit :
>
> On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
> >
> > Reviewed-by: Yannick Fertré <yannick.fertre@st.com>
>
> Thanks,
>
> > Arnd,
> > could you merge the patch?
> > I think that Benjamin could also merge it.
>
> I think this should go through the drm tree, so someone with
> access to that should merge it, not me.

Applied on drm-misc-next,
Thanks,

Benjamin
>
>      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] drm/stm: fix CONFIG_FB dependency
@ 2019-03-11 14:49       ` Benjamin Gaignard
  0 siblings, 0 replies; 10+ messages in thread
From: Benjamin Gaignard @ 2019-03-11 14:49 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Yannick FERTRE, Philippe CORNU, Vincent ABRIOU, David Airlie,
	Daniel Vetter, Maxime Coquelin, Alexandre TORGUE, dri-devel,
	linux-stm32, linux-arm-kernel, linux-kernel

Le lun. 11 mars 2019 à 15:24, Arnd Bergmann <arnd@arndb.de> a écrit :
>
> On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
> >
> > Reviewed-by: Yannick Fertré <yannick.fertre@st.com>
>
> Thanks,
>
> > Arnd,
> > could you merge the patch?
> > I think that Benjamin could also merge it.
>
> I think this should go through the drm tree, so someone with
> access to that should merge it, not me.

Applied on drm-misc-next,
Thanks,

Benjamin
>
>      Arnd

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-03-11 14:49 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 15:53 [PATCH] drm/stm: fix CONFIG_FB dependency Arnd Bergmann
2019-03-07 15:53 ` Arnd Bergmann
2019-03-07 15:53 ` Arnd Bergmann
2019-03-08 15:50 ` Yannick FERTRE
2019-03-11 14:24   ` Arnd Bergmann
2019-03-11 14:24     ` Arnd Bergmann
2019-03-11 14:24     ` Arnd Bergmann
2019-03-11 14:49     ` Benjamin Gaignard
2019-03-11 14:49       ` Benjamin Gaignard
2019-03-11 14:49       ` Benjamin Gaignard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.