[igt-dev] [PATCH i-g-t 1/5] lib/aux: Plug memory leak in __igt_lsof_fds

[igt-dev] [PATCH i-g-t 1/5] lib/aux: Plug memory leak in __igt_lsof_fds

[Petri Latvala]

Add a missing closedir call.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 lib/igt_aux.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index ff98d91d..e5d41e32 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -1419,6 +1419,8 @@ again:
 		free(copy_fd_lnk);
 		free(fd_lnk);
 	}
+
+	closedir(dp);
 }
 
 /*
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/5] lib/aux: Plug memory leak in get_suspend_test

[Petri Latvala]

Free test_line in all paths out of the function.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 lib/igt_aux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index e5d41e32..f4939bb5 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -718,6 +718,8 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
 			break;
 		}
 
+	free(test_line);
+
 	if (!test_name)
 		return SUSPEND_TEST_NONE;
 
@@ -727,8 +729,6 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
 
 	igt_assert(test < SUSPEND_TEST_NUM);
 
-	free(test_line);
-
 	return test;
 }
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/5] lib/debugfs: Ensure null-termination in igt_hpd_storm_detected

[Petri Latvala]

Read sizeof - 1 to buf so it stays null-terminated.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 lib/igt_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 640c78e9..b0e5cfa5 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -628,7 +628,7 @@ bool igt_hpd_storm_detected(int drm_fd)
 	if (fd < 0)
 		return false;
 
-	igt_assert_lt(0, read(fd, buf, sizeof(buf)));
+	igt_assert_lt(0, read(fd, buf, sizeof(buf) - 1));
 	igt_assert(start_loc = strstr(buf, "Detected: "));
 	igt_assert_eq(sscanf(start_loc, "Detected: %s\n", detected_str), 1);
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 4/5] lib/fb: Add missing break in get_yuv_parameters

[Petri Latvala]

YVU420 and YVU422 will otherwise use offsets for P010 and pals.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 lib/igt_fb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 9dca2a46..f49becbd 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1841,6 +1841,8 @@ static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
 		params->y_offset = fb->offsets[0];
 		params->u_offset = fb->offsets[2];
 		params->v_offset = fb->offsets[1];
+		break;
+
 	case DRM_FORMAT_P010:
 	case DRM_FORMAT_P012:
 	case DRM_FORMAT_P016:
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 5/5] lib/igt_pm: Avoid out-of-bounds reads and writes

[Petri Latvala]

Read sizeof - 1 to buffers so null-termination stays in bounds.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 lib/igt_pm.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 49027238..94815239 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -176,7 +176,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 		if (fd < 0)
 			continue;
 
-		ret = read(fd, buf, sizeof(buf));
+		ret = read(fd, buf, sizeof(buf) - 1);
 		close(fd);
 		igt_assert(ret > 0);
 		strchomp(buf);
@@ -206,7 +206,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	}
 
 	igt_assert(read(fd, __igt_pm_audio_runtime_power_save,
-			sizeof(__igt_pm_audio_runtime_power_save)) > 0);
+			sizeof(__igt_pm_audio_runtime_power_save) - 1) > 0);
 	strchomp(__igt_pm_audio_runtime_power_save);
 	igt_install_exit_handler(__igt_pm_audio_runtime_exit_handler);
 	igt_assert_eq(write(fd, "1\n", 2), 2);
@@ -219,7 +219,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	}
 
 	igt_assert(read(fd, __igt_pm_audio_runtime_control,
-			sizeof(__igt_pm_audio_runtime_control)) > 0);
+			sizeof(__igt_pm_audio_runtime_control) - 1) > 0);
 	strchomp(__igt_pm_audio_runtime_control);
 	igt_assert_eq(write(fd, "auto\n", 5), 5);
 	close(fd);
@@ -527,7 +527,7 @@ bool igt_setup_runtime_pm(void)
 	 * them on test exit.
 	 */
 	size = read(fd, __igt_pm_runtime_autosuspend,
-		    sizeof(__igt_pm_runtime_autosuspend));
+		    sizeof(__igt_pm_runtime_autosuspend) - 1);
 
 	/*
 	 * If we fail to read from the file, it means this system doesn't
@@ -554,7 +554,7 @@ bool igt_setup_runtime_pm(void)
 	igt_assert_f(fd >= 0, "Can't open " POWER_DIR "/control\n");
 
 	igt_assert(read(fd, __igt_pm_runtime_control,
-			sizeof(__igt_pm_runtime_control)) > 0);
+			sizeof(__igt_pm_runtime_control) - 1) > 0);
 	strchomp(__igt_pm_runtime_control);
 
 	igt_debug("Saved runtime power management as '%s' and '%s'\n",
@@ -588,7 +588,7 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
 	char buf[32];
 
 	lseek(pm_status_fd, 0, SEEK_SET);
-	n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf));
+	n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
 	igt_assert(n_read >= 0);
 	buf[n_read] = '\0';
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/5] lib/aux: Plug memory leak in __igt_lsof_fds

[Chris Wilson]

Quoting Petri Latvala (2019-03-07 11:24:23)
> Add a missing closedir call.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  lib/igt_aux.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index ff98d91d..e5d41e32 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -1419,6 +1419,8 @@ again:
>                 free(copy_fd_lnk);
>                 free(fd_lnk);
>         }
> +
> +       closedir(dp);

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/5] lib/aux: Plug memory leak in get_suspend_test

[Chris Wilson]

Quoting Petri Latvala (2019-03-07 11:24:24)
> Free test_line in all paths out of the function.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  lib/igt_aux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index e5d41e32..f4939bb5 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -718,6 +718,8 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
>                         break;
>                 }
>  
> +       free(test_line);
> +
>         if (!test_name)
>                 return SUSPEND_TEST_NONE;
>  
> @@ -727,8 +729,6 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
>  
>         igt_assert(test < SUSPEND_TEST_NUM);
>  
> -       free(test_line);
> -

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/5] lib/aux: Plug memory leak in get_suspend_test

[Chris Wilson]

Quoting Chris Wilson (2019-03-07 12:09:26)
> Quoting Petri Latvala (2019-03-07 11:24:24)
> > Free test_line in all paths out of the function.
> > 
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > ---
> >  lib/igt_aux.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> > index e5d41e32..f4939bb5 100644
> > --- a/lib/igt_aux.c
> > +++ b/lib/igt_aux.c
> > @@ -718,6 +718,8 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
> >                         break;
> >                 }
> >  
> > +       free(test_line);
> > +
> >         if (!test_name)
> >                 return SUSPEND_TEST_NONE;
> >  
> > @@ -727,8 +729,6 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
> >  
> >         igt_assert(test < SUSPEND_TEST_NUM);
> >  
> > -       free(test_line);
> > -
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Scratch that, test_name points into test_line and is used in the second
loop.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/5] lib/debugfs: Ensure null-termination in igt_hpd_storm_detected

[Chris Wilson]

Quoting Petri Latvala (2019-03-07 11:24:25)
> Read sizeof - 1 to buf so it stays null-terminated.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  lib/igt_debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
> index 640c78e9..b0e5cfa5 100644
> --- a/lib/igt_debugfs.c
> +++ b/lib/igt_debugfs.c
> @@ -628,7 +628,7 @@ bool igt_hpd_storm_detected(int drm_fd)
>         if (fd < 0)
>                 return false;
>  
> -       igt_assert_lt(0, read(fd, buf, sizeof(buf)));
> +       igt_assert_lt(0, read(fd, buf, sizeof(buf) - 1));
>         igt_assert(start_loc = strstr(buf, "Detected: "));

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 5/5] lib/igt_pm: Avoid out-of-bounds reads and writes

[Chris Wilson]

Quoting Petri Latvala (2019-03-07 11:24:27)
> Read sizeof - 1 to buffers so null-termination stays in bounds.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  lib/igt_pm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 49027238..94815239 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -176,7 +176,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>                 if (fd < 0)
>                         continue;
>  
> -               ret = read(fd, buf, sizeof(buf));
> +               ret = read(fd, buf, sizeof(buf) - 1);
>                 close(fd);
>                 igt_assert(ret > 0);

Could do with buf[ret] = '\0'; as well.

>                 strchomp(buf);
> @@ -206,7 +206,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>         }
>  
>         igt_assert(read(fd, __igt_pm_audio_runtime_power_save,
> -                       sizeof(__igt_pm_audio_runtime_power_save)) > 0);
> +                       sizeof(__igt_pm_audio_runtime_power_save) - 1) > 0);

We reuse __igt_pm_audio_runtime_power_save and never complete clear it
between used.

We need

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 585706cb1..a76f8ae64 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -101,7 +101,12 @@ static int __igt_pm_audio_restore_runtime_pm(void)

        close(fd);

-       __igt_pm_audio_runtime_power_save[0] = 0;
+       memset(__igt_pm_audio_runtime_power_save, 0
+              sizeof(__igt_pm_audio_runtime_power_save));
+
+       memset(__igt_pm_audio_runtime_control, 0
+              sizeof(__igt_pm_audio_runtime_control));
+
        free(__igt_pm_audio_runtime_control_path);
        __igt_pm_audio_runtime_control_path = NULL;

as well.


>         strchomp(__igt_pm_audio_runtime_power_save);
>         igt_install_exit_handler(__igt_pm_audio_runtime_exit_handler);
>         igt_assert_eq(write(fd, "1\n", 2), 2);
> @@ -219,7 +219,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>         }
>  
>         igt_assert(read(fd, __igt_pm_audio_runtime_control,
> -                       sizeof(__igt_pm_audio_runtime_control)) > 0);
> +                       sizeof(__igt_pm_audio_runtime_control) - 1) > 0);
>         strchomp(__igt_pm_audio_runtime_control);
>         igt_assert_eq(write(fd, "auto\n", 5), 5);
>         close(fd);
> @@ -527,7 +527,7 @@ bool igt_setup_runtime_pm(void)
>          * them on test exit.
>          */
>         size = read(fd, __igt_pm_runtime_autosuspend,
> -                   sizeof(__igt_pm_runtime_autosuspend));
> +                   sizeof(__igt_pm_runtime_autosuspend) - 1);
>  

This needs __igt_pm_runtime_autosuspend[size] = '\0';

>         /*
>          * If we fail to read from the file, it means this system doesn't
> @@ -554,7 +554,7 @@ bool igt_setup_runtime_pm(void)
>         igt_assert_f(fd >= 0, "Can't open " POWER_DIR "/control\n");
>  
>         igt_assert(read(fd, __igt_pm_runtime_control,
> -                       sizeof(__igt_pm_runtime_control)) > 0);
> +                       sizeof(__igt_pm_runtime_control) - 1) > 0);
>         strchomp(__igt_pm_runtime_control);
>  
>         igt_debug("Saved runtime power management as '%s' and '%s'\n",
> @@ -588,7 +588,7 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
>         char buf[32];
>  
>         lseek(pm_status_fd, 0, SEEK_SET);
> -       n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf));
> +       n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
>         igt_assert(n_read >= 0);
>         buf[n_read] = '\0';

Ok.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2 2/5] lib/aux: Plug memory leak in get_suspend_test

[Petri Latvala]

Free test_line in all paths out of the function.

v2: Avoid freeing too soon (Chris)

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_aux.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index e5d41e32..6eaf546e 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -718,8 +718,10 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
 			break;
 		}
 
-	if (!test_name)
+	if (!test_name) {
+	  	free(test_line);
 		return SUSPEND_TEST_NONE;
+	}
 
 	for (test = SUSPEND_TEST_NONE; test < SUSPEND_TEST_NUM; test++)
 		if (strcmp(suspend_test_name[test], test_name) == 0)
@@ -728,7 +730,6 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
 	igt_assert(test < SUSPEND_TEST_NUM);
 
 	free(test_line);
-
 	return test;
 }
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/5] lib/aux: Plug memory leak in get_suspend_test

[Chris Wilson]

Quoting Petri Latvala (2019-03-07 12:37:24)
> Free test_line in all paths out of the function.
> 
> v2: Avoid freeing too soon (Chris)
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_aux.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index e5d41e32..6eaf546e 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -718,8 +718,10 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
>                         break;
>                 }
>  
> -       if (!test_name)
> +       if (!test_name) {
> +               free(test_line);
>                 return SUSPEND_TEST_NONE;
> +       }
>  
>         for (test = SUSPEND_TEST_NONE; test < SUSPEND_TEST_NUM; test++)
>                 if (strcmp(suspend_test_name[test], test_name) == 0)
> @@ -728,7 +730,6 @@ static enum igt_suspend_test get_suspend_test(int power_dir)
>         igt_assert(test < SUSPEND_TEST_NUM);
>  
>         free(test_line);
> -
>         return test;

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2 5/5] lib/igt_pm: Avoid out-of-bounds reads and writes

[Petri Latvala]

Read sizeof - 1 to buffers so null-termination stays in bounds.

v2: Also clear the buffers before reusing (Chris).

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 49027238..fd22273a 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -101,7 +101,12 @@ static int __igt_pm_audio_restore_runtime_pm(void)
 
 	close(fd);
 
-	__igt_pm_audio_runtime_power_save[0] = 0;
+	memset(__igt_pm_audio_runtime_power_save, 0,
+	       sizeof(__igt_pm_audio_runtime_power_save));
+
+	memset(__igt_pm_audio_runtime_control, 0,
+	       sizeof(__igt_pm_audio_runtime_control));
+
 	free(__igt_pm_audio_runtime_control_path);
 	__igt_pm_audio_runtime_control_path = NULL;
 
@@ -176,9 +181,10 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 		if (fd < 0)
 			continue;
 
-		ret = read(fd, buf, sizeof(buf));
+		ret = read(fd, buf, sizeof(buf) - 1);
 		close(fd);
 		igt_assert(ret > 0);
+		buf[ret] = '\0';
 		strchomp(buf);
 
 		/* Realtek and similar devices are not what we are after. */
@@ -206,7 +212,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	}
 
 	igt_assert(read(fd, __igt_pm_audio_runtime_power_save,
-			sizeof(__igt_pm_audio_runtime_power_save)) > 0);
+			sizeof(__igt_pm_audio_runtime_power_save) - 1) > 0);
 	strchomp(__igt_pm_audio_runtime_power_save);
 	igt_install_exit_handler(__igt_pm_audio_runtime_exit_handler);
 	igt_assert_eq(write(fd, "1\n", 2), 2);
@@ -219,7 +225,7 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	}
 
 	igt_assert(read(fd, __igt_pm_audio_runtime_control,
-			sizeof(__igt_pm_audio_runtime_control)) > 0);
+			sizeof(__igt_pm_audio_runtime_control) - 1) > 0);
 	strchomp(__igt_pm_audio_runtime_control);
 	igt_assert_eq(write(fd, "auto\n", 5), 5);
 	close(fd);
@@ -527,7 +533,7 @@ bool igt_setup_runtime_pm(void)
 	 * them on test exit.
 	 */
 	size = read(fd, __igt_pm_runtime_autosuspend,
-		    sizeof(__igt_pm_runtime_autosuspend));
+		    sizeof(__igt_pm_runtime_autosuspend) - 1);
 
 	/*
 	 * If we fail to read from the file, it means this system doesn't
@@ -539,6 +545,8 @@ bool igt_setup_runtime_pm(void)
 		return false;
 	}
 
+	__igt_pm_runtime_autosuspend[size] = '\0';
+
 	strchomp(__igt_pm_runtime_autosuspend);
 	igt_install_exit_handler(__igt_pm_runtime_exit_handler);
 
@@ -554,7 +562,7 @@ bool igt_setup_runtime_pm(void)
 	igt_assert_f(fd >= 0, "Can't open " POWER_DIR "/control\n");
 
 	igt_assert(read(fd, __igt_pm_runtime_control,
-			sizeof(__igt_pm_runtime_control)) > 0);
+			sizeof(__igt_pm_runtime_control) - 1) > 0);
 	strchomp(__igt_pm_runtime_control);
 
 	igt_debug("Saved runtime power management as '%s' and '%s'\n",
@@ -588,7 +596,7 @@ enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
 	char buf[32];
 
 	lseek(pm_status_fd, 0, SEEK_SET);
-	n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf));
+	n_read = read(pm_status_fd, buf, ARRAY_SIZE(buf) - 1);
 	igt_assert(n_read >= 0);
 	buf[n_read] = '\0';
 
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 5/5] lib/igt_pm: Avoid out-of-bounds reads and writes

[Chris Wilson]

Quoting Petri Latvala (2019-03-07 13:01:30)
> Read sizeof - 1 to buffers so null-termination stays in bounds.
> 
> v2: Also clear the buffers before reusing (Chris).
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

That's everything I spotted so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/aux: Plug memory leak in __igt_lsof_fds (rev4)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/5] lib/aux: Plug memory leak in __igt_lsof_fds (rev4)
URL   : https://patchwork.freedesktop.org/series/57692/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5714 -> IGTPW_2565
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57692/revisions/4/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2565 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-compute:
    - fi-kbl-8809g:       NOTRUN -> FAIL [fdo#108094]

  * igt@amdgpu/amd_basic@cs-sdma:
    - fi-kbl-7560u:       NOTRUN -> SKIP [fdo#109271] +17

  * igt@amdgpu/amd_basic@query-info:
    - fi-bsw-kefka:       NOTRUN -> SKIP [fdo#109271] +55

  * igt@gem_exec_basic@basic-bsd2:
    - fi-kbl-7500u:       NOTRUN -> SKIP [fdo#109271] +9

  * igt@gem_exec_basic@gtt-bsd:
    - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] +103

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u3:          PASS -> FAIL [fdo#103375]
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         NOTRUN -> INCOMPLETE [fdo#103927] / [fdo#109720]

  * igt@kms_busy@basic-flip-b:
    - fi-gdg-551:         PASS -> FAIL [fdo#103182]

  * igt@kms_busy@basic-flip-c:
    - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-bsw-kefka:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       NOTRUN -> DMESG-WARN [fdo#103841]

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] +52

  * igt@kms_chamelium@vga-edid-read:
    - fi-skl-6600u:       NOTRUN -> SKIP [fdo#109271] +41

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-bxt-j4205:       NOTRUN -> SKIP [fdo#109271] +47

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]

  * igt@kms_psr@primary_page_flip:
    - fi-apl-guc:         NOTRUN -> SKIP [fdo#109271] +50

  * igt@runner@aborted:
    - fi-kbl-7500u:       NOTRUN -> FAIL [fdo#103841]
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
#### Possible fixes ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       DMESG-WARN [fdo#108965] -> PASS

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-kbl-7560u:       INCOMPLETE -> PASS

  
#### Warnings ####

  * igt@i915_selftest@live_contexts:
    - fi-icl-u2:          DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569]

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (40 -> 42)
------------------------------

  Additional (7): fi-byt-j1900 fi-bwr-2160 fi-apl-guc fi-kbl-7500u fi-bxt-j4205 fi-bsw-kefka fi-skl-6600u 
  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-ctg-p8600 


Build changes
-------------

    * IGT: IGT_4876 -> IGTPW_2565

  CI_DRM_5714: f0591e61349e96e8faba5348515043884e5ba542 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2565: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2565/
  IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2565/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/5] lib/aux: Plug memory leak in __igt_lsof_fds (rev4)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/5] lib/aux: Plug memory leak in __igt_lsof_fds (rev4)
URL   : https://patchwork.freedesktop.org/series/57692/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5714_full -> IGTPW_2565_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57692/revisions/4/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2565_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-suspend:
    - shard-snb:          PASS -> FAIL [fdo#103375]

  * igt@i915_pm_rpm@gem-execbuf-stress-extra-wait:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +102

  * igt@kms_busy@extended-modeset-hang-newfb-render-f:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-c:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +9

  * igt@kms_color@pipe-a-ctm-max:
    - shard-kbl:          PASS -> FAIL [fdo#108147]

  * igt@kms_color@pipe-b-ctm-max:
    - shard-apl:          PASS -> FAIL [fdo#108147] +1

  * igt@kms_color@pipe-b-degamma:
    - shard-apl:          PASS -> FAIL [fdo#104782] +1

  * igt@kms_cursor_crc@cursor-256x85-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-256x85-sliding:
    - shard-kbl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-alpha-opaque:
    - shard-apl:          PASS -> FAIL [fdo#109350]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
    - shard-glk:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-render:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +15

  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +4

  * igt@kms_plane@plane-position-covered-pipe-c-planes:
    - shard-apl:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          PASS -> FAIL [fdo#109016]

  * igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
    - shard-apl:          PASS -> FAIL [fdo#104894]
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665] +1
    - shard-snb:          PASS -> INCOMPLETE [fdo#105411]

  * igt@tools_test@tools_test:
    - shard-snb:          PASS -> SKIP [fdo#109271]

  
#### Possible fixes ####

  * igt@kms_busy@extended-modeset-hang-newfb-render-a:
    - shard-kbl:          DMESG-WARN [fdo#107956] -> PASS +1

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-hsw:          DMESG-WARN [fdo#107956] -> PASS +1

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-snb:          DMESG-WARN [fdo#107956] -> PASS +1

  * igt@kms_cursor_crc@cursor-256x256-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS +5

  * igt@kms_cursor_crc@cursor-256x256-sliding:
    - shard-kbl:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-256x256-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-kbl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          FAIL [fdo#102887] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
    - shard-kbl:          FAIL [fdo#103167] -> PASS
    - shard-apl:          FAIL [fdo#103167] -> PASS +2

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-glk:          FAIL [fdo#103167] -> PASS +2

  * igt@kms_plane@plane-position-covered-pipe-a-planes:
    - shard-apl:          FAIL [fdo#103166] -> PASS +5

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-apl:          FAIL [fdo#108145] -> PASS +1

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-apl:          FAIL [fdo#104894] -> PASS +3

  * igt@kms_vblank@pipe-c-ts-continuation-modeset:
    - shard-kbl:          FAIL [fdo#104894] -> PASS +1

  * igt@perf_pmu@rc6-runtime-pm:
    - shard-apl:          FAIL [fdo#105010] -> PASS
    - shard-kbl:          FAIL [fdo#105010] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4876 -> IGTPW_2565
    * Piglit: piglit_4509 -> None

  CI_DRM_5714: f0591e61349e96e8faba5348515043884e5ba542 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2565: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2565/
  IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2565/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev