* [PATCH] nvme: Don't warn on block content change effects
@ 2019-02-28 15:38 Keith Busch
2019-02-28 20:04 ` Sagi Grimberg
2019-03-08 13:43 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2019-02-28 15:38 UTC (permalink / raw)
A write or flush IO passthrough command is expected to change the
logical block content, so don't warn on these as no additional handling
is necessary.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 07bf2bff3a76..e1d3e9c41d84 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1250,7 +1250,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
if (ns) {
if (ctrl->effects)
effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
- if (effects & ~NVME_CMD_EFFECTS_CSUPP)
+ if (effects & ~(NVME_CMD_EFFECTS_CSUPP|NVME_CMD_EFFECTS_LBCC))
dev_warn(ctrl->device,
"IO command:%02x has unhandled effects:%08x\n",
opcode, effects);
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme: Don't warn on block content change effects
2019-02-28 15:38 [PATCH] nvme: Don't warn on block content change effects Keith Busch
@ 2019-02-28 20:04 ` Sagi Grimberg
2019-03-08 13:43 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2019-02-28 20:04 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme: Don't warn on block content change effects
2019-02-28 15:38 [PATCH] nvme: Don't warn on block content change effects Keith Busch
2019-02-28 20:04 ` Sagi Grimberg
@ 2019-03-08 13:43 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-03-08 13:43 UTC (permalink / raw)
Thanks,
applied to nvme-5.1.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-08 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 15:38 [PATCH] nvme: Don't warn on block content change effects Keith Busch
2019-02-28 20:04 ` Sagi Grimberg
2019-03-08 13:43 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.