All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu
@ 2019-03-08 14:36 Nicholas Kazlauskas
  2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu Nicholas Kazlauskas
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Nicholas Kazlauskas @ 2019-03-08 14:36 UTC (permalink / raw)
  To: igt-dev

These helpers will be used to address amdgpu specific quirks and
features. They're implemented like the i915 and VC4 helpers.

In order for the string comparison to pick up "amdgpu" the buffer size
had to be expanded for __is_device. I've gone ahead and made it 12 bytes
to cover everything that's there right now.

Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 lib/drmtest.c | 12 +++++++++++-
 lib/drmtest.h |  2 ++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 6506791b..d09638e8 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -93,7 +93,7 @@ static int __get_drm_device_name(int fd, char *name, int name_size)
 
 static bool __is_device(int fd, const char *expect)
 {
-	char name[5] = "";
+	char name[12] = "";
 
 	if (__get_drm_device_name(fd, name, sizeof(name) - 1))
 		return false;
@@ -101,6 +101,11 @@ static bool __is_device(int fd, const char *expect)
 	return strcmp(expect, name) == 0;
 }
 
+bool is_amdgpu_device(int fd)
+{
+	return __is_device(fd, "amdgpu");
+}
+
 bool is_i915_device(int fd)
 {
 	return __is_device(fd, "i915");
@@ -485,6 +490,11 @@ int drm_open_driver_render(int chipset)
 	return fd;
 }
 
+void igt_require_amdgpu(int fd)
+{
+	igt_require(is_amdgpu_device(fd));
+}
+
 void igt_require_intel(int fd)
 {
 	igt_require(is_i915_device(fd) && has_known_intel_chipset(fd));
diff --git a/lib/drmtest.h b/lib/drmtest.h
index ca347a71..f509e0d4 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -79,9 +79,11 @@ int __drm_open_driver(int chipset);
 
 void gem_quiescent_gpu(int fd);
 
+void igt_require_amdgpu(int fd);
 void igt_require_intel(int fd);
 void igt_require_vc4(int fd);
 
+bool is_amdgpu_device(int fd);
 bool is_i915_device(int fd);
 bool is_vc4_device(int fd);
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [igt-dev] [PATCH i-g-t 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu
  2019-03-08 14:36 [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu Nicholas Kazlauskas
@ 2019-03-08 14:36 ` Nicholas Kazlauskas
  2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer " Nicholas Kazlauskas
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Nicholas Kazlauskas @ 2019-03-08 14:36 UTC (permalink / raw)
  To: igt-dev

A black FB on amdgpu returns a CRC of (0, 0, 0), which IGT considers
suspicious. All our CRC values are also 16-bit so a value of 0xffffffff
can't be obtained.

Drop the suspicious CRC checks on amdgpu by checking the device in
crc_sanity_checks. We need the drm_fd for this so pass in pipe_crc
to the function to get it. It makes more sense to me to do it this
way than to duplicate code and the explanation on both calls to
crc_sanity_checks.

Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 lib/igt_debugfs.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index b0e5cfa5..b655edef 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -886,11 +886,15 @@ igt_pipe_crc_get_crcs(igt_pipe_crc_t *pipe_crc, int n_crcs,
 	return n;
 }
 
-static void crc_sanity_checks(igt_crc_t *crc)
+static void crc_sanity_checks(igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
 {
 	int i;
 	bool all_zero = true;
 
+	/* Any CRC value can be considered valid on amdgpu hardware. */
+	if (is_amdgpu_device(pipe_crc->fd))
+		return;
+
 	for (i = 0; i < crc->n_words; i++) {
 		igt_warn_on_f(crc->crc[i] == 0xffffffff,
 			      "Suspicious CRC: it looks like the CRC "
@@ -944,7 +948,7 @@ void igt_pipe_crc_get_single(igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
 {
 	read_one_crc(pipe_crc, crc);
 
-	crc_sanity_checks(crc);
+	crc_sanity_checks(pipe_crc, crc);
 }
 
 /**
@@ -973,7 +977,7 @@ igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
 		}
 	} while (crc->frame <= vblank);
 
-	crc_sanity_checks(crc);
+	crc_sanity_checks(pipe_crc, crc);
 }
 
 /**
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer on amdgpu
  2019-03-08 14:36 [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu Nicholas Kazlauskas
  2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu Nicholas Kazlauskas
@ 2019-03-08 14:36 ` Nicholas Kazlauskas
  2019-03-08 14:40   ` Chris Wilson
  2019-03-08 17:45 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu Patchwork
  2019-03-08 21:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 1 reply; 9+ messages in thread
From: Nicholas Kazlauskas @ 2019-03-08 14:36 UTC (permalink / raw)
  To: igt-dev

IGT expects buffers returned from DRM_IOCTL_MODE_MAP_DUMB to be
cleared, but amdgpu retains the contents previously in memory
in the buffer - clear it on amdgpu by with a memset to 0.

While there's a clear_yuv_buffer directly below this that should take
care of the YUV format case for us, it has an assert to ensure that
the buffer contents were previously cleared. We'll fail that assert
if we don't clear it every time.

Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 lib/igt_fb.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f49becbd..084fed1e 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -595,6 +595,15 @@ uint64_t igt_fb_tiling_to_mod(uint64_t tiling)
 	}
 }
 
+static void clear_buffer(struct igt_fb *fb)
+{
+	void *ptr;
+
+	ptr = igt_fb_map_buffer(fb->fd, fb);
+	memset(ptr, 0, fb->size);
+	igt_fb_unmap_buffer(fb, ptr);
+}
+
 static void clear_yuv_buffer(struct igt_fb *fb)
 {
 	bool full_range = fb->color_range == IGT_COLOR_YCBCR_FULL_RANGE;
@@ -715,6 +724,14 @@ static int create_bo_for_fb(struct igt_fb *fb)
 					     bpp, strides, &fb->size);
 
 out:
+	/*
+	 * IGT expects buffers returned from DRM_IOCTL_MODE_MAP_DUMB to be
+	 * cleared, but amdgpu retains the contents previously in memory
+	 * in the buffer - clear it on amdgpu.
+	 */
+	if (is_amdgpu_device(fd))
+		clear_buffer(fb);
+
 	if (igt_format_is_yuv(fb->drm_format))
 		clear_yuv_buffer(fb);
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer on amdgpu
  2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer " Nicholas Kazlauskas
@ 2019-03-08 14:40   ` Chris Wilson
  2019-03-08 15:00     ` Kazlauskas, Nicholas
  0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-03-08 14:40 UTC (permalink / raw)
  To: Nicholas Kazlauskas, igt-dev

Quoting Nicholas Kazlauskas (2019-03-08 14:36:03)
> IGT expects buffers returned from DRM_IOCTL_MODE_MAP_DUMB to be
> cleared, but amdgpu retains the contents previously in memory
> in the buffer - clear it on amdgpu by with a memset to 0.

How is this not a kernel information leak?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer on amdgpu
  2019-03-08 14:40   ` Chris Wilson
@ 2019-03-08 15:00     ` Kazlauskas, Nicholas
  2019-03-08 15:08       ` Chris Wilson
  0 siblings, 1 reply; 9+ messages in thread
From: Kazlauskas, Nicholas @ 2019-03-08 15:00 UTC (permalink / raw)
  To: Chris Wilson, igt-dev

On 3/8/19 9:40 AM, Chris Wilson wrote:
> Quoting Nicholas Kazlauskas (2019-03-08 14:36:03)
>> IGT expects buffers returned from DRM_IOCTL_MODE_MAP_DUMB to be
>> cleared, but amdgpu retains the contents previously in memory
>> in the buffer - clear it on amdgpu by with a memset to 0.
> 
> How is this not a kernel information leak?
> -Chris
> 

I actually meant to write DRM_IOCTL_MODE_CREATE_DUMB, but it is an 
information leak for whatever was previously in VRAM anyway.

With AMDGPU you have to explicitly ask for the memory to be cleared when 
creating the BO with AMDGPU_GEM_CREATE_VRAM_CLEARED, but that flag isn't 
one of the flags used when creating buffers for amdgpu_mode_dumb_create.

Maybe it should be, but I'd be considered with any potential performance 
impact in doing so at least. I haven't done much driver benchmarking 
myself to know if it's a good idea or not.

Nicholas Kazlauskas
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer on amdgpu
  2019-03-08 15:00     ` Kazlauskas, Nicholas
@ 2019-03-08 15:08       ` Chris Wilson
  2019-03-08 15:10         ` Kazlauskas, Nicholas
  0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2019-03-08 15:08 UTC (permalink / raw)
  To: Kazlauskas, Nicholas, igt-dev

Quoting Kazlauskas, Nicholas (2019-03-08 15:00:46)
> On 3/8/19 9:40 AM, Chris Wilson wrote:
> > Quoting Nicholas Kazlauskas (2019-03-08 14:36:03)
> >> IGT expects buffers returned from DRM_IOCTL_MODE_MAP_DUMB to be
> >> cleared, but amdgpu retains the contents previously in memory
> >> in the buffer - clear it on amdgpu by with a memset to 0.
> > 
> > How is this not a kernel information leak?
> > -Chris
> > 
> 
> I actually meant to write DRM_IOCTL_MODE_CREATE_DUMB, but it is an 
> information leak for whatever was previously in VRAM anyway.
> 
> With AMDGPU you have to explicitly ask for the memory to be cleared when 
> creating the BO with AMDGPU_GEM_CREATE_VRAM_CLEARED, but that flag isn't 
> one of the flags used when creating buffers for amdgpu_mode_dumb_create.
> 
> Maybe it should be, but I'd be considered with any potential performance 
> impact in doing so at least. I haven't done much driver benchmarking 
> myself to know if it's a good idea or not.

It's a dumb buffer who's only purpose is to create splash framebuffer,
and is explicitly not meant to be used for rendering (which of course
means that userspace does...). I would strongly suggest it is cleared on
creation and anyone who complains be redirected to use the proper
interface for amdgpu.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer on amdgpu
  2019-03-08 15:08       ` Chris Wilson
@ 2019-03-08 15:10         ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 9+ messages in thread
From: Kazlauskas, Nicholas @ 2019-03-08 15:10 UTC (permalink / raw)
  To: Chris Wilson, igt-dev

On 3/8/19 10:08 AM, Chris Wilson wrote:
> Quoting Kazlauskas, Nicholas (2019-03-08 15:00:46)
>> On 3/8/19 9:40 AM, Chris Wilson wrote:
>>> Quoting Nicholas Kazlauskas (2019-03-08 14:36:03)
>>>> IGT expects buffers returned from DRM_IOCTL_MODE_MAP_DUMB to be
>>>> cleared, but amdgpu retains the contents previously in memory
>>>> in the buffer - clear it on amdgpu by with a memset to 0.
>>>
>>> How is this not a kernel information leak?
>>> -Chris
>>>
>>
>> I actually meant to write DRM_IOCTL_MODE_CREATE_DUMB, but it is an
>> information leak for whatever was previously in VRAM anyway.
>>
>> With AMDGPU you have to explicitly ask for the memory to be cleared when
>> creating the BO with AMDGPU_GEM_CREATE_VRAM_CLEARED, but that flag isn't
>> one of the flags used when creating buffers for amdgpu_mode_dumb_create.
>>
>> Maybe it should be, but I'd be considered with any potential performance
>> impact in doing so at least. I haven't done much driver benchmarking
>> myself to know if it's a good idea or not.
> 
> It's a dumb buffer who's only purpose is to create splash framebuffer,
> and is explicitly not meant to be used for rendering (which of course
> means that userspace does...). I would strongly suggest it is cleared on
> creation and anyone who complains be redirected to use the proper
> interface for amdgpu.
> -Chris
> 

Considering that most userspace probably goes through mesa which 
obviously doesn't use this API I would be inclined to agree with that 
perspective at least.

It probably doesn't hurt to post the patch to clear it on the kernel 
side and see what feedback shows up.

Thanks.

Nicholas Kazlauskas
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu
  2019-03-08 14:36 [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu Nicholas Kazlauskas
  2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu Nicholas Kazlauskas
  2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer " Nicholas Kazlauskas
@ 2019-03-08 17:45 ` Patchwork
  2019-03-08 21:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-03-08 17:45 UTC (permalink / raw)
  To: Nicholas Kazlauskas; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu
URL   : https://patchwork.freedesktop.org/series/57746/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5724 -> IGTPW_2573
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57746/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2573 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       PASS -> DMESG-WARN [fdo#108965]

  * igt@amdgpu/amd_cs_nop@fork-gfx0:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109315] +17

  * igt@gem_exec_basic@gtt-bsd2:
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +57

  * igt@gem_exec_basic@readonly-bsd1:
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +57
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109276] +7

  * igt@gem_exec_parse@basic-allowed:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109289] +1

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-bsw-kefka:       PASS -> SKIP [fdo#109271]

  * igt@i915_pm_rpm@basic-rte:
    - fi-bsw-kefka:       PASS -> FAIL [fdo#108800]

  * igt@i915_selftest@live_contexts:
    - fi-icl-u2:          NOTRUN -> DMESG-FAIL [fdo#108569]

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

  * igt@kms_busy@basic-flip-a:
    - fi-gdg-551:         PASS -> FAIL [fdo#103182]

  * igt@kms_busy@basic-flip-c:
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@dp-edid-read:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109316] +2

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-hsw-peppy:       NOTRUN -> SKIP [fdo#109271] +46

  * igt@kms_chamelium@vga-hpd-fast:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109309] +1

  * igt@kms_force_connector_basic@prune-stale-modes:
    - fi-icl-u2:          NOTRUN -> SKIP [fdo#109285] +3

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
    - fi-icl-u2:          NOTRUN -> FAIL [fdo#103167]
    - fi-byt-clapper:     NOTRUN -> FAIL [fdo#103167]

  * igt@runner@aborted:
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (41 -> 41)
------------------------------

  Additional (4): fi-hsw-peppy fi-byt-clapper fi-icl-u2 fi-snb-2520m 
  Missing    (4): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 


Build changes
-------------

    * IGT: IGT_4877 -> IGTPW_2573

  CI_DRM_5724: 3078a97d3931496cac45c0f4c94dc0f021fcb340 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2573: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2573/
  IGT_4877: d15ad69be07a987d5c2ba408201b287adae8ca59 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2573/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu
  2019-03-08 14:36 [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu Nicholas Kazlauskas
                   ` (2 preceding siblings ...)
  2019-03-08 17:45 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu Patchwork
@ 2019-03-08 21:30 ` Patchwork
  3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-03-08 21:30 UTC (permalink / raw)
  To: Nicholas Kazlauskas; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu
URL   : https://patchwork.freedesktop.org/series/57746/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5724_full -> IGTPW_2573_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/57746/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2573_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_sseu@invalid-args:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +13

  * igt@i915_pm_backlight@bad-brightness:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +18

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          PASS -> SKIP [fdo#109271]

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
    - shard-apl:          PASS -> FAIL [fdo#109660]

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-hang-oldfb-render-f:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_color@pipe-b-degamma:
    - shard-kbl:          PASS -> FAIL [fdo#104782]
    - shard-apl:          PASS -> FAIL [fdo#104782]

  * igt@kms_cursor_crc@cursor-128x128-onscreen:
    - shard-kbl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-128x42-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +2

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
    - shard-kbl:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          PASS -> FAIL [fdo#103167] +5

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-glk:          PASS -> FAIL [fdo#103167] +5

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
    - shard-apl:          NOTRUN -> FAIL [fdo#103166]

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
    - shard-apl:          PASS -> FAIL [fdo#103166] +2

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          PASS -> DMESG-FAIL [fdo#105763] +1

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          PASS -> FAIL [fdo#109016]

  * igt@kms_setmode@basic:
    - shard-kbl:          PASS -> FAIL [fdo#99912]

  * igt@kms_universal_plane@universal-plane-pipe-c-functional:
    - shard-glk:          PASS -> FAIL [fdo#103166] +6

  * igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
    - shard-apl:          NOTRUN -> FAIL [fdo#104894]
    - shard-kbl:          PASS -> FAIL [fdo#104894]

  
#### Possible fixes ####

  * igt@gem_eio@in-flight-suspend:
    - shard-hsw:          DMESG-WARN -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-render-c:
    - shard-hsw:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-kbl:          DMESG-WARN [fdo#107956] -> PASS
    - shard-snb:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-modeset-hang-oldfb-render-a:
    - shard-snb:          SKIP [fdo#109271] / [fdo#109278] -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-apl:          FAIL [fdo#107725] / [fdo#108145] -> PASS

  * igt@kms_color@pipe-a-ctm-max:
    - shard-apl:          FAIL [fdo#108147] -> PASS

  * igt@kms_color@pipe-a-degamma:
    - shard-apl:          FAIL [fdo#104782] / [fdo#108145] -> PASS

  * igt@kms_color@pipe-b-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-256x256-dpms:
    - shard-kbl:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x64-dpms:
    - shard-apl:          FAIL [fdo#103232] -> PASS +3

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
    - shard-snb:          SKIP [fdo#109271] -> PASS +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-glk:          FAIL [fdo#103167] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
    - shard-apl:          FAIL [fdo#103167] -> PASS +3

  * igt@kms_plane@pixel-format-pipe-b-planes:
    - shard-kbl:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_plane@plane-position-covered-pipe-c-planes:
    - shard-apl:          FAIL [fdo#103166] -> PASS +3

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
    - shard-apl:          DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +14

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
    - shard-glk:          FAIL [fdo#103166] -> PASS +2
    - shard-apl:          DMESG-FAIL [fdo#103166] / [fdo#103558] / [fdo#105602] -> PASS

  * igt@kms_setmode@basic:
    - shard-hsw:          FAIL [fdo#99912] -> PASS

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
    - shard-apl:          FAIL [fdo#104894] -> PASS +1
    - shard-kbl:          FAIL [fdo#104894] -> PASS +1

  * igt@perf@blocking:
    - shard-hsw:          FAIL [fdo#102252] -> PASS

  
#### Warnings ####

  * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
    - shard-apl:          DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] -> FAIL [fdo#108145]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4877 -> IGTPW_2573
    * Piglit: piglit_4509 -> None

  CI_DRM_5724: 3078a97d3931496cac45c0f4c94dc0f021fcb340 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2573: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2573/
  IGT_4877: d15ad69be07a987d5c2ba408201b287adae8ca59 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2573/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-03-08 21:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 14:36 [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu Nicholas Kazlauskas
2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu Nicholas Kazlauskas
2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer " Nicholas Kazlauskas
2019-03-08 14:40   ` Chris Wilson
2019-03-08 15:00     ` Kazlauskas, Nicholas
2019-03-08 15:08       ` Chris Wilson
2019-03-08 15:10         ` Kazlauskas, Nicholas
2019-03-08 17:45 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu Patchwork
2019-03-08 21:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.