* [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check
@ 2019-03-07 21:39 Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE Ville Syrjala
` (8 more replies)
0 siblings, 9 replies; 18+ messages in thread
From: Ville Syrjala @ 2019-03-07 21:39 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Deal with frame counter wraparound correcrtly.
v2: Make the comparison functions available for everyone (Chris)
Add some docs (gtk-doc seems obtuse so not 100% warning free)
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> #v1
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> #v1
---
lib/igt_debugfs.c | 2 +-
lib/igt_kms.h | 60 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 61 insertions(+), 1 deletion(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 640c78e972e9..b782a2a88b03 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -971,7 +971,7 @@ igt_pipe_crc_get_current(int drm_fd, igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
igt_pipe_crc_get_single(pipe_crc, crc);
return;
}
- } while (crc->frame <= vblank);
+ } while (igt_vblank_before_eq(crc->frame, vblank));
crc_sanity_checks(crc);
}
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index a29ad7836465..3c602576db34 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -767,4 +767,64 @@ void igt_cleanup_hotplug(struct udev_monitor *mon);
bool igt_display_has_format_mod(igt_display_t *display, uint32_t format, uint64_t modifier);
bool igt_plane_has_format_mod(igt_plane_t *plane, uint32_t format, uint64_t modifier);
+/**
+ * igt_vblank_after_eq:
+ * @a: First vblank sequence number.
+ * @b: Second vblank sequence number.
+ *
+ * Compare vblank sequence numbers,
+ * handling wraparound correctly.
+ *
+ * Returns: @a >= @b
+ */
+static inline bool igt_vblank_after_eq(uint32_t a, uint32_t b)
+{
+ return (int32_t)(a - b) >= 0;
+}
+
+/**
+ * igt_vblank_before_eq:
+ * @a: First vblank sequence number.
+ * @b: Second vblank sequence number.
+ *
+ * Compare vblank sequence numbers,
+ * handling wraparound correctly.
+ *
+ * Returns: @a <= @b
+ */
+static inline bool igt_vblank_before_eq(uint32_t a, uint32_t b)
+{
+ return igt_vblank_after_eq(b, a);
+}
+
+/**
+ * igt_vblank_after:
+ * @a: First vblank sequence number.
+ * @b: Second vblank sequence number.
+ *
+ * Compare vblank sequence numbers,
+ * handling wraparound correctly.
+ *
+ * Returns: @a > @b
+ */
+static inline bool igt_vblank_after(uint32_t a, uint32_t b)
+{
+ return (int32_t)(b - a) < 0;
+}
+
+/**
+ * igt_vblank_before:
+ * @a: First vblank sequence number.
+ * @b: Second vblank sequence number.
+ *
+ * Compare vblank sequence numbers,
+ * handling wraparound correctly.
+ *
+ * Returns: @a < @b
+ */
+static inline bool igt_vblank_before(uint32_t a, uint32_t b)
+{
+ return igt_vblank_after(b, a);
+}
+
#endif /* __IGT_KMS_H__ */
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
@ 2019-03-07 21:39 ` Ville Syrjala
2019-03-07 21:48 ` Chris Wilson
2019-03-08 16:49 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: " Ville Syrjala
` (7 subsequent siblings)
8 siblings, 2 replies; 18+ messages in thread
From: Ville Syrjala @ 2019-03-07 21:39 UTC (permalink / raw)
To: igt-dev; +Cc: Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Asking for the initial vblank count by specifying and absolute vblank count of 0
doesn't make much sense. Switch to a relative query instead.
It doesn't look like we care about lining up on the first vblank boundary so
we can just drop the NEXTONMISS flag. Only the relative timestamps of the
events will matter.
v2: Drop the NEXTONMISS (Daniel)
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_setmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 681496044f5d..acd606cd5b5e 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -434,7 +434,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
memset(&wait, 0, sizeof(wait));
wait.request.type = kmstest_get_vbl_flag(crtc_idx);
- wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_NEXTONMISS;
+ wait.request.type |= DRM_VBLANK_RELATIVE;
do_or_die(drmWaitVBlank(drm_fd, &wait));
last_seq = wait.reply.sequence;
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE Ville Syrjala
@ 2019-03-07 21:39 ` Ville Syrjala
2019-03-07 21:49 ` Chris Wilson
2019-03-08 16:50 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 4/5] tests/kms_flip: Validate the vbl sequence numbers Ville Syrjala
` (6 subsequent siblings)
8 siblings, 2 replies; 18+ messages in thread
From: Ville Syrjala @ 2019-03-07 21:39 UTC (permalink / raw)
To: igt-dev; +Cc: Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Asking for the initial vblank count by specifying and absolute vblank count of 0
doesn't make much sense. Switch to a relative query instead.
It doesn't look like we care about lining up on the first vblank boundary so
we can just drop the NEXTONMISS flag. Only the relative timestamps of the
events will matter.
v2: Drop the NEXTONMISS (Daniel)
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_flip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 798fc4e822af..cde8b739ea83 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1105,7 +1105,7 @@ static void calibrate_ts(struct test_output *o, int crtc_idx)
memset(&wait, 0, sizeof(wait));
wait.request.type = kmstest_get_vbl_flag(crtc_idx);
- wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_NEXTONMISS;
+ wait.request.type |= DRM_VBLANK_RELATIVE;
do_or_die(drmWaitVBlank(drm_fd, &wait));
last_seq = wait.reply.sequence;
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t 4/5] tests/kms_flip: Validate the vbl sequence numbers
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: " Ville Syrjala
@ 2019-03-07 21:39 ` Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: " Ville Syrjala
` (5 subsequent siblings)
8 siblings, 0 replies; 18+ messages in thread
From: Ville Syrjala @ 2019-03-07 21:39 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Make sure we haven't already passed the seq numbers we're
requesting when doing the ts calibration.
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_flip.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index cde8b739ea83..997957542329 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1118,8 +1118,17 @@ static void calibrate_ts(struct test_output *o, int crtc_idx)
wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_EVENT;
wait.request.sequence = last_seq;
for (n = 0; n < CALIBRATE_TS_STEPS; n++) {
+ drmVBlank check = {};
+
++wait.request.sequence;
do_or_die(drmWaitVBlank(drm_fd, &wait));
+
+ /* Double check that haven't already missed the vblank */
+ check.request.type = kmstest_get_vbl_flag(crtc_idx);
+ check.request.type |= DRM_VBLANK_RELATIVE;
+ do_or_die(drmWaitVBlank(drm_fd, &check));
+
+ igt_assert(!igt_vblank_after(check.reply.sequence, wait.request.sequence));
}
igt_stats_init_with_size(&stats, CALIBRATE_TS_STEPS);
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: Validate the vbl sequence numbers
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
` (2 preceding siblings ...)
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 4/5] tests/kms_flip: Validate the vbl sequence numbers Ville Syrjala
@ 2019-03-07 21:39 ` Ville Syrjala
2019-03-07 21:51 ` Chris Wilson
2019-03-07 22:03 ` [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Chris Wilson
` (4 subsequent siblings)
8 siblings, 1 reply; 18+ messages in thread
From: Ville Syrjala @ 2019-03-07 21:39 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Make sure we haven't already passed the seq numbers we're
requesting when doing the ts calibration.
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_setmode.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index acd606cd5b5e..5ce1397f968f 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -447,8 +447,17 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_EVENT;
wait.request.sequence = last_seq;
for (n = 0; n < CALIBRATE_TS_STEPS; n++) {
+ drmVBlank check = {};
+
++wait.request.sequence;
do_or_die(drmWaitVBlank(drm_fd, &wait));
+
+ /* Double check that haven't already missed the vblank */
+ check.request.type = kmstest_get_vbl_flag(crtc_idx);
+ check.request.type |= DRM_VBLANK_RELATIVE;
+ do_or_die(drmWaitVBlank(drm_fd, &check));
+
+ igt_assert(!igt_vblank_after(check.reply.sequence, wait.request.sequence));
}
igt_stats_init_with_size(&stats, CALIBRATE_TS_STEPS);
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE Ville Syrjala
@ 2019-03-07 21:48 ` Chris Wilson
2019-03-08 16:45 ` Ville Syrjälä
2019-03-08 16:49 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
1 sibling, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2019-03-07 21:48 UTC (permalink / raw)
To: Ville Syrjala, igt-dev; +Cc: Daniel Vetter
Quoting Ville Syrjala (2019-03-07 21:39:23)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Asking for the initial vblank count by specifying and absolute vblank count of 0
> doesn't make much sense. Switch to a relative query instead.
>
> It doesn't look like we care about lining up on the first vblank boundary so
> we can just drop the NEXTONMISS flag. Only the relative timestamps of the
> events will matter.
>
> v2: Drop the NEXTONMISS (Daniel)
No, this isn't about getting the current vblank, it's about aligning the
test to the start of the next vblank period, so that is much less of a
chance of that vblank happening during the setup. For which NEXTONMISS
is essential. You could look at the timestamp and say if within 1ms of
the next vblank, defer? Wasting 8ms is a nuisance but a pittance
compared to the ~2s runtime.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: " Ville Syrjala
@ 2019-03-07 21:49 ` Chris Wilson
2019-03-08 16:50 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
1 sibling, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2019-03-07 21:49 UTC (permalink / raw)
To: Ville Syrjala, igt-dev; +Cc: Daniel Vetter
Quoting Ville Syrjala (2019-03-07 21:39:24)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Asking for the initial vblank count by specifying and absolute vblank count of 0
> doesn't make much sense. Switch to a relative query instead.
>
> It doesn't look like we care about lining up on the first vblank boundary so
> we can just drop the NEXTONMISS flag. Only the relative timestamps of the
> events will matter.
>
> v2: Drop the NEXTONMISS (Daniel)
>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Ditto, as for kms_setmode.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: Validate the vbl sequence numbers
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: " Ville Syrjala
@ 2019-03-07 21:51 ` Chris Wilson
2019-03-08 17:14 ` Chris Wilson
0 siblings, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2019-03-07 21:51 UTC (permalink / raw)
To: Ville Syrjala, igt-dev
Quoting Ville Syrjala (2019-03-07 21:39:26)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make sure we haven't already passed the seq numbers we're
> requesting when doing the ts calibration.
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_setmode.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index acd606cd5b5e..5ce1397f968f 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -447,8 +447,17 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
> wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_EVENT;
> wait.request.sequence = last_seq;
> for (n = 0; n < CALIBRATE_TS_STEPS; n++) {
> + drmVBlank check = {};
> +
> ++wait.request.sequence;
> do_or_die(drmWaitVBlank(drm_fd, &wait));
> +
> + /* Double check that haven't already missed the vblank */
> + check.request.type = kmstest_get_vbl_flag(crtc_idx);
> + check.request.type |= DRM_VBLANK_RELATIVE;
> + do_or_die(drmWaitVBlank(drm_fd, &check));
I'm thinking this reinforces the NEXTONMISS alignment as opposed to
making that argument moot :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
` (3 preceding siblings ...)
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: " Ville Syrjala
@ 2019-03-07 22:03 ` Chris Wilson
2019-03-07 23:43 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] " Patchwork
` (3 subsequent siblings)
8 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2019-03-07 22:03 UTC (permalink / raw)
To: Ville Syrjala, igt-dev
Quoting Ville Syrjala (2019-03-07 21:39:22)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Deal with frame counter wraparound correcrtly.
>
> v2: Make the comparison functions available for everyone (Chris)
> Add some docs (gtk-doc seems obtuse so not 100% warning free)
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> #v1
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> #v1
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
` (4 preceding siblings ...)
2019-03-07 22:03 ` [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Chris Wilson
@ 2019-03-07 23:43 ` Patchwork
2019-03-08 2:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
8 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-03-07 23:43 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check
URL : https://patchwork.freedesktop.org/series/57710/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5717 -> IGTPW_2568
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57710/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2568 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +38
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> SKIP [fdo#109271] +17
* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-7560u: PASS -> INCOMPLETE [fdo#109831]
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: PASS -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u2: INCOMPLETE [fdo#108569] -> DMESG-FAIL [fdo#108569]
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#109831]: https://bugs.freedesktop.org/show_bug.cgi?id=109831
Participating hosts (43 -> 39)
------------------------------
Additional (1): fi-bdw-5557u
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4876 -> IGTPW_2568
CI_DRM_5717: e662cd77ee5fe0bc928fa61cc1ce561ccd410daf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2568: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2568/
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2568/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
` (5 preceding siblings ...)
2019-03-07 23:43 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] " Patchwork
@ 2019-03-08 2:27 ` Patchwork
2019-03-09 1:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3) Patchwork
2019-03-09 8:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
8 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-03-08 2:27 UTC (permalink / raw)
To: Ville Syrjala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check
URL : https://patchwork.freedesktop.org/series/57710/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5717_full -> IGTPW_2568_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57710/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2568_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@deep-bsd:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +30
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +2
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-modeset-hang-newfb-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_chv_cursor_fail@pipe-c-64x64-top-edge:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +1
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-kbl: PASS -> FAIL [fdo#109350]
- shard-apl: PASS -> FAIL [fdo#109350]
- shard-glk: PASS -> FAIL [fdo#109350]
* igt@kms_flip@2x-flip-vs-panning:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +4
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@gem_softpin@noreloc-s3:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP [fdo#109271] -> PASS
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: FAIL [fdo#109660] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +4
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_flip@modeset-vs-vblank-race:
- shard-snb: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-kbl: FAIL [fdo#103167] -> PASS
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +3
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_vblank@pipe-a-ts-continuation-modeset:
- shard-apl: FAIL [fdo#104894] -> PASS +1
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-kbl: FAIL [fdo#104894] -> PASS +1
* igt@perf_pmu@rc6-runtime-pm:
- shard-apl: FAIL [fdo#105010] -> PASS
- shard-kbl: FAIL [fdo#105010] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4876 -> IGTPW_2568
* Piglit: piglit_4509 -> None
CI_DRM_5717: e662cd77ee5fe0bc928fa61cc1ce561ccd410daf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2568: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2568/
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2568/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:48 ` Chris Wilson
@ 2019-03-08 16:45 ` Ville Syrjälä
0 siblings, 0 replies; 18+ messages in thread
From: Ville Syrjälä @ 2019-03-08 16:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, Daniel Vetter
On Thu, Mar 07, 2019 at 09:48:14PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-03-07 21:39:23)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Asking for the initial vblank count by specifying and absolute vblank count of 0
> > doesn't make much sense. Switch to a relative query instead.
> >
> > It doesn't look like we care about lining up on the first vblank boundary so
> > we can just drop the NEXTONMISS flag. Only the relative timestamps of the
> > events will matter.
> >
> > v2: Drop the NEXTONMISS (Daniel)
>
> No, this isn't about getting the current vblank, it's about aligning the
> test to the start of the next vblank period, so that is much less of a
> chance of that vblank happening during the setup. For which NEXTONMISS
> is essential.
That was my original assesment, but then I decided it wasn't needed
after all. Can't recall how I reached to that conclusion. I'll put
it back.
Hmm. If the test did '(now - last) / num_frames' it wouldn't matter
so much if missed a vblank or two. But I suppose that might hide
some of the jitter.
> You could look at the timestamp and say if within 1ms of
> the next vblank, defer? Wasting 8ms is a nuisance but a pittance
> compared to the ~2s runtime.
> -Chris
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t v2 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE Ville Syrjala
2019-03-07 21:48 ` Chris Wilson
@ 2019-03-08 16:49 ` Ville Syrjala
1 sibling, 0 replies; 18+ messages in thread
From: Ville Syrjala @ 2019-03-08 16:49 UTC (permalink / raw)
To: igt-dev; +Cc: Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Asking for the initial vblank count by specifying and absolute vblank count of 0
doesn't make much sense. Switch to a relative query instead.
v2: Drop the NEXTONMISS (Daniel)
v3: Put back the NEXTONMISS (Chris)
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_setmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 681496044f5d..d150483c368b 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -434,7 +434,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
memset(&wait, 0, sizeof(wait));
wait.request.type = kmstest_get_vbl_flag(crtc_idx);
- wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_NEXTONMISS;
+ wait.request.type |= DRM_VBLANK_RELATIVE | DRM_VBLANK_NEXTONMISS;
do_or_die(drmWaitVBlank(drm_fd, &wait));
last_seq = wait.reply.sequence;
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t v2 3/5] tests/kms_flip: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: " Ville Syrjala
2019-03-07 21:49 ` Chris Wilson
@ 2019-03-08 16:50 ` Ville Syrjala
2019-03-08 17:14 ` Chris Wilson
1 sibling, 1 reply; 18+ messages in thread
From: Ville Syrjala @ 2019-03-08 16:50 UTC (permalink / raw)
To: igt-dev; +Cc: Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Asking for the initial vblank count by specifying and absolute vblank count of 0
doesn't make much sense. Switch to a relative query instead.
v2: Drop the NEXTONMISS (Daniel)
v3: Put back the NEXTONMISS (Chris)
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_flip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 798fc4e822af..b9729dfd9474 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1105,7 +1105,7 @@ static void calibrate_ts(struct test_output *o, int crtc_idx)
memset(&wait, 0, sizeof(wait));
wait.request.type = kmstest_get_vbl_flag(crtc_idx);
- wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_NEXTONMISS;
+ wait.request.type |= DRM_VBLANK_RELATIVE | DRM_VBLANK_NEXTONMISS;
do_or_die(drmWaitVBlank(drm_fd, &wait));
last_seq = wait.reply.sequence;
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 3/5] tests/kms_flip: Request the initial vbl count with RELATIVE instead of ABSOLUTE
2019-03-08 16:50 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
@ 2019-03-08 17:14 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2019-03-08 17:14 UTC (permalink / raw)
To: Ville Syrjala, igt-dev; +Cc: Daniel Vetter
Quoting Ville Syrjala (2019-03-08 16:50:25)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Asking for the initial vblank count by specifying and absolute vblank count of 0
> doesn't make much sense. Switch to a relative query instead.
>
> v2: Drop the NEXTONMISS (Daniel)
> v3: Put back the NEXTONMISS (Chris)
>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Both v3
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: Validate the vbl sequence numbers
2019-03-07 21:51 ` Chris Wilson
@ 2019-03-08 17:14 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2019-03-08 17:14 UTC (permalink / raw)
To: Ville Syrjala, igt-dev
Quoting Chris Wilson (2019-03-07 21:51:54)
> Quoting Ville Syrjala (2019-03-07 21:39:26)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Make sure we haven't already passed the seq numbers we're
> > requesting when doing the ts calibration.
> >
> > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tests/kms_setmode.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> > index acd606cd5b5e..5ce1397f968f 100644
> > --- a/tests/kms_setmode.c
> > +++ b/tests/kms_setmode.c
> > @@ -447,8 +447,17 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
> > wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_EVENT;
> > wait.request.sequence = last_seq;
> > for (n = 0; n < CALIBRATE_TS_STEPS; n++) {
> > + drmVBlank check = {};
> > +
> > ++wait.request.sequence;
> > do_or_die(drmWaitVBlank(drm_fd, &wait));
> > +
> > + /* Double check that haven't already missed the vblank */
> > + check.request.type = kmstest_get_vbl_flag(crtc_idx);
> > + check.request.type |= DRM_VBLANK_RELATIVE;
> > + do_or_die(drmWaitVBlank(drm_fd, &check));
>
> I'm thinking this reinforces the NEXTONMISS alignment as opposed to
> making that argument moot :)
Both checks,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3)
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
` (6 preceding siblings ...)
2019-03-08 2:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-09 1:15 ` Patchwork
2019-03-09 8:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
8 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-03-09 1:15 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3)
URL : https://patchwork.freedesktop.org/series/57710/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5729 -> IGTPW_2579
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57710/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2579 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +56
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57
* igt@gem_exec_basic@readonly-bsd1:
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +57
* igt@i915_pm_rpm@basic-rte:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#108800]
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +56
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@basic-flip-c:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] / [fdo#109278] +2
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] +33
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362] +1
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (40 -> 36)
------------------------------
Additional (6): fi-bsw-n3050 fi-hsw-peppy fi-snb-2520m fi-bsw-kefka fi-byt-n2820 fi-byt-clapper
Missing (10): fi-ilk-m540 fi-icl-u2 fi-skl-6260u fi-bsw-cyan fi-gdg-551 fi-cfl-8109u fi-icl-u3 fi-pnv-d510 fi-ivb-3520m fi-bdw-samus
Build changes
-------------
* IGT: IGT_4878 -> IGTPW_2579
CI_DRM_5729: b50390674ed3eff49d1926a86acfee68b5565093 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2579: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2579/
IGT_4878: 478615b1edba88559386ba80ccbf0f035f3360a9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2579/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3)
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
` (7 preceding siblings ...)
2019-03-09 1:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3) Patchwork
@ 2019-03-09 8:28 ` Patchwork
8 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-03-09 8:28 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3)
URL : https://patchwork.freedesktop.org/series/57710/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5729_full -> IGTPW_2579_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57710/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2579_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_media_vme:
- shard-apl: PASS -> FAIL [fdo#109612]
* igt@gen3_render_tiledy_blits:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +23
* igt@i915_pm_rpm@gem-execbuf-stress-extra-wait:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +70
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
- shard-kbl: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-hsw: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-degamma:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +3
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: NOTRUN -> INCOMPLETE [fdo#103665]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-glk: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4
* igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894]
* igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
- shard-kbl: PASS -> FAIL [fdo#104894]
* igt@perf_pmu@idle-vcs1:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +37
#### Possible fixes ####
* igt@gem_eio@context-create:
- shard-glk: FAIL -> PASS
* igt@i915_pm_rps@reset:
- shard-glk: FAIL [fdo#102250] -> PASS
* igt@i915_suspend@forcewake:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1
- shard-snb: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#107725] / [fdo#108145] -> PASS
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_color@pipe-a-degamma:
- shard-apl: FAIL [fdo#104782] / [fdo#108145] -> PASS
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: FAIL [fdo#103167] -> PASS +6
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +4
- shard-apl: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: FAIL [fdo#104894] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@kms_content_protection@legacy:
- shard-apl: FAIL [fdo#108597] / [fdo#108739] -> INCOMPLETE [fdo#103927]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109612]: https://bugs.freedesktop.org/show_bug.cgi?id=109612
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4878 -> IGTPW_2579
* Piglit: piglit_4509 -> None
CI_DRM_5729: b50390674ed3eff49d1926a86acfee68b5565093 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2579: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2579/
IGT_4878: 478615b1edba88559386ba80ccbf0f035f3360a9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2579/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2019-03-09 8:28 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 21:39 [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 2/5] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE Ville Syrjala
2019-03-07 21:48 ` Chris Wilson
2019-03-08 16:45 ` Ville Syrjälä
2019-03-08 16:49 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 3/5] tests/kms_flip: " Ville Syrjala
2019-03-07 21:49 ` Chris Wilson
2019-03-08 16:50 ` [igt-dev] [PATCH i-g-t v2 " Ville Syrjala
2019-03-08 17:14 ` Chris Wilson
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 4/5] tests/kms_flip: Validate the vbl sequence numbers Ville Syrjala
2019-03-07 21:39 ` [igt-dev] [PATCH i-g-t 5/5] tests/kms_setmode: " Ville Syrjala
2019-03-07 21:51 ` Chris Wilson
2019-03-08 17:14 ` Chris Wilson
2019-03-07 22:03 ` [igt-dev] [PATCH i-g-t 1/5] lib/debugfs: Fix wraparound handling for crc frame counter check Chris Wilson
2019-03-07 23:43 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] " Patchwork
2019-03-08 2:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-09 1:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/debugfs: Fix wraparound handling for crc frame counter check (rev3) Patchwork
2019-03-09 8:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.