* [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2
@ 2019-03-08 19:44 Fabrice Fontaine
2019-03-09 14:00 ` Thomas Petazzoni
2019-03-25 16:24 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-03-08 19:44 UTC (permalink / raw)
To: buildroot
mongodb (like gnuradio) needs host-python2 however there is no way to
enforce this so add a dependency on !BR2_PACKAGE_PYTHON3.
Indeed, if BR2_PACKAGE_PYTHON3 is selected, then buildroot will only
build and install host-python-typing for host-python3.
This issue was not raised in the previous version of mongodb as
host-scons was the only dependency however we now have
host-python-typing and host-python-pyyaml dependencies and it
does not seem right to enforce python2 on those packages
Fixes:
- http://autobuild.buildroot.org/results/693bdba2c01a1b69f56d6ee75094a6a0fc3f40b4
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Move python3 dependency under BR2_PACKAGE_MONGODB
package/mongodb/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/mongodb/Config.in b/package/mongodb/Config.in
index 969b8e062f..c4449a7be4 100644
--- a/package/mongodb/Config.in
+++ b/package/mongodb/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_MONGODB_ARCH_SUPPORTS
config BR2_PACKAGE_MONGODB
bool "mongodb"
depends on BR2_PACKAGE_MONGODB_ARCH_SUPPORTS
+ depends on !BR2_PACKAGE_PYTHON3
depends on BR2_TOOLCHAIN_USES_GLIBC # needs glibc malloc_usable_size
depends on BR2_USE_WCHAR
depends on BR2_TOOLCHAIN_HAS_THREADS
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2
2019-03-08 19:44 [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2 Fabrice Fontaine
@ 2019-03-09 14:00 ` Thomas Petazzoni
2019-03-25 16:24 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-09 14:00 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
+Arnout in Cc.
On Fri, 8 Mar 2019 20:44:11 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> mongodb (like gnuradio) needs host-python2 however there is no way to
> enforce this so add a dependency on !BR2_PACKAGE_PYTHON3.
> Indeed, if BR2_PACKAGE_PYTHON3 is selected, then buildroot will only
> build and install host-python-typing for host-python3.
>
> This issue was not raised in the previous version of mongodb as
> host-scons was the only dependency however we now have
> host-python-typing and host-python-pyyaml dependencies and it
> does not seem right to enforce python2 on those packages
>
> Fixes:
> - http://autobuild.buildroot.org/results/693bdba2c01a1b69f56d6ee75094a6a0fc3f40b4
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
You forgot to propagate the !BR2_PACKAGE_PYTHON3 dependency to the
Config.in comment of mongodb, so I did that and applied.
However, in fact I'm not sure to agree with your statement that it does
not seem right to enforce python2 on host-python-typing and
host-python-pyyaml. The only package using them *is* mongodb. So
perhaps for those packages we could have the same principle as
python-setuptools, where python-setuptools is a target package for
python2/python3 but only a host package for python2, and there is a
separate python3-setuptools package to install host setuptools for
python3. It's not great, but it works. I don't know if it's worth it
doing that for mongodb though.
Thoughts ?
Life will be easier when there'll be only one Python version to
support...
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2
2019-03-08 19:44 [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2 Fabrice Fontaine
2019-03-09 14:00 ` Thomas Petazzoni
@ 2019-03-25 16:24 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-03-25 16:24 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> mongodb (like gnuradio) needs host-python2 however there is no way to
> enforce this so add a dependency on !BR2_PACKAGE_PYTHON3.
> Indeed, if BR2_PACKAGE_PYTHON3 is selected, then buildroot will only
> build and install host-python-typing for host-python3.
> This issue was not raised in the previous version of mongodb as
> host-scons was the only dependency however we now have
> host-python-typing and host-python-pyyaml dependencies and it
> does not seem right to enforce python2 on those packages
> Fixes:
> - http://autobuild.buildroot.org/results/693bdba2c01a1b69f56d6ee75094a6a0fc3f40b4
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
> - Move python3 dependency under BR2_PACKAGE_MONGODB
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 19:44 [Buildroot] [PATCH v2,1/1] package/mongodb: needs host-python2 Fabrice Fontaine
2019-03-09 14:00 ` Thomas Petazzoni
2019-03-25 16:24 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.