[PATCH 1/2] staging: aacraid: add SPDX GPL-2.0+ license identifier

[PATCH 1/2] staging: aacraid: add SPDX GPL-2.0+ license identifier

[Jules Irenge]

Add the SPDX GPL-2.0+ license identifier to fix checkpatch.pl warning
Issue found by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/scsi/aacraid/aachba.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 75ab5ff6b78c..955ddb32aa40 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  *	Adaptec AAC series RAID controller driver
  *	(c) Copyright 2001 Red Hat Inc.
-- 
2.20.1

[PATCH 2/2] staging: aacraid: remove boilerplate license text

[Jules Irenge]

Remove boilerplate license text.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/scsi/aacraid/aachba.c | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 955ddb32aa40..e70b45a74d0a 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -1,33 +1,10 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- *	Adaptec AAC series RAID controller driver
- *	(c) Copyright 2001 Red Hat Inc.
- *
- * based on the old aacraid driver that is..
- * Adaptec aacraid device driver for Linux.
  *
  * Copyright (c) 2000-2010 Adaptec, Inc.
  *               2010-2015 PMC-Sierra, Inc. (aacraid@pmc-sierra.com)
  *		 2016-2017 Microsemi Corp. (aacraid@microsemi.com)
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- * Module Name:
- *  aachba.c
- *
- * Abstract: Contains Interfaces to manage IOs.
  *
  */
 
-- 
2.20.1

Re: [PATCH 2/2] staging: aacraid: remove boilerplate license text

[Greg KH]

On Fri, Mar 08, 2019 at 08:23:28PM +0000, Jules Irenge wrote:
> Remove boilerplate license text.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/scsi/aacraid/aachba.c | 23 -----------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> index 955ddb32aa40..e70b45a74d0a 100644
> --- a/drivers/scsi/aacraid/aachba.c
> +++ b/drivers/scsi/aacraid/aachba.c
> @@ -1,33 +1,10 @@
>  // SPDX-License-Identifier: GPL-2.0+
>  /*
> - *	Adaptec AAC series RAID controller driver
> - *	(c) Copyright 2001 Red Hat Inc.
> - *
> - * based on the old aacraid driver that is..
> - * Adaptec aacraid device driver for Linux.

Those lines are not "boilerplate license text" :(

In fact, one of those lines is a copyright line, and lawyers get _VERY_
upset when you delete them (despite them not really meaning much, but
that's a different discussion...)

>   *
>   * Copyright (c) 2000-2010 Adaptec, Inc.
>   *               2010-2015 PMC-Sierra, Inc. (aacraid@pmc-sierra.com)
>   *		 2016-2017 Microsemi Corp. (aacraid@microsemi.com)
>   *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2, or (at your option)
> - * any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; see the file COPYING.  If not, write to
> - * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.

These three paragraphs are what is "boilerplate license text", that is
good to remove.


> - *
> - * Module Name:
> - *  aachba.c
> - *
> - * Abstract: Contains Interfaces to manage IOs.

Those lines are not boilerplate.

thanks,

greg k-h

Re: [PATCH 1/2] staging: aacraid: add SPDX GPL-2.0+ license identifier

[Greg KH]

On Fri, Mar 08, 2019 at 08:23:27PM +0000, Jules Irenge wrote:
> Add the SPDX GPL-2.0+ license identifier to fix checkpatch.pl warning
> Issue found by checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/scsi/aacraid/aachba.c | 1 +
>  1 file changed, 1 insertion(+)

Wait, why are you touching files outside of drivers/staging/?  I can't
do anything with a patch like this during the application process :(

Please stick to drivers/staging/ unless you are already working with a
mentor.

thanks,

greg k-h

Re: [PATCH 2/2] staging: aacraid: remove boilerplate license text

[Jules Octave]

[-- Attachment #1: Type: text/plain, Size: 2430 bytes --]

On Sat, 9 Mar 2019 at 07:07, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Mar 08, 2019 at 08:23:28PM +0000, Jules Irenge wrote:
> > Remove boilerplate license text.
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> >  drivers/scsi/aacraid/aachba.c | 23 -----------------------
> >  1 file changed, 23 deletions(-)
> >
> > diff --git a/drivers/scsi/aacraid/aachba.c
> b/drivers/scsi/aacraid/aachba.c
> > index 955ddb32aa40..e70b45a74d0a 100644
> > --- a/drivers/scsi/aacraid/aachba.c
> > +++ b/drivers/scsi/aacraid/aachba.c
> > @@ -1,33 +1,10 @@
> >  // SPDX-License-Identifier: GPL-2.0+
> >  /*
> > - *   Adaptec AAC series RAID controller driver
> > - *   (c) Copyright 2001 Red Hat Inc.
> > - *
> > - * based on the old aacraid driver that is..
> > - * Adaptec aacraid device driver for Linux.
>
> >Those lines are not "boilerplate license text" :(
>
> >In fact, one of those lines is a copyright line, and lawyers get _VERY_
> >upset when you delete them (despite them not really meaning much, but
> >that's a different discussion...)
>

Thanks for letting me know. I take good note.


>
> >   *
> >   * Copyright (c) 2000-2010 Adaptec, Inc.
> >   *               2010-2015 PMC-Sierra, Inc. (aacraid@pmc-sierra.com)
> >   *            2016-2017 Microsemi Corp. (aacraid@microsemi.com)
> >   *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License as published by
> > - * the Free Software Foundation; either version 2, or (at your option)
> > - * any later version.
> > - *
> > - * This program is distributed in the hope that it will be useful,
> > - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > - * GNU General Public License for more details.
> > - *
> > - * You should have received a copy of the GNU General Public License
> > - * along with this program; see the file COPYING.  If not, write to
> > - * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
>
> >These three paragraphs are what is "boilerplate license text", that is
> >good to remove.
>
>
> > - *
> > - * Module Name:
> > - *  aachba.c
> > - *
> > - * Abstract: Contains Interfaces to manage IOs.
>
> >Those lines are not boilerplate.
>
> >thanks,
>
>
Thanks for the above information. I will stick on staging

Kind regards,
Jules

[-- Attachment #2: Type: text/html, Size: 4107 bytes --]