* [Buildroot] [PATCH 1/1] package/gnuradio: add optional log4cpp dependency
@ 2019-03-08 21:39 Fabrice Fontaine
2019-03-09 14:07 ` Thomas Petazzoni
2019-03-25 16:26 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-03-08 21:39 UTC (permalink / raw)
To: buildroot
Currently, logger component is enabled if log4cpp is found
Moreover, it should be noted that log4cpp is now mandatory in latest
upstream:
https://github.com/gnuradio/gnuradio/commit/d2428961205bf62e6b39966f040f98435e5cc2ed
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/gnuradio/Config.in | 6 ++++++
package/gnuradio/gnuradio.mk | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index 3fdaea850e..6d0669779f 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -56,6 +56,12 @@ config BR2_PACKAGE_GNURADIO_FEC
help
FEC signal processing blocks
+config BR2_PACKAGE_GNURADIO_LOG
+ bool "gr-log support"
+ select BR2_PACKAGE_LOG4CPP
+ help
+ Enable logger component
+
config BR2_PACKAGE_GNURADIO_PYTHON
bool "python support"
depends on BR2_PACKAGE_PYTHON
diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 202c2213a7..ef9723cb01 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -115,6 +115,13 @@ else
GNURADIO_CONF_OPTS += -DENABLE_GR_FILTER=OFF
endif
+ifeq ($(BR2_PACKAGE_GNURADIO_LOG),y)
+GNURADIO_DEPENDENCIES += log4cpp
+GNURADIO_CONF_OPTS += -DENABLE_GR_LOG=ON
+else
+GNURADIO_CONF_OPTS += -DENABLE_GR_LOG=OFF
+endif
+
ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
GNURADIO_DEPENDENCIES += python
GNURADIO_CONF_OPTS += -DENABLE_PYTHON=ON
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/gnuradio: add optional log4cpp dependency
2019-03-08 21:39 [Buildroot] [PATCH 1/1] package/gnuradio: add optional log4cpp dependency Fabrice Fontaine
@ 2019-03-09 14:07 ` Thomas Petazzoni
2019-03-25 16:26 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-09 14:07 UTC (permalink / raw)
To: buildroot
On Fri, 8 Mar 2019 22:39:56 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Currently, logger component is enabled if log4cpp is found
>
> Moreover, it should be noted that log4cpp is now mandatory in latest
> upstream:
> https://github.com/gnuradio/gnuradio/commit/d2428961205bf62e6b39966f040f98435e5cc2ed
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/gnuradio/Config.in | 6 ++++++
> package/gnuradio/gnuradio.mk | 7 +++++++
> 2 files changed, 13 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/gnuradio: add optional log4cpp dependency
2019-03-08 21:39 [Buildroot] [PATCH 1/1] package/gnuradio: add optional log4cpp dependency Fabrice Fontaine
2019-03-09 14:07 ` Thomas Petazzoni
@ 2019-03-25 16:26 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-03-25 16:26 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Currently, logger component is enabled if log4cpp is found
> Moreover, it should be noted that log4cpp is now mandatory in latest
> upstream:
> https://github.com/gnuradio/gnuradio/commit/d2428961205bf62e6b39966f040f98435e5cc2ed
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 21:39 [Buildroot] [PATCH 1/1] package/gnuradio: add optional log4cpp dependency Fabrice Fontaine
2019-03-09 14:07 ` Thomas Petazzoni
2019-03-25 16:26 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.