All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: media: zoran: remove unnecessary parentheses
       [not found] <20190309160705.51339-1-himadri18.07@gmail.com>
@ 2019-03-09 17:37 ` Himadri Pandya
  2019-03-09 17:44   ` [Outreachy kernel] " Julia Lawall
  2019-03-09 17:51   ` [PATCH v2] " Himadri Pandya
  0 siblings, 2 replies; 3+ messages in thread
From: Himadri Pandya @ 2019-03-09 17:37 UTC (permalink / raw)
  To: mchehab, gregkh; +Cc: outreachy-kernel, Himadri Pandya

Remove unnecessary parentheses from right hand side of
assignments.Suggested by Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
 drivers/staging/media/zoran/zoran_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 40adceebca7e..c27e1472b7a8 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -496,7 +496,7 @@ zr36057_overlay (struct zoran *zr,
 				KERN_ERR
 				"%s: zr36057_overlay() - video_stride not aligned\n",
 				ZR_DEVNAME(zr));
-		reg = (reg << ZR36057_VSSFGR_DispStride);
+		reg = reg << ZR36057_VSSFGR_DispStride;
 		reg |= ZR36057_VSSFGR_VidOvf;	/* clear overflow status */
 		btwrite(reg, ZR36057_VSSFGR);
 
@@ -1421,7 +1421,7 @@ zoran_irq (int             irq,
 					reg = 0;
 					if (zr->v4l_settings.height > BUZ_MAX_HEIGHT / 2)
 						reg += zr->v4l_settings.bytesperline;
-					reg = (reg << ZR36057_VSSFGR_DispStride);
+					reg = reg << ZR36057_VSSFGR_DispStride;
 					reg |= ZR36057_VSSFGR_VidOvf;
 					reg |= ZR36057_VSSFGR_SnapShot;
 					reg |= ZR36057_VSSFGR_FrameGrab;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: media: zoran: remove unnecessary parentheses
  2019-03-09 17:37 ` [PATCH] staging: media: zoran: remove unnecessary parentheses Himadri Pandya
@ 2019-03-09 17:44   ` Julia Lawall
  2019-03-09 17:51   ` [PATCH v2] " Himadri Pandya
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-03-09 17:44 UTC (permalink / raw)
  To: Himadri Pandya; +Cc: mchehab, gregkh, outreachy-kernel



On Sat, 9 Mar 2019, Himadri Pandya wrote:

> Remove unnecessary parentheses from right hand side of
> assignments.Suggested by Coccinelle.

Put a space after the period.

It seems that this driver is on the way out of the kernel, so it may not
be worth working on it further.

git log --oneline drivers/staging/media/zoran/zoran_device.c

julia

>
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
>  drivers/staging/media/zoran/zoran_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
> index 40adceebca7e..c27e1472b7a8 100644
> --- a/drivers/staging/media/zoran/zoran_device.c
> +++ b/drivers/staging/media/zoran/zoran_device.c
> @@ -496,7 +496,7 @@ zr36057_overlay (struct zoran *zr,
>  				KERN_ERR
>  				"%s: zr36057_overlay() - video_stride not aligned\n",
>  				ZR_DEVNAME(zr));
> -		reg = (reg << ZR36057_VSSFGR_DispStride);
> +		reg = reg << ZR36057_VSSFGR_DispStride;
>  		reg |= ZR36057_VSSFGR_VidOvf;	/* clear overflow status */
>  		btwrite(reg, ZR36057_VSSFGR);
>
> @@ -1421,7 +1421,7 @@ zoran_irq (int             irq,
>  					reg = 0;
>  					if (zr->v4l_settings.height > BUZ_MAX_HEIGHT / 2)
>  						reg += zr->v4l_settings.bytesperline;
> -					reg = (reg << ZR36057_VSSFGR_DispStride);
> +					reg = reg << ZR36057_VSSFGR_DispStride;
>  					reg |= ZR36057_VSSFGR_VidOvf;
>  					reg |= ZR36057_VSSFGR_SnapShot;
>  					reg |= ZR36057_VSSFGR_FrameGrab;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190309173734.51405-1-himadri18.07%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH v2] staging: media: zoran: remove unnecessary parentheses
  2019-03-09 17:37 ` [PATCH] staging: media: zoran: remove unnecessary parentheses Himadri Pandya
  2019-03-09 17:44   ` [Outreachy kernel] " Julia Lawall
@ 2019-03-09 17:51   ` Himadri Pandya
  1 sibling, 0 replies; 3+ messages in thread
From: Himadri Pandya @ 2019-03-09 17:51 UTC (permalink / raw)
  To: mchehab, gregkh; +Cc: outreachy-kernel, Himadri Pandya

Remove unnecessary parentheses from right hand side of
assignments. Suggested by Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
---
Changes in V2:
	- Add space after period in log message
---
 drivers/staging/media/zoran/zoran_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 40adceebca7e..c27e1472b7a8 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -496,7 +496,7 @@ zr36057_overlay (struct zoran *zr,
 				KERN_ERR
 				"%s: zr36057_overlay() - video_stride not aligned\n",
 				ZR_DEVNAME(zr));
-		reg = (reg << ZR36057_VSSFGR_DispStride);
+		reg = reg << ZR36057_VSSFGR_DispStride;
 		reg |= ZR36057_VSSFGR_VidOvf;	/* clear overflow status */
 		btwrite(reg, ZR36057_VSSFGR);
 
@@ -1421,7 +1421,7 @@ zoran_irq (int             irq,
 					reg = 0;
 					if (zr->v4l_settings.height > BUZ_MAX_HEIGHT / 2)
 						reg += zr->v4l_settings.bytesperline;
-					reg = (reg << ZR36057_VSSFGR_DispStride);
+					reg = reg << ZR36057_VSSFGR_DispStride;
 					reg |= ZR36057_VSSFGR_VidOvf;
 					reg |= ZR36057_VSSFGR_SnapShot;
 					reg |= ZR36057_VSSFGR_FrameGrab;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-09 17:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190309160705.51339-1-himadri18.07@gmail.com>
2019-03-09 17:37 ` [PATCH] staging: media: zoran: remove unnecessary parentheses Himadri Pandya
2019-03-09 17:44   ` [Outreachy kernel] " Julia Lawall
2019-03-09 17:51   ` [PATCH v2] " Himadri Pandya

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.