From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: deepa.kernel@gmail.com, willemb@google.com,
linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
sparclinux@vger.kernel.org, labbott@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] y2038: fix socket.h header inclusion
Date: Mon, 11 Mar 2019 11:23:32 -0700 (PDT) [thread overview]
Message-ID: <20190311.112332.2212718467104899802.davem@davemloft.net> (raw)
In-Reply-To: <20190311153857.563743-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 11 Mar 2019 16:38:17 +0100
> Referencing the __kernel_long_t type caused some user space applications
> to stop compiling when they had not already included linux/posix_types.h,
> e.g.
>
> s/multicast.c -o ext/sockets/multicast.lo
> In file included from /builddir/build/BUILD/php-7.3.3/main/php.h:468,
> from /builddir/build/BUILD/php-7.3.3/ext/sockets/sockets.c:27:
> /builddir/build/BUILD/php-7.3.3/ext/sockets/sockets.c: In function 'zm_startup_sockets':
> /builddir/build/BUILD/php-7.3.3/ext/sockets/sockets.c:776:40: error: '__kernel_long_t' undeclared (first use in this function)
> 776 | REGISTER_LONG_CONSTANT("SO_SNDTIMEO", SO_SNDTIMEO, CONST_CS | CONST_PERSISTENT);
>
> It is safe to include that header here, since it only contains kernel
> internal types that do not conflict with other user space types.
>
> It's still possible that some related build failures remain, but those
> are likely to be for code that is not already y2038 safe.
>
> Reported-by: Laura Abbott <labbott@redhat.com>
> Fixes: a9beb86ae6e5 ("sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: deepa.kernel@gmail.com, willemb@google.com,
linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
sparclinux@vger.kernel.org, labbott@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] y2038: fix socket.h header inclusion
Date: Mon, 11 Mar 2019 18:23:32 +0000 [thread overview]
Message-ID: <20190311.112332.2212718467104899802.davem@davemloft.net> (raw)
In-Reply-To: <20190311153857.563743-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 11 Mar 2019 16:38:17 +0100
> Referencing the __kernel_long_t type caused some user space applications
> to stop compiling when they had not already included linux/posix_types.h,
> e.g.
>
> s/multicast.c -o ext/sockets/multicast.lo
> In file included from /builddir/build/BUILD/php-7.3.3/main/php.h:468,
> from /builddir/build/BUILD/php-7.3.3/ext/sockets/sockets.c:27:
> /builddir/build/BUILD/php-7.3.3/ext/sockets/sockets.c: In function 'zm_startup_sockets':
> /builddir/build/BUILD/php-7.3.3/ext/sockets/sockets.c:776:40: error: '__kernel_long_t' undeclared (first use in this function)
> 776 | REGISTER_LONG_CONSTANT("SO_SNDTIMEO", SO_SNDTIMEO, CONST_CS | CONST_PERSISTENT);
>
> It is safe to include that header here, since it only contains kernel
> internal types that do not conflict with other user space types.
>
> It's still possible that some related build failures remain, but those
> are likely to be for code that is not already y2038 safe.
>
> Reported-by: Laura Abbott <labbott@redhat.com>
> Fixes: a9beb86ae6e5 ("sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
next prev parent reply other threads:[~2019-03-11 18:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:38 [PATCH] y2038: fix socket.h header inclusion Arnd Bergmann
2019-03-11 15:38 ` Arnd Bergmann
2019-03-11 18:23 ` David Miller [this message]
2019-03-11 18:23 ` David Miller
2019-03-14 18:37 ` Florian Weimer
2019-03-14 18:37 ` Florian Weimer
2019-03-15 20:30 ` Arnd Bergmann
2019-03-15 20:30 ` Arnd Bergmann
2019-03-15 21:20 ` Florian Weimer
2019-03-15 21:20 ` Florian Weimer
2019-03-17 18:20 ` Deepa Dinamani
2019-03-17 18:20 ` Deepa Dinamani
2019-03-18 8:27 ` Arnd Bergmann
2019-03-18 8:27 ` Arnd Bergmann
2019-03-18 9:21 ` Florian Weimer
2019-03-18 9:21 ` Florian Weimer
2019-03-18 12:56 ` Arnd Bergmann
2019-03-18 12:56 ` Arnd Bergmann
2019-03-18 13:12 ` Florian Weimer
2019-03-18 13:12 ` Florian Weimer
2019-03-18 13:12 ` Florian Weimer
2019-03-18 14:34 ` Arnd Bergmann
2019-03-18 14:34 ` Arnd Bergmann
2019-03-18 14:34 ` Arnd Bergmann
2019-03-18 14:37 ` Florian Weimer
2019-03-18 14:37 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311.112332.2212718467104899802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=labbott@redhat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.