From: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> To: <linux-pci@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org> Cc: Bjorn Helgaas <helgaas@kernel.org>, <linux@yadro.com>, Sergey Miroshnichenko <s.miroshnichenko@yadro.com> Subject: [PATCH RFC v4 09/21] PCI: Mark immovable BARs with PCI_FIXED Date: Mon, 11 Mar 2019 16:31:10 +0300 [thread overview] Message-ID: <20190311133122.11417-10-s.miroshnichenko@yadro.com> (raw) In-Reply-To: <20190311133122.11417-1-s.miroshnichenko@yadro.com> If a PCIe device driver doesn't yet have support for movable BARs, mark device's BARs with IORESOURCE_PCI_FIXED. Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> --- drivers/pci/probe.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index dc935f82a595..1cf6ec960236 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -3262,6 +3262,21 @@ static void pci_bus_rescan_prepare(struct pci_bus *bus) } else if (dev->driver && dev->driver->rescan_prepare) { dev->driver->rescan_prepare(dev); + } else if (dev->driver || ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA)) { + int i; + + for (i = 0; i < PCI_NUM_RESOURCES; i++) { + struct resource *r = &dev->resource[i]; + + if (!r->flags || !r->parent || + (r->flags & IORESOURCE_UNSET) || + (r->flags & IORESOURCE_PCI_FIXED)) + continue; + + r->flags |= IORESOURCE_PCI_FIXED; + pci_warn(dev, "%s: no support for movable BARs, mark BAR %d (%pR) as fixed\n", + __func__, i, r); + } } } } -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> To: <linux-pci@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org> Cc: Sergey Miroshnichenko <s.miroshnichenko@yadro.com>, Bjorn Helgaas <helgaas@kernel.org>, linux@yadro.com Subject: [PATCH RFC v4 09/21] PCI: Mark immovable BARs with PCI_FIXED Date: Mon, 11 Mar 2019 16:31:10 +0300 [thread overview] Message-ID: <20190311133122.11417-10-s.miroshnichenko@yadro.com> (raw) In-Reply-To: <20190311133122.11417-1-s.miroshnichenko@yadro.com> If a PCIe device driver doesn't yet have support for movable BARs, mark device's BARs with IORESOURCE_PCI_FIXED. Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> --- drivers/pci/probe.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index dc935f82a595..1cf6ec960236 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -3262,6 +3262,21 @@ static void pci_bus_rescan_prepare(struct pci_bus *bus) } else if (dev->driver && dev->driver->rescan_prepare) { dev->driver->rescan_prepare(dev); + } else if (dev->driver || ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA)) { + int i; + + for (i = 0; i < PCI_NUM_RESOURCES; i++) { + struct resource *r = &dev->resource[i]; + + if (!r->flags || !r->parent || + (r->flags & IORESOURCE_UNSET) || + (r->flags & IORESOURCE_PCI_FIXED)) + continue; + + r->flags |= IORESOURCE_PCI_FIXED; + pci_warn(dev, "%s: no support for movable BARs, mark BAR %d (%pR) as fixed\n", + __func__, i, r); + } } } } -- 2.20.1
next prev parent reply other threads:[~2019-03-11 13:31 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-11 13:31 [PATCH RFC v4 00/21] PCI: Allow BAR movement during hotplug Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 01/21] PCI: Fix writing invalid BARs during pci_restore_state() Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 14:02 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 02/21] PCI: Fix race condition in pci_enable/disable_device() Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 19:00 ` Bjorn Helgaas 2019-03-26 19:00 ` Bjorn Helgaas 2019-03-27 17:11 ` Sergey Miroshnichenko 2019-03-27 17:11 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 03/21] PCI: Enable bridge's I/O and MEM access for hotplugged devices Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 19:13 ` Bjorn Helgaas 2019-03-27 17:13 ` Sergey Miroshnichenko 2019-03-27 17:13 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 04/21] PCI: Define PCI-specific version of the release_child_resources() Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 05/21] PCI: hotplug: Add a flag for the movable BARs feature Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 19:24 ` Bjorn Helgaas 2019-03-27 17:16 ` Sergey Miroshnichenko 2019-03-27 17:16 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 06/21] PCI: Pause the devices with movable BARs during rescan Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 07/21] PCI: Wake up bridges during rescan when movable BARs enabled Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 19:28 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 08/21] nvme-pci: Handle movable BARs Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 20:20 ` Bjorn Helgaas 2019-03-26 20:20 ` Bjorn Helgaas 2019-03-26 20:20 ` Bjorn Helgaas 2019-03-27 17:30 ` Sergey Miroshnichenko 2019-03-27 17:30 ` Sergey Miroshnichenko 2019-03-27 17:30 ` Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko [this message] 2019-03-11 13:31 ` [PATCH RFC v4 09/21] PCI: Mark immovable BARs with PCI_FIXED Sergey Miroshnichenko 2019-03-26 20:28 ` Bjorn Helgaas 2019-03-27 17:03 ` David Laight 2019-03-27 17:39 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 10/21] PCI: Fix assigning of fixed prefetchable resources Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 20:37 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 11/21] PCI: Release and reassign the root bridge resources during rescan Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 20:41 ` Bjorn Helgaas 2019-03-27 17:40 ` Sergey Miroshnichenko 2019-03-27 17:40 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 12/21] PCI: Don't allow hotplugged devices to steal resources Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 20:55 ` Bjorn Helgaas 2019-03-27 18:02 ` Sergey Miroshnichenko 2019-03-27 18:02 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 13/21] PCI: Include fixed BARs into the bus size calculating Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 14/21] PCI: Don't reserve memory for hotplug when enabled movable BARs Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 20:57 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 15/21] PCI: Allow the failed resources to be reassigned later Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 20:58 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 16/21] PCI: Calculate fixed areas of bridge windows based on fixed BARs Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 17/21] PCI: Calculate boundaries for bridge windows Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 21:01 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 18/21] PCI: Make sure bridge windows include their fixed BARs Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 19/21] PCI: Prioritize fixed BAR assigning over the movable ones Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-11 13:31 ` [PATCH RFC v4 20/21] PCI: pciehp: Add support for the movable BARs feature Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko 2019-03-26 21:11 ` Bjorn Helgaas 2019-03-11 13:31 ` [PATCH RFC v4 21/21] powerpc/pci: Fix crash with enabled movable BARs Sergey Miroshnichenko 2019-03-11 13:31 ` Sergey Miroshnichenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190311133122.11417-10-s.miroshnichenko@yadro.com \ --to=s.miroshnichenko@yadro.com \ --cc=helgaas@kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux@yadro.com \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.