* Re: [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:37 ` Mao Wenan
@ 2019-03-11 14:35 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-03-11 14:35 UTC (permalink / raw)
To: Mao Wenan
Cc: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
@ 2019-03-11 14:35 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-03-11 14:35 UTC (permalink / raw)
To: Mao Wenan
Cc: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:35 ` Dan Carpenter
@ 2019-03-11 14:37 ` Mao Wenan
-1 siblings, 0 replies; 6+ messages in thread
From: Mao Wenan @ 2019-03-11 14:37 UTC (permalink / raw)
To: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
There is no need to have the 'T *v' variable static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v1->v2: remove additional space character between resource_size_t and res_len.
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
index 6098f43ac51b..93d6ea48915b 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
@@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
struct media_entity *me = &sd->entity;
- static resource_size_t res_len;
+ resource_size_t res_len;
struct resource *res;
int ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
@ 2019-03-11 14:37 ` Mao Wenan
0 siblings, 0 replies; 6+ messages in thread
From: Mao Wenan @ 2019-03-11 14:37 UTC (permalink / raw)
To: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
There is no need to have the 'T *v' variable static
since new value always be assigned before use it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v1->v2: remove additional space character between resource_size_t and res_len.
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
index 6098f43ac51b..93d6ea48915b 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c
@@ -1881,7 +1881,7 @@ int vpfe_resizer_init(struct vpfe_resizer_device *vpfe_rsz,
struct v4l2_subdev *sd = &vpfe_rsz->crop_resizer.subdev;
struct media_pad *pads = &vpfe_rsz->crop_resizer.pads[0];
struct media_entity *me = &sd->entity;
- static resource_size_t res_len;
+ resource_size_t res_len;
struct resource *res;
int ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
2019-03-11 14:35 ` Dan Carpenter
@ 2019-03-15 12:15 ` maowenan
-1 siblings, 0 replies; 6+ messages in thread
From: maowenan @ 2019-03-15 12:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
Ping...
Thank you.
On 2019/3/11 22:35, Dan Carpenter wrote:
> Thanks!
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()
@ 2019-03-15 12:15 ` maowenan
0 siblings, 0 replies; 6+ messages in thread
From: maowenan @ 2019-03-15 12:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: gregkh, Julia.Lawall, kimbrownkd, colin.king, hans.verkuil,
linux-media, devel, kernel-janitors
Ping...
Thank you.
On 2019/3/11 22:35, Dan Carpenter wrote:
> Thanks!
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-15 12:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 14:37 [PATCH v2] staging: davinci: drop pointless static qualifier in vpfe_resizer_init() Mao Wenan
2019-03-11 14:37 ` Mao Wenan
2019-03-11 14:35 ` Dan Carpenter
2019-03-11 14:35 ` Dan Carpenter
2019-03-15 12:15 ` maowenan
2019-03-15 12:15 ` maowenan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.