* [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file
@ 2019-03-11 15:01 Wentao Cai
2019-03-11 15:01 ` [PATCH 1/5] Staging: most: cdev: Replace '--help--' with 'help' Wentao Cai
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Wentao Cai @ 2019-03-11 15:01 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Wentao Cai
Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Wentao Cai (5):
Staging: most: cdev: Replace '--help--' with 'help'
Staging: most: i2c: Replace '--help--' in Kconfig
Staging: most: net: Replace '--help--' in Kconfig
Staging: most: sound: Replace '--help--' in Kconfig file
Staging: most: video: Replace '--help--' in Kconfig
drivers/staging/most/cdev/Kconfig | 2 +-
drivers/staging/most/i2c/Kconfig | 2 +-
drivers/staging/most/net/Kconfig | 2 +-
drivers/staging/most/sound/Kconfig | 2 +-
drivers/staging/most/video/Kconfig | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/5] Staging: most: cdev: Replace '--help--' with 'help'
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
@ 2019-03-11 15:01 ` Wentao Cai
2019-03-11 15:01 ` [PATCH 2/5] Staging: most: i2c: Replace '--help--' in Kconfig Wentao Cai
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Wentao Cai @ 2019-03-11 15:01 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Wentao Cai
Replace '--help--' with 'help' in Kconfig to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
drivers/staging/most/cdev/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/cdev/Kconfig b/drivers/staging/most/cdev/Kconfig
index 2b04e26bcbea..2e27e1fce58d 100644
--- a/drivers/staging/most/cdev/Kconfig
+++ b/drivers/staging/most/cdev/Kconfig
@@ -5,7 +5,7 @@
config MOST_CDEV
tristate "Cdev"
- ---help---
+ help
Say Y here if you want to commumicate via character devices.
To compile this driver as a module, choose M here: the
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/5] Staging: most: i2c: Replace '--help--' in Kconfig
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
2019-03-11 15:01 ` [PATCH 1/5] Staging: most: cdev: Replace '--help--' with 'help' Wentao Cai
@ 2019-03-11 15:01 ` Wentao Cai
2019-03-11 15:01 ` [PATCH 3/5] Staging: most: net: " Wentao Cai
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Wentao Cai @ 2019-03-11 15:01 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Wentao Cai
Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
drivers/staging/most/i2c/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/i2c/Kconfig b/drivers/staging/most/i2c/Kconfig
index 79d0ff27f56d..f723f99711bd 100644
--- a/drivers/staging/most/i2c/Kconfig
+++ b/drivers/staging/most/i2c/Kconfig
@@ -5,7 +5,7 @@
config MOST_I2C
tristate "I2C"
depends on I2C
- ---help---
+ help
Say Y here if you want to connect via I2C to network tranceiver.
To compile this driver as a module, choose M here: the
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/5] Staging: most: net: Replace '--help--' in Kconfig
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
2019-03-11 15:01 ` [PATCH 1/5] Staging: most: cdev: Replace '--help--' with 'help' Wentao Cai
2019-03-11 15:01 ` [PATCH 2/5] Staging: most: i2c: Replace '--help--' in Kconfig Wentao Cai
@ 2019-03-11 15:01 ` Wentao Cai
2019-03-11 15:01 ` [PATCH 4/5] Staging: most: sound: Replace '--help--' in Kconfig file Wentao Cai
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Wentao Cai @ 2019-03-11 15:01 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Wentao Cai
Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
drivers/staging/most/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/net/Kconfig b/drivers/staging/most/net/Kconfig
index 795330ba94ef..28040931f7e7 100644
--- a/drivers/staging/most/net/Kconfig
+++ b/drivers/staging/most/net/Kconfig
@@ -6,7 +6,7 @@ config MOST_NET
tristate "Net"
depends on NET
- ---help---
+ help
Say Y here if you want to commumicate via a networking device.
To compile this driver as a module, choose M here: the
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/5] Staging: most: sound: Replace '--help--' in Kconfig file
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
` (2 preceding siblings ...)
2019-03-11 15:01 ` [PATCH 3/5] Staging: most: net: " Wentao Cai
@ 2019-03-11 15:01 ` Wentao Cai
2019-03-11 15:01 ` [PATCH 5/5] Staging: most: video: Replace '--help--' in Kconfig Wentao Cai
2019-03-11 15:05 ` [Outreachy kernel] [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Julia Lawall
5 siblings, 0 replies; 8+ messages in thread
From: Wentao Cai @ 2019-03-11 15:01 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Wentao Cai
Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
drivers/staging/most/sound/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/sound/Kconfig b/drivers/staging/most/sound/Kconfig
index 115262a58a42..5614a999b54e 100644
--- a/drivers/staging/most/sound/Kconfig
+++ b/drivers/staging/most/sound/Kconfig
@@ -6,7 +6,7 @@ config MOST_SOUND
tristate "Sound"
depends on SND
select SND_PCM
- ---help---
+ help
Say Y here if you want to commumicate via ALSA/sound devices.
To compile this driver as a module, choose M here: the
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/5] Staging: most: video: Replace '--help--' in Kconfig
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
` (3 preceding siblings ...)
2019-03-11 15:01 ` [PATCH 4/5] Staging: most: sound: Replace '--help--' in Kconfig file Wentao Cai
@ 2019-03-11 15:01 ` Wentao Cai
2019-03-11 15:05 ` [Outreachy kernel] [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Julia Lawall
5 siblings, 0 replies; 8+ messages in thread
From: Wentao Cai @ 2019-03-11 15:01 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Wentao Cai
Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
---
drivers/staging/most/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/video/Kconfig b/drivers/staging/most/video/Kconfig
index ce6af4f951a6..a458d0c74a0f 100644
--- a/drivers/staging/most/video/Kconfig
+++ b/drivers/staging/most/video/Kconfig
@@ -5,7 +5,7 @@
config MOST_VIDEO
tristate "Video"
depends on VIDEO_V4L2
- ---help---
+ help
Say Y here if you want to commumicate via Video 4 Linux.
To compile this driver as a module, choose M here: the
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
` (4 preceding siblings ...)
2019-03-11 15:01 ` [PATCH 5/5] Staging: most: video: Replace '--help--' in Kconfig Wentao Cai
@ 2019-03-11 15:05 ` Julia Lawall
2019-03-11 15:10 ` etsai042
5 siblings, 1 reply; 8+ messages in thread
From: Julia Lawall @ 2019-03-11 15:05 UTC (permalink / raw)
To: Wentao Cai; +Cc: gregkh, outreachy-kernel
On Mon, 11 Mar 2019, Wentao Cai wrote:
> Replace '--help--' with 'help' to silence checkpatch.pl warning:
> WARNING: prefer 'help' over '---help---' for new help texts
>
> Wentao Cai (5):
> Staging: most: cdev: Replace '--help--' with 'help'
> Staging: most: i2c: Replace '--help--' in Kconfig
> Staging: most: net: Replace '--help--' in Kconfig
> Staging: most: sound: Replace '--help--' in Kconfig file
> Staging: most: video: Replace '--help--' in Kconfig
I guess that you are doing the same thing in all cases. So it wold be
reasonable for the subjects to all be the same. You have the subdirectory
in each case to make them different.
It could also just be one patch, since the change is easy to understand in
each case.
julia
>
> drivers/staging/most/cdev/Kconfig | 2 +-
> drivers/staging/most/i2c/Kconfig | 2 +-
> drivers/staging/most/net/Kconfig | 2 +-
> drivers/staging/most/sound/Kconfig | 2 +-
> drivers/staging/most/video/Kconfig | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190311150108.4717-1-etsai042%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file
2019-03-11 15:05 ` [Outreachy kernel] [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Julia Lawall
@ 2019-03-11 15:10 ` etsai042
0 siblings, 0 replies; 8+ messages in thread
From: etsai042 @ 2019-03-11 15:10 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]
On Monday, March 11, 2019 at 8:05:17 AM UTC-7, Julia Lawall wrote:
>
>
> >I guess that you are doing the same thing in all cases. So it wold be
> >reasonable for the subjects to all be the same. You have the
> subdirectory
> >in each case to make them different.
>
> >It could also just be one patch, since the change is easy to understand
> in
> >each case.
>
> >julia
>
>
Thanks Julia, I'll resubmit them in one patch.
Wentao
[-- Attachment #1.2: Type: text/html, Size: 687 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-11 15:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 15:01 [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Wentao Cai
2019-03-11 15:01 ` [PATCH 1/5] Staging: most: cdev: Replace '--help--' with 'help' Wentao Cai
2019-03-11 15:01 ` [PATCH 2/5] Staging: most: i2c: Replace '--help--' in Kconfig Wentao Cai
2019-03-11 15:01 ` [PATCH 3/5] Staging: most: net: " Wentao Cai
2019-03-11 15:01 ` [PATCH 4/5] Staging: most: sound: Replace '--help--' in Kconfig file Wentao Cai
2019-03-11 15:01 ` [PATCH 5/5] Staging: most: video: Replace '--help--' in Kconfig Wentao Cai
2019-03-11 15:05 ` [Outreachy kernel] [PATCH 0/5] Staging: most: Replace '--help--' in Kconfig file Julia Lawall
2019-03-11 15:10 ` etsai042
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.