From: Jason Andryuk <jandryuk@gmail.com> To: qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, marmarek@invisiblethingslab.com, Jason Andryuk <jandryuk@gmail.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul.durrant@citrix.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Subject: [Qemu-devel] [PATCH 3/6] xen: Skip backend initialization for stubdom Date: Mon, 11 Mar 2019 14:02:13 -0400 [thread overview] Message-ID: <20190311180216.18811-4-jandryuk@gmail.com> (raw) In-Reply-To: <20190311180216.18811-1-jandryuk@gmail.com> When QEMU is running in a stubdom, it does not provide any Paravirtualized backends. Those still run in dom0 or another driver domain. Therefore we skip backend initialization (xen_bus_init and xen_be_init) for the stubdom case. Original patch by Anthony PERARD <anthony.perard@citrix.com> Signed-off-by: Jason Andryuk <jandryuk@gmail.com> --- hw/i386/xen/xen-hvm.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index c20c4b27f6..4b62f070cb 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -1485,8 +1485,6 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) QLIST_INIT(&state->dev_list); device_listener_register(&state->device_listener); - xen_bus_init(); - xenstore = xs_open(0); if (!xenstore) { error_report("Can't connect to xenstored"); @@ -1495,12 +1493,16 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL); - /* Initialize backend core & drivers */ - if (xen_be_init() != 0) { - error_report("xen backend core setup failed"); - goto err; + if (!xen_stubdom_enabled()) { + xen_bus_init(); + + /* Initialize backend core & drivers */ + if (xen_be_init() != 0) { + error_report("xen backend core setup failed"); + goto err; + } + xen_be_register_common(); } - xen_be_register_common(); QLIST_INIT(&xen_physmap); xen_read_physmap(state); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Andryuk <jandryuk@gmail.com> To: qemu-devel@nongnu.org Cc: Stefano Stabellini <sstabellini@kernel.org>, Eduardo Habkost <ehabkost@redhat.com>, Jason Andryuk <jandryuk@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, marmarek@invisiblethingslab.com, Paul Durrant <paul.durrant@citrix.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Richard Henderson <rth@twiddle.net> Subject: [PATCH 3/6] xen: Skip backend initialization for stubdom Date: Mon, 11 Mar 2019 14:02:13 -0400 [thread overview] Message-ID: <20190311180216.18811-4-jandryuk@gmail.com> (raw) In-Reply-To: <20190311180216.18811-1-jandryuk@gmail.com> When QEMU is running in a stubdom, it does not provide any Paravirtualized backends. Those still run in dom0 or another driver domain. Therefore we skip backend initialization (xen_bus_init and xen_be_init) for the stubdom case. Original patch by Anthony PERARD <anthony.perard@citrix.com> Signed-off-by: Jason Andryuk <jandryuk@gmail.com> --- hw/i386/xen/xen-hvm.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index c20c4b27f6..4b62f070cb 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -1485,8 +1485,6 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) QLIST_INIT(&state->dev_list); device_listener_register(&state->device_listener); - xen_bus_init(); - xenstore = xs_open(0); if (!xenstore) { error_report("Can't connect to xenstored"); @@ -1495,12 +1493,16 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL); - /* Initialize backend core & drivers */ - if (xen_be_init() != 0) { - error_report("xen backend core setup failed"); - goto err; + if (!xen_stubdom_enabled()) { + xen_bus_init(); + + /* Initialize backend core & drivers */ + if (xen_be_init() != 0) { + error_report("xen backend core setup failed"); + goto err; + } + xen_be_register_common(); } - xen_be_register_common(); QLIST_INIT(&xen_physmap); xen_read_physmap(state); -- 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-11 18:03 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-11 18:02 [Qemu-devel] [PATCH 0/6] Xen stubdom support Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-11 18:02 ` [Qemu-devel] [PATCH 1/6] xen: Introduce -xen-stubdom option Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-11 18:06 ` [Qemu-devel] " Paolo Bonzini 2019-03-11 18:06 ` Paolo Bonzini 2019-03-11 19:46 ` [Qemu-devel] " Jason Andryuk 2019-03-11 19:46 ` Jason Andryuk 2019-03-11 18:02 ` [Qemu-devel] [PATCH 2/6] xen: Move xenstore initialization to common location Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-13 15:01 ` Paul Durrant 2019-03-13 18:11 ` Jason Andryuk 2019-03-14 14:00 ` Paul Durrant 2019-03-11 18:02 ` Jason Andryuk [this message] 2019-03-11 18:02 ` [PATCH 3/6] xen: Skip backend initialization for stubdom Jason Andryuk 2019-03-13 15:04 ` Paul Durrant 2019-03-11 18:02 ` [Qemu-devel] [PATCH 4/6] xen: Set HVM_PARAM_DM_DOMAIN for stubdom on older Xen Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-11 18:02 ` [Qemu-devel] [PATCH 5/6] xen-pt: Hide MSI-X from xen stubdoms Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-12 12:04 ` Roger Pau Monné 2019-03-12 12:38 ` Marek Marczykowski-Górecki 2019-03-12 13:58 ` Jason Andryuk 2019-03-12 14:13 ` Roger Pau Monné 2019-03-12 15:15 ` Jason Andryuk 2019-03-13 2:15 ` Jason Andryuk 2019-03-12 14:29 ` Marek Marczykowski-Górecki 2019-03-11 18:02 ` [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Jason Andryuk 2019-03-11 18:02 ` Jason Andryuk 2019-03-13 15:09 ` Paul Durrant 2019-03-14 18:15 ` Jason Andryuk 2019-03-14 19:22 ` Simon Gaiser 2019-03-14 19:37 ` Andrew Cooper 2019-03-15 9:12 ` Paul Durrant 2019-03-14 20:45 ` Simon Gaiser 2019-03-15 9:17 ` Paul Durrant 2019-03-15 16:28 ` Andrew Cooper 2019-03-20 17:28 ` Jason Andryuk 2019-03-22 3:09 ` Roger Pau Monné 2019-03-22 19:43 ` Jason Andryuk 2020-01-13 19:01 ` [Xen-devel] " Jason Andryuk 2020-01-13 19:01 ` Jason Andryuk 2020-01-14 10:04 ` Roger Pau Monné 2020-01-14 10:04 ` Roger Pau Monné 2020-01-14 14:41 ` Jason Andryuk 2020-01-14 14:41 ` Jason Andryuk 2020-01-14 18:04 ` Roger Pau Monné 2020-01-14 18:04 ` Roger Pau Monné 2020-01-15 8:33 ` Durrant, Paul 2020-01-15 8:33 ` Durrant, Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190311180216.18811-4-jandryuk@gmail.com \ --to=jandryuk@gmail.com \ --cc=anthony.perard@citrix.com \ --cc=ehabkost@redhat.com \ --cc=marcel.apfelbaum@gmail.com \ --cc=marmarek@invisiblethingslab.com \ --cc=mst@redhat.com \ --cc=paul.durrant@citrix.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.