* [PATCH v5 2/2] staging: fbtft: ternary statement to if statement.
@ 2019-03-09 15:41 Bhagyashri Dighole
2019-03-11 23:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Bhagyashri Dighole @ 2019-03-09 15:41 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Outreachy
Convert a ternary statement into a if statement which is detected while
resolving "WARNING: line over 80 characters".
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
---
Changes in v5:
- Make patch series.
Changes in v4:
- Convert a ternary statement into a if statement.
Changes in v3:
- Make the code in original form.
- Use tab to line up the code.
Changes in v2:
- Improve code order.
- Make the code more readable.
drivers/staging/fbtft/fb_ssd1306.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
index d7c5e2e..3e1426c 100644
--- a/drivers/staging/fbtft/fb_ssd1306.c
+++ b/drivers/staging/fbtft/fb_ssd1306.c
@@ -184,7 +184,10 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
for (y = 0; y < yres / 8; y++) {
*buf = 0x00;
for (i = 0; i < 8; i++)
- *buf |= (vmem16[(y * 8 + i) * xres + x] ? 1 : 0) << i;
+ if (vmem16[(y * 8 + i) * xres + x])
+ *buf |= 1 << i;
+ else
+ *buf |= 0 << i;
buf++;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v5 2/2] staging: fbtft: ternary statement to if statement.
2019-03-09 15:41 [PATCH v5 2/2] staging: fbtft: ternary statement to if statement Bhagyashri Dighole
@ 2019-03-11 23:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-11 23:08 UTC (permalink / raw)
To: Bhagyashri Dighole; +Cc: Outreachy
On Sat, Mar 09, 2019 at 09:11:45PM +0530, Bhagyashri Dighole wrote:
> Convert a ternary statement into a if statement which is detected while
> resolving "WARNING: line over 80 characters".
>
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
> Changes in v5:
> - Make patch series.
>
> Changes in v4:
> - Convert a ternary statement into a if statement.
>
> Changes in v3:
> - Make the code in original form.
> - Use tab to line up the code.
>
> Changes in v2:
> - Improve code order.
> - Make the code more readable.
>
> drivers/staging/fbtft/fb_ssd1306.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
> index d7c5e2e..3e1426c 100644
> --- a/drivers/staging/fbtft/fb_ssd1306.c
> +++ b/drivers/staging/fbtft/fb_ssd1306.c
> @@ -184,7 +184,10 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> for (y = 0; y < yres / 8; y++) {
> *buf = 0x00;
> for (i = 0; i < 8; i++)
> - *buf |= (vmem16[(y * 8 + i) * xres + x] ? 1 : 0) << i;
> + if (vmem16[(y * 8 + i) * xres + x])
> + *buf |= 1 << i;
> + else
> + *buf |= 0 << i;
Think about what this last line does. Is it really needed? :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-09 15:41 [PATCH v5 2/2] staging: fbtft: ternary statement to if statement Bhagyashri Dighole
2019-03-11 23:08 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.