* [PATCH] staging: mt7621-pci: IF statement expression comparing to NULL
@ 2019-03-12 16:29 Branden Bonaby
2019-03-12 18:06 ` [PATCH v2] " Branden Bonaby
0 siblings, 1 reply; 3+ messages in thread
From: Branden Bonaby @ 2019-03-12 16:29 UTC (permalink / raw)
Cc: Branden Bonaby, outreachy-kernel
Remove comparison to NULL in the if statement expression
to match the Linux Kernel coding style.
CHECK: Comparison to NULL could be written "res"
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index 379ae780c691..03d919a94552 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -275,7 +275,7 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct mt7621_pcie *pcie)
break;
}
- if (res != NULL)
+ if (res)
of_pci_range_to_resource(&range, node, res);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] staging: mt7621-pci: IF statement expression comparing to NULL
2019-03-12 16:29 [PATCH] staging: mt7621-pci: IF statement expression comparing to NULL Branden Bonaby
@ 2019-03-12 18:06 ` Branden Bonaby
2019-03-13 12:34 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Branden Bonaby @ 2019-03-12 18:06 UTC (permalink / raw)
To: gregkh, matthias.bgg; +Cc: Branden Bonaby, outreachy-kernel
Remove comparison to NULL in the if statement expression
to match the Linux Kernel coding style.
CHECK: Comparison to NULL could be written "res"
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
---
Changes in v2
sent email commit to correct driver maintainers
drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
index 379ae780c691..03d919a94552 100644
--- a/drivers/staging/mt7621-pci/pci-mt7621.c
+++ b/drivers/staging/mt7621-pci/pci-mt7621.c
@@ -275,7 +275,7 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct mt7621_pcie *pcie)
break;
}
- if (res != NULL)
+ if (res)
of_pci_range_to_resource(&range, node, res);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: mt7621-pci: IF statement expression comparing to NULL
2019-03-12 18:06 ` [PATCH v2] " Branden Bonaby
@ 2019-03-13 12:34 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2019-03-13 12:34 UTC (permalink / raw)
To: Branden Bonaby, gregkh; +Cc: outreachy-kernel
On 12/03/2019 19:06, Branden Bonaby wrote:
> Remove comparison to NULL in the if statement expression
> to match the Linux Kernel coding style.
> CHECK: Comparison to NULL could be written "res"
>
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> Changes in v2
> sent email commit to correct driver maintainers
>
> drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index 379ae780c691..03d919a94552 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -275,7 +275,7 @@ static int mt7621_pci_parse_request_of_pci_ranges(struct mt7621_pcie *pcie)
> break;
> }
>
> - if (res != NULL)
> + if (res)
> of_pci_range_to_resource(&range, node, res);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-13 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 16:29 [PATCH] staging: mt7621-pci: IF statement expression comparing to NULL Branden Bonaby
2019-03-12 18:06 ` [PATCH v2] " Branden Bonaby
2019-03-13 12:34 ` Matthias Brugger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.