From: "Alastair D'Silva" <alastair@au1.ibm.com> To: unlisted-recipients:; (no To-header on input) Cc: "Alastair D'Silva" <alastair@d-silva.org>, Greg Kurz <groug@kaod.org>, Frederic Barrat <fbarrat@linux.ibm.com>, Andrew Donnellan <andrew.donnellan@au1.ibm.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void Date: Wed, 13 Mar 2019 15:06:59 +1100 [thread overview] Message-ID: <20190313040702.14276-4-alastair@au1.ibm.com> (raw) In-Reply-To: <20190313040702.14276-1-alastair@au1.ibm.com> From: Alastair D'Silva <alastair@d-silva.org> No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Reviewed-by: Greg Kurz <groug@kaod.org> --- drivers/misc/ocxl/config.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c index 0ee7856b033d..026ac2ac4f9c 100644 --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx) return 0; } -static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) +static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) { u16 val; int pos; @@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) out: dev_dbg(&dev->dev, "PASID capability:\n"); dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log); - return 0; } static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn) @@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn) { int rc; - rc = read_pasid(dev, fn); - if (rc) { - dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc); - return -ENODEV; - } + read_pasid(dev, fn); rc = read_dvsec_tl(dev, fn); if (rc) { -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Alastair D'Silva" <alastair@au1.ibm.com> Cc: Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Greg Kurz <groug@kaod.org>, linux-kernel@vger.kernel.org, Andrew Donnellan <andrew.donnellan@au1.ibm.com>, Alastair D'Silva <alastair@d-silva.org>, Frederic Barrat <fbarrat@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void Date: Wed, 13 Mar 2019 15:06:59 +1100 [thread overview] Message-ID: <20190313040702.14276-4-alastair@au1.ibm.com> (raw) In-Reply-To: <20190313040702.14276-1-alastair@au1.ibm.com> From: Alastair D'Silva <alastair@d-silva.org> No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Reviewed-by: Greg Kurz <groug@kaod.org> --- drivers/misc/ocxl/config.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c index 0ee7856b033d..026ac2ac4f9c 100644 --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx) return 0; } -static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) +static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) { u16 val; int pos; @@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) out: dev_dbg(&dev->dev, "PASID capability:\n"); dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log); - return 0; } static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn) @@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn) { int rc; - rc = read_pasid(dev, fn); - if (rc) { - dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc); - return -ENODEV; - } + read_pasid(dev, fn); rc = read_dvsec_tl(dev, fn); if (rc) { -- 2.20.1
next prev parent reply other threads:[~2019-03-13 4:08 UTC|newest] Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-27 4:57 [PATCH 0/5] ocxl: OpenCAPI Cleanup Alastair D'Silva 2019-02-27 4:57 ` Alastair D'Silva 2019-02-27 4:57 ` [PATCH 1/5] ocxl: Rename struct link to ocxl_link Alastair D'Silva 2019-02-27 4:57 ` Alastair D'Silva 2019-02-27 7:15 ` Andrew Donnellan 2019-02-27 7:15 ` Andrew Donnellan 2019-02-27 7:34 ` Alastair D'Silva 2019-02-27 7:34 ` Alastair D'Silva 2019-02-27 7:54 ` Andrew Donnellan 2019-02-27 7:54 ` Andrew Donnellan 2019-02-27 8:04 ` Alastair D'Silva 2019-02-27 8:04 ` Alastair D'Silva 2019-02-27 8:18 ` Andrew Donnellan 2019-02-27 8:18 ` Andrew Donnellan 2019-02-27 13:45 ` Frederic Barrat 2019-02-27 13:45 ` Frederic Barrat 2019-02-27 13:59 ` Greg Kurz 2019-02-27 13:59 ` Greg Kurz 2019-02-27 13:53 ` Greg Kurz 2019-02-27 13:53 ` Greg Kurz 2019-02-27 4:57 ` [PATCH 2/5] ocxl: Clean up printf formats Alastair D'Silva 2019-02-27 4:57 ` Alastair D'Silva 2019-02-27 13:40 ` Frederic Barrat 2019-02-27 13:40 ` Frederic Barrat 2019-02-28 5:02 ` Andrew Donnellan 2019-02-28 5:02 ` Andrew Donnellan 2019-03-02 1:13 ` Joe Perches 2019-03-02 1:13 ` Joe Perches 2019-02-27 4:57 ` [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void Alastair D'Silva 2019-02-27 4:57 ` Alastair D'Silva 2019-02-27 13:25 ` Frederic Barrat 2019-02-27 13:25 ` Frederic Barrat 2019-02-28 5:03 ` Andrew Donnellan 2019-02-28 5:03 ` Andrew Donnellan 2019-02-27 4:57 ` [PATCH 4/5] ocxl: Remove superfluous 'extern' from headers Alastair D'Silva 2019-02-27 4:57 ` Alastair D'Silva 2019-02-27 13:36 ` Frederic Barrat 2019-02-27 13:36 ` Frederic Barrat 2019-02-28 5:05 ` Andrew Donnellan 2019-02-28 5:05 ` Andrew Donnellan 2019-02-27 4:57 ` [PATCH 5/5] ocxl: Remove some unused exported symbols Alastair D'Silva 2019-02-27 4:57 ` Alastair D'Silva 2019-02-27 13:39 ` Frederic Barrat 2019-02-27 13:39 ` Frederic Barrat 2019-02-28 5:23 ` Andrew Donnellan 2019-02-28 5:23 ` Andrew Donnellan 2019-03-13 4:06 ` [PATCH v2 0/5] ocxl: OpenCAPI Cleanup Alastair D'Silva 2019-03-13 4:06 ` Alastair D'Silva 2019-03-13 4:06 ` [PATCH 1/5] ocxl: Rename struct link to ocxl_link Alastair D'Silva 2019-03-13 4:06 ` Alastair D'Silva 2019-03-15 6:58 ` Andrew Donnellan 2019-03-15 6:58 ` Andrew Donnellan 2019-03-13 4:06 ` [PATCH 2/5] ocxl: Clean up printf formats Alastair D'Silva 2019-03-13 4:06 ` Alastair D'Silva 2019-03-13 8:24 ` Greg Kurz 2019-03-14 4:58 ` Andrew Donnellan 2019-03-14 4:58 ` Andrew Donnellan 2019-03-13 4:06 ` Alastair D'Silva [this message] 2019-03-13 4:06 ` [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void Alastair D'Silva 2019-03-14 4:59 ` Andrew Donnellan 2019-03-14 4:59 ` Andrew Donnellan 2019-03-13 4:07 ` [PATCH 4/5] ocxl: Remove superfluous 'extern' from headers Alastair D'Silva 2019-03-13 4:07 ` Alastair D'Silva 2019-03-13 8:28 ` Greg Kurz 2019-03-14 5:08 ` Andrew Donnellan 2019-03-14 5:08 ` Andrew Donnellan 2019-03-13 4:07 ` [PATCH 5/5] ocxl: Remove some unused exported symbols Alastair D'Silva 2019-03-13 4:07 ` Alastair D'Silva 2019-03-13 9:10 ` Greg Kurz 2019-03-14 2:23 ` Alastair D'Silva 2019-03-14 6:50 ` Greg Kurz 2019-03-15 4:49 ` Andrew Donnellan 2019-03-15 4:49 ` Andrew Donnellan 2019-03-15 5:07 ` Andrew Donnellan 2019-03-15 5:07 ` Andrew Donnellan 2019-03-20 5:34 ` [PATCH v3 0/5] ocxl: OpenCAPI Cleanup Alastair D'Silva 2019-03-20 5:34 ` Alastair D'Silva 2019-03-20 5:34 ` [PATCH v3 1/5] ocxl: Rename struct link to ocxl_link Alastair D'Silva 2019-03-20 5:34 ` Alastair D'Silva 2019-03-20 5:34 ` [PATCH v3 2/5] ocxl: Clean up printf formats Alastair D'Silva 2019-03-20 5:34 ` Alastair D'Silva 2019-03-20 17:24 ` Joe Perches 2019-03-20 17:24 ` Joe Perches 2019-03-20 5:34 ` [PATCH v3 3/5] ocxl: read_pasid never returns an error, so make it void Alastair D'Silva 2019-03-20 5:34 ` Alastair D'Silva 2019-03-20 5:34 ` [PATCH v3 4/5] ocxl: Remove superfluous 'extern' from headers Alastair D'Silva 2019-03-20 5:34 ` Alastair D'Silva 2019-03-20 5:34 ` [PATCH v3 5/5] ocxl: Remove some unused exported symbols Alastair D'Silva 2019-03-20 5:34 ` Alastair D'Silva 2019-03-25 5:34 ` [PATCH v4 0/4] ocxl: OpenCAPI Cleanup Alastair D'Silva 2019-03-25 5:34 ` Alastair D'Silva 2019-03-25 5:34 ` [PATCH v4 1/4] ocxl: Rename struct link to ocxl_link Alastair D'Silva 2019-03-25 5:34 ` Alastair D'Silva 2019-04-03 14:18 ` Frederic Barrat 2019-04-03 14:18 ` Frederic Barrat 2019-04-05 7:05 ` Andrew Donnellan 2019-04-05 7:05 ` Andrew Donnellan 2019-05-03 6:59 ` Michael Ellerman 2019-03-25 5:34 ` [PATCH v4 2/4] ocxl: read_pasid never returns an error, so make it void Alastair D'Silva 2019-03-25 5:34 ` Alastair D'Silva 2019-04-03 14:20 ` Frederic Barrat 2019-04-03 14:20 ` Frederic Barrat 2019-04-05 7:05 ` Andrew Donnellan 2019-04-05 7:05 ` Andrew Donnellan 2019-03-25 5:34 ` [PATCH v4 3/4] ocxl: Remove superfluous 'extern' from headers Alastair D'Silva 2019-03-25 5:34 ` Alastair D'Silva 2019-03-25 16:55 ` Greg Kurz 2019-03-25 16:55 ` Greg Kurz 2019-04-03 14:20 ` Frederic Barrat 2019-04-03 14:20 ` Frederic Barrat 2019-04-05 7:09 ` Andrew Donnellan 2019-04-05 7:09 ` Andrew Donnellan 2019-03-25 5:34 ` [PATCH v4 4/4] ocxl: Remove some unused exported symbols Alastair D'Silva 2019-03-25 5:34 ` Alastair D'Silva 2019-03-25 16:57 ` Greg Kurz 2019-03-25 16:57 ` Greg Kurz 2019-04-03 14:23 ` Frederic Barrat 2019-04-03 14:23 ` Frederic Barrat 2019-04-05 7:28 ` Andrew Donnellan 2019-04-05 7:28 ` Andrew Donnellan 2019-03-25 16:49 ` [PATCH v4 0/4] ocxl: OpenCAPI Cleanup Greg Kurz 2019-03-25 16:49 ` Greg Kurz 2019-03-25 17:34 ` Frederic Barrat 2019-03-25 17:34 ` Frederic Barrat 2019-03-25 21:45 ` Alastair D'Silva 2019-03-25 21:45 ` Alastair D'Silva 2019-03-25 5:44 ` [PATCH v3 0/7] Refactor OCXL driver to allow external drivers to use it Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 5:44 ` [PATCH v3 1/7] ocxl: Split pci.c Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 10:01 ` Frederic Barrat 2019-03-25 10:01 ` Frederic Barrat 2019-03-25 5:44 ` [PATCH v3 2/7] ocxl: Don't pass pci_dev around Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 10:04 ` Frederic Barrat 2019-03-25 10:04 ` Frederic Barrat 2019-03-25 5:44 ` [PATCH v3 3/7] ocxl: Create a clear delineation between ocxl backend & frontend Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 15:11 ` Frederic Barrat 2019-03-25 15:11 ` Frederic Barrat 2019-03-25 5:44 ` [PATCH v3 4/7] ocxl: Allow external drivers to use OpenCAPI contexts Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 15:13 ` Frederic Barrat 2019-03-25 15:13 ` Frederic Barrat 2019-03-25 5:44 ` [PATCH v3 5/7] ocxl: afu_irq only deals with IRQ IDs, not offsets Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 15:24 ` Frederic Barrat 2019-03-25 15:24 ` Frederic Barrat 2019-03-25 5:44 ` [PATCH v3 6/7] ocxl: move event_fd handling to frontend Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 15:41 ` Frederic Barrat 2019-03-25 15:41 ` Frederic Barrat 2019-03-25 5:44 ` [PATCH v3 7/7] ocxl: Provide global MMIO accessors for external drivers Alastair D'Silva 2019-03-25 5:44 ` Alastair D'Silva 2019-03-25 15:49 ` Frederic Barrat 2019-03-25 15:49 ` Frederic Barrat
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190313040702.14276-4-alastair@au1.ibm.com \ --to=alastair@au1.ibm.com \ --cc=alastair@d-silva.org \ --cc=andrew.donnellan@au1.ibm.com \ --cc=arnd@arndb.de \ --cc=fbarrat@linux.ibm.com \ --cc=gregkh@linuxfoundation.org \ --cc=groug@kaod.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.