All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>, Dave Young <dyoung@redhat.com>
Cc: linux-integrity@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test
Date: Wed, 13 Mar 2019 11:14:36 +0100	[thread overview]
Message-ID: <20190313101436.GB25643@dell5510> (raw)
In-Reply-To: <1552409474.24794.63.camel@linux.ibm.com>

Hi Mimi, Dave,

> > Frankly I did not read and followup much about the testing code changes,
> > not sure if it is doable or not.  The code sharing under testing folder
> > seems not very good.  For example the basic check_root is needed by
> > different parts, but all have its own implementation.  Anyway this is
> > not the duty of this patch set.
> > Also the selftests/lib/ is not a folder for sharing code for different
> > tests, it looks a standalone test instead.
Yes. Thus lib/ folder name is a bit confusing.

> Shuah suggested upstreaming these tests first and defer introducing a
> common set of functions to later.
Make sense.

> > So if split kexec tests to another folder is not doable please just
> > ignore the comment.

> Left in the selftests/ima is a similar test for kernel modules, which
> uses the "common" functions.  So either we wait to move the kexec
> tests or allow them to reach into the ima directory and use the
> ima_common_lib functions.
I guess just load ima_common_lib.sh for now would be good enough.
@Dave: BTW I has starting to work on kselftest common library.
I thought I'd spent some time on it before posting it, but I might even send
the small part I've done so far so we can discuss it.

> > BTW, does CONFIG_KEXEC* is checked?  in case a kernel without KEXEC or
> > KEXEC_FILE compiled in then the tests can just return directly.

> Good point.  Now that there is a common function for reading the
> Kconfig, I'll add that check to both the test_kexec_load.sh and
> test_kexec_file_load.sh tests respectively.

> Mimi


Kind regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: pvorel at suse.cz (Petr Vorel)
Subject: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test
Date: Wed, 13 Mar 2019 11:14:36 +0100	[thread overview]
Message-ID: <20190313101436.GB25643@dell5510> (raw)
In-Reply-To: <1552409474.24794.63.camel@linux.ibm.com>

Hi Mimi, Dave,

> > Frankly I did not read and followup much about the testing code changes,
> > not sure if it is doable or not.  The code sharing under testing folder
> > seems not very good.  For example the basic check_root is needed by
> > different parts, but all have its own implementation.  Anyway this is
> > not the duty of this patch set.
> > Also the selftests/lib/ is not a folder for sharing code for different
> > tests, it looks a standalone test instead.
Yes. Thus lib/ folder name is a bit confusing.

> Shuah suggested upstreaming these tests first and defer introducing a
> common set of functions to later.
Make sense.

> > So if split kexec tests to another folder is not doable please just
> > ignore the comment.

> Left in the selftests/ima is a similar test for kernel modules, which
> uses the "common" functions.  So either we wait to move the kexec
> tests or allow them to reach into the ima directory and use the
> ima_common_lib functions.
I guess just load ima_common_lib.sh for now would be good enough.
@Dave: BTW I has starting to work on kselftest common library.
I thought I'd spent some time on it before posting it, but I might even send
the small part I've done so far so we can discuss it.

> > BTW, does CONFIG_KEXEC* is checked?  in case a kernel without KEXEC or
> > KEXEC_FILE compiled in then the tests can just return directly.

> Good point.  Now that there is a common function for reading the
> Kconfig, I'll add that check to both the test_kexec_load.sh and
> test_kexec_file_load.sh tests respectively.

> Mimi


Kind regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: pvorel@suse.cz (Petr Vorel)
Subject: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test
Date: Wed, 13 Mar 2019 11:14:36 +0100	[thread overview]
Message-ID: <20190313101436.GB25643@dell5510> (raw)
Message-ID: <20190313101436.XLNn8ZN_-7k52vZSc3KSG6mz5rK-nM9Pen72aC93T78@z> (raw)
In-Reply-To: <1552409474.24794.63.camel@linux.ibm.com>

Hi Mimi, Dave,

> > Frankly I did not read and followup much about the testing code changes,
> > not sure if it is doable or not.  The code sharing under testing folder
> > seems not very good.  For example the basic check_root is needed by
> > different parts, but all have its own implementation.  Anyway this is
> > not the duty of this patch set.
> > Also the selftests/lib/ is not a folder for sharing code for different
> > tests, it looks a standalone test instead.
Yes. Thus lib/ folder name is a bit confusing.

> Shuah suggested upstreaming these tests first and defer introducing a
> common set of functions to later.
Make sense.

> > So if split kexec tests to another folder is not doable please just
> > ignore the comment.

> Left in the selftests/ima is a similar test for kernel modules, which
> uses the "common" functions.  So either we wait to move the kexec
> tests or allow them to reach into the ima directory and use the
> ima_common_lib functions.
I guess just load ima_common_lib.sh for now would be good enough.
@Dave: BTW I has starting to work on kselftest common library.
I thought I'd spent some time on it before posting it, but I might even send
the small part I've done so far so we can discuss it.

> > BTW, does CONFIG_KEXEC* is checked?  in case a kernel without KEXEC or
> > KEXEC_FILE compiled in then the tests can just return directly.

> Good point.  Now that there is a common function for reading the
> Kconfig, I'll add that check to both the test_kexec_load.sh and
> test_kexec_file_load.sh tests respectively.

> Mimi


Kind regards,
Petr

  reply	other threads:[~2019-03-13 10:14 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 11:41 [PATCH v3 0/7] selftests/ima: add kexec and kernel module tests Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 11:41 ` [PATCH v3 1/7] selftests/ima: cleanup the kexec selftest Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-11 11:41 ` [PATCH v3 2/7] selftests/ima: define a set of common functions Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-11 21:39   ` Petr Vorel
2019-03-11 21:39     ` Petr Vorel
2019-03-11 21:39     ` Petr Vorel
2019-03-11 21:39     ` pvorel
2019-03-11 11:41 ` [PATCH v3 3/7] selftests/ima: define common logging functions Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-11 11:41 ` [PATCH v3 4/7] kselftest/ima: define "require_root_privileges" Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-11 11:41 ` [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-12 12:10   ` Dave Young
2019-03-12 12:10     ` Dave Young
2019-03-12 12:10     ` Dave Young
2019-03-12 12:10     ` dyoung
2019-03-12 16:51     ` Mimi Zohar
2019-03-12 16:51       ` Mimi Zohar
2019-03-12 16:51       ` Mimi Zohar
2019-03-12 16:51       ` zohar
2019-03-13 10:14       ` Petr Vorel [this message]
2019-03-13 10:14         ` Petr Vorel
2019-03-13 10:14         ` pvorel
2019-03-14 18:38         ` Mimi Zohar
2019-03-14 18:38           ` Mimi Zohar
2019-03-14 18:38           ` zohar
2019-03-11 11:41 ` [PATCH v3 6/7] selftests/ima: loading kernel modules Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-11 11:41 ` [PATCH v3 7/7] selftests/ima: Add missing '=y' to config options Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` Mimi Zohar
2019-03-11 11:41   ` zohar
2019-03-11 21:51 ` [PATCH v3 0/7] selftests/ima: add kexec and kernel module tests Petr Vorel
2019-03-11 21:51   ` Petr Vorel
2019-03-11 21:51   ` Petr Vorel
2019-03-11 21:51   ` pvorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190313101436.GB25643@dell5510 \
    --to=pvorel@suse.cz \
    --cc=dyoung@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.