[PATCH] ALSA: hda - add more quirks for HP Z2 G4 and HP Z240

[PATCH] ALSA: hda - add more quirks for HP Z2 G4 and HP Z240

[Jaroslav Kysela]

From: Jaroslav Kysela <jkysela@redhat.com>

Apply the HP_MIC_NO_PRESENCE fixups for the more HP Z2 G4 and
HP Z240 models.

Reported-by: Jeff Burrell <jeff.burrell@hp.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---
 sound/pci/hda/patch_conexant.c | 3 +++
 sound/pci/hda/patch_realtek.c  | 6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index a4ee7656d9ee..fb65ad31e86c 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -936,6 +936,9 @@ static const struct snd_pci_quirk cxt5066_fixups[] = {
 	SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x8455, "HP Z2 G4", CXT_FIXUP_HP_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x103c, 0x8456, "HP Z2 G4 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x103c, 0x8457, "HP Z2 G4 mini", CXT_FIXUP_HP_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x103c, 0x8458, "HP Z2 G4 mini premium", CXT_FIXUP_HP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1043, 0x138d, "Asus", CXT_FIXUP_HEADPHONE_MIC_PIN),
 	SND_PCI_QUIRK(0x152d, 0x0833, "OLPC XO-1.5", CXT_FIXUP_OLPC_XO),
 	SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400", CXT_PINCFG_LENOVO_TP410),
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c8413d44973c..476c3ee31dc8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6764,11 +6764,13 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x2336, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x2337, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
 	SND_PCI_QUIRK(0x103c, 0x221c, "HP EliteBook 755 G2", ALC280_FIXUP_HP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x103c, 0x802e, "HP Z240 SFF", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x103c, 0x802f, "HP Z240", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
 	SND_PCI_QUIRK(0x103c, 0x8256, "HP", ALC221_FIXUP_HP_FRONT_MIC),
 	SND_PCI_QUIRK(0x103c, 0x827e, "HP x360", ALC295_FIXUP_HP_X360),
-	SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
-	SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x103c, 0x82bf, "HP G3 mini", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
+	SND_PCI_QUIRK(0x103c, 0x82c0, "HP G3 mini premium", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
 	SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
 	SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
-- 
2.20.1

Re: [PATCH] ALSA: hda - add more quirks for HP Z2 G4 and HP Z240

[Takashi Iwai]

On Wed, 13 Mar 2019 13:40:15 +0100,
Jaroslav Kysela wrote:
> 
> From: Jaroslav Kysela <jkysela@redhat.com>
> 
> Apply the HP_MIC_NO_PRESENCE fixups for the more HP Z2 G4 and
> HP Z240 models.
> 
> Reported-by: Jeff Burrell <jeff.burrell@hp.com>
> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

Thanks, I'm going to apply it with Cc to stable.
BTW, would you like to keep your sign-off with @perex.cz while the
author is @redhat.com?  Or is it just an overlook?


thanks,

Takashi

Re: [PATCH] ALSA: hda - add more quirks for HP Z2 G4 and HP Z240

[Jaroslav Kysela]

Dne 13. 03. 19 v 14:26 Takashi Iwai napsal(a):
> On Wed, 13 Mar 2019 13:40:15 +0100,
> Jaroslav Kysela wrote:
>>
>> From: Jaroslav Kysela <jkysela@redhat.com>
>>
>> Apply the HP_MIC_NO_PRESENCE fixups for the more HP Z2 G4 and
>> HP Z240 models.
>>
>> Reported-by: Jeff Burrell <jeff.burrell@hp.com>
>> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
> 
> Thanks, I'm going to apply it with Cc to stable.
> BTW, would you like to keep your sign-off with @perex.cz while the
> author is @redhat.com?  Or is it just an overlook?

It's just an overlook. It should be perex@perex.cz for all. Thanks.

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Re: [PATCH] ALSA: hda - add more quirks for HP Z2 G4 and HP Z240

[Takashi Iwai]

On Wed, 13 Mar 2019 14:34:04 +0100,
Jaroslav Kysela wrote:
> 
> Dne 13. 03. 19 v 14:26 Takashi Iwai napsal(a):
> > On Wed, 13 Mar 2019 13:40:15 +0100,
> > Jaroslav Kysela wrote:
> >>
> >> From: Jaroslav Kysela <jkysela@redhat.com>
> >>
> >> Apply the HP_MIC_NO_PRESENCE fixups for the more HP Z2 G4 and
> >> HP Z240 models.
> >>
> >> Reported-by: Jeff Burrell <jeff.burrell@hp.com>
> >> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
> > 
> > Thanks, I'm going to apply it with Cc to stable.
> > BTW, would you like to keep your sign-off with @perex.cz while the
> > author is @redhat.com?  Or is it just an overlook?
> 
> It's just an overlook. It should be perex@perex.cz for all. Thanks.

OK, I applied it as @perex.cz now.


Takashi