* arch/x86/events/intel/core.c:4145:1: sparse: symbol 'dev_attr_allow_tsx_force_abort' was not declared. Should it be static?
@ 2019-03-13 18:42 kbuild test robot
2019-03-13 18:42 ` [RFC PATCH linus] perf/x86/intel: dev_attr_allow_tsx_force_abort can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-03-13 18:42 UTC (permalink / raw)
To: Peter Zijlstra (Intel)
Cc: kbuild-all, linux-kernel, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin, x86, Kan Liang, Jiri Olsa,
Andi Kleen
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5453a3df2a5eb49bc24615d4cf0d66b2aae05e5f
commit: 400816f60c543153656ac74eaf7f36f6b7202378 perf/x86/intel: Implement support for TSX Force Abort
date: 7 days ago
reproduce:
# apt-get install sparse
git checkout 400816f60c543153656ac74eaf7f36f6b7202378
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH linus] perf/x86/intel: dev_attr_allow_tsx_force_abort can be static
2019-03-13 18:42 arch/x86/events/intel/core.c:4145:1: sparse: symbol 'dev_attr_allow_tsx_force_abort' was not declared. Should it be static? kbuild test robot
@ 2019-03-13 18:42 ` kbuild test robot
2019-03-17 7:43 ` [tip:perf/urgent] perf/x86/intel: Make dev_attr_allow_tsx_force_abort static tip-bot for kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-03-13 18:42 UTC (permalink / raw)
To: Peter Zijlstra (Intel)
Cc: kbuild-all, linux-kernel, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin, x86, Kan Liang, Jiri Olsa,
Andi Kleen
Fixes: 400816f60c54 ("perf/x86/intel: Implement support for TSX Force Abort")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index 35102ec..baa7a2e 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -4179,7 +4179,7 @@ static struct attribute *intel_pmu_caps_attrs[] = {
NULL
};
-DEVICE_BOOL_ATTR(allow_tsx_force_abort, 0644, allow_tsx_force_abort);
+static DEVICE_BOOL_ATTR(allow_tsx_force_abort, 0644, allow_tsx_force_abort);
static struct attribute *intel_pmu_attrs[] = {
&dev_attr_freeze_on_smi.attr,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:perf/urgent] perf/x86/intel: Make dev_attr_allow_tsx_force_abort static
2019-03-13 18:42 ` [RFC PATCH linus] perf/x86/intel: dev_attr_allow_tsx_force_abort can be static kbuild test robot
@ 2019-03-17 7:43 ` tip-bot for kbuild test robot
0 siblings, 0 replies; 3+ messages in thread
From: tip-bot for kbuild test robot @ 2019-03-17 7:43 UTC (permalink / raw)
To: linux-tip-commits
Cc: jolsa, ak, lkp, peterz, hpa, kan.liang, bp, tglx, mingo, linux-kernel
Commit-ID: c634dc6bdedeb0b2c750fc611612618a85639ab2
Gitweb: https://git.kernel.org/tip/c634dc6bdedeb0b2c750fc611612618a85639ab2
Author: kbuild test robot <lkp@intel.com>
AuthorDate: Thu, 14 Mar 2019 02:42:43 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 17 Mar 2019 08:40:18 +0100
perf/x86/intel: Make dev_attr_allow_tsx_force_abort static
Fixes: 400816f60c54 ("perf/x86/intel: Implement support for TSX Force Abort")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: kbuild-all@01.org
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20190313184243.GA10820@lkp-sb-ep06
---
arch/x86/events/intel/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index 92dfeb343a6a..8baa441d8000 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -4179,7 +4179,7 @@ static struct attribute *intel_pmu_caps_attrs[] = {
NULL
};
-DEVICE_BOOL_ATTR(allow_tsx_force_abort, 0644, allow_tsx_force_abort);
+static DEVICE_BOOL_ATTR(allow_tsx_force_abort, 0644, allow_tsx_force_abort);
static struct attribute *intel_pmu_attrs[] = {
&dev_attr_freeze_on_smi.attr,
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-17 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 18:42 arch/x86/events/intel/core.c:4145:1: sparse: symbol 'dev_attr_allow_tsx_force_abort' was not declared. Should it be static? kbuild test robot
2019-03-13 18:42 ` [RFC PATCH linus] perf/x86/intel: dev_attr_allow_tsx_force_abort can be static kbuild test robot
2019-03-17 7:43 ` [tip:perf/urgent] perf/x86/intel: Make dev_attr_allow_tsx_force_abort static tip-bot for kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.