* [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation
2019-03-14 12:26 [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
@ 2019-03-14 12:26 ` Paul Cercueil
2019-03-28 15:39 ` Rob Herring
2019-03-14 12:26 ` [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Paul Cercueil
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Paul Cercueil @ 2019-03-14 12:26 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, Mark Rutland
Cc: od, dri-devel, devicetree, linux-kernel, Paul Cercueil
The GPM940B0 is a 3.0" 320x240 24-bit TFT LCD panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
v2: New patch
.../devicetree/bindings/display/panel/giantplus,gpm940b0.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
diff --git a/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt b/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
new file mode 100644
index 000000000000..3dab52f92c26
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
@@ -0,0 +1,12 @@
+GiantPlus 3.0" (320x240 pixels) 24-bit TFT LCD panel
+
+Required properties:
+- compatible: should be "giantplus,gpm940b0"
+- power-supply: as specified in the base binding
+
+Optional properties:
+- backlight: as specified in the base binding
+- enable-gpios: as specified in the base binding
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation
2019-03-14 12:26 ` [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 " Paul Cercueil
@ 2019-03-28 15:39 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2019-03-28 15:39 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, Mark Rutland, od, dri-devel, devicetree,
linux-kernel, Paul Cercueil
On Thu, 14 Mar 2019 13:26:19 +0100, Paul Cercueil wrote:
> The GPM940B0 is a 3.0" 320x240 24-bit TFT LCD panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v2: New patch
>
> .../devicetree/bindings/display/panel/giantplus,gpm940b0.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation
@ 2019-03-28 15:39 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2019-03-28 15:39 UTC (permalink / raw)
Cc: Thierry Reding, Mark Rutland, od, dri-devel, devicetree,
linux-kernel, Paul Cercueil
On Thu, 14 Mar 2019 13:26:19 +0100, Paul Cercueil wrote:
> The GPM940B0 is a 3.0" 320x240 24-bit TFT LCD panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v2: New patch
>
> .../devicetree/bindings/display/panel/giantplus,gpm940b0.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel
2019-03-14 12:26 [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
2019-03-14 12:26 ` [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 " Paul Cercueil
@ 2019-03-14 12:26 ` Paul Cercueil
2019-04-03 16:32 ` Thierry Reding
2019-03-14 12:26 ` [PATCH v2 4/5] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Paul Cercueil @ 2019-03-14 12:26 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, Mark Rutland
Cc: od, dri-devel, devicetree, linux-kernel, Paul Cercueil
The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB components
are transferred sequentially on a 8-bit bus.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Notes:
v2: New patch
include/uapi/linux/media-bus-format.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index d6a5a3bfe6c4..f31724d6cd40 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -34,7 +34,7 @@
#define MEDIA_BUS_FMT_FIXED 0x0001
-/* RGB - next is 0x101b */
+/* RGB - next is 0x101d */
#define MEDIA_BUS_FMT_RGB444_1X12 0x1016
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
@@ -54,6 +54,8 @@
#define MEDIA_BUS_FMT_RGB888_1X24 0x100a
#define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
#define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
+#define MEDIA_BUS_FMT_RGB888_3X8_BE 0x101b
+#define MEDIA_BUS_FMT_RGB888_3X8_LE 0x101c
#define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011
#define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012
#define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel
2019-03-14 12:26 ` [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Paul Cercueil
@ 2019-04-03 16:32 ` Thierry Reding
2019-04-08 10:40 ` Paul Cercueil
0 siblings, 1 reply; 11+ messages in thread
From: Thierry Reding @ 2019-04-03 16:32 UTC (permalink / raw)
To: Paul Cercueil
Cc: Rob Herring, Mark Rutland, Mauro Carvalho Chehab, Hans Verkuil,
od, dri-devel, devicetree, linux-kernel, linux-media
[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]
On Thu, Mar 14, 2019 at 01:26:20PM +0100, Paul Cercueil wrote:
> The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB components
> are transferred sequentially on a 8-bit bus.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v2: New patch
>
> include/uapi/linux/media-bus-format.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Please make sure you Cc the media maintainers on this one when you send
the next version. Adding them now.
>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index d6a5a3bfe6c4..f31724d6cd40 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x101b */
> +/* RGB - next is 0x101d */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -54,6 +54,8 @@
> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
> +#define MEDIA_BUS_FMT_RGB888_3X8_BE 0x101b
> +#define MEDIA_BUS_FMT_RGB888_3X8_LE 0x101c
The list looks roughly sorted, but these are not. That said, there are
others that don't seem like they are sorted either. All the more
important to get feedback from the media maintainers.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel
2019-04-03 16:32 ` Thierry Reding
@ 2019-04-08 10:40 ` Paul Cercueil
0 siblings, 0 replies; 11+ messages in thread
From: Paul Cercueil @ 2019-04-08 10:40 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, Mark Rutland, Mauro Carvalho Chehab, Hans Verkuil,
od, dri-devel, devicetree, linux-kernel, linux-media
Hi Thierry,
Le mer. 3 avril 2019 à 18:32, Thierry Reding
<thierry.reding@gmail.com> a écrit :
> On Thu, Mar 14, 2019 at 01:26:20PM +0100, Paul Cercueil wrote:
>> The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB
>> components
>> are transferred sequentially on a 8-bit bus.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>>
>> Notes:
>> v2: New patch
>>
>> include/uapi/linux/media-bus-format.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Please make sure you Cc the media maintainers on this one when you
> send
> the next version. Adding them now.
Oops. Will do.
>>
>> diff --git a/include/uapi/linux/media-bus-format.h
>> b/include/uapi/linux/media-bus-format.h
>> index d6a5a3bfe6c4..f31724d6cd40 100644
>> --- a/include/uapi/linux/media-bus-format.h
>> +++ b/include/uapi/linux/media-bus-format.h
>> @@ -34,7 +34,7 @@
>>
>> #define MEDIA_BUS_FMT_FIXED 0x0001
>>
>> -/* RGB - next is 0x101b */
>> +/* RGB - next is 0x101d */
>> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
>> @@ -54,6 +54,8 @@
>> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
>> +#define MEDIA_BUS_FMT_RGB888_3X8_BE 0x101b
>> +#define MEDIA_BUS_FMT_RGB888_3X8_LE 0x101c
>
> The list looks roughly sorted, but these are not. That said, there are
> others that don't seem like they are sorted either.
To me it looks like it's sorted alphabetically, that's why I
put the two new macros there.
> All the more important to get feedback from the media maintainers.
>
> Thierry
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 4/5] drm/panel: simple: Add Sharp LS020B1DD01D panel support
2019-03-14 12:26 [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
2019-03-14 12:26 ` [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 " Paul Cercueil
2019-03-14 12:26 ` [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Paul Cercueil
@ 2019-03-14 12:26 ` Paul Cercueil
2019-03-14 12:26 ` [PATCH v2 5/5] drm/panel: simple: Add GiantPlus GPM940B0 " Paul Cercueil
2019-03-28 15:39 ` Rob Herring
4 siblings, 0 replies; 11+ messages in thread
From: Paul Cercueil @ 2019-03-14 12:26 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, Mark Rutland
Cc: od, dri-devel, devicetree, linux-kernel, Paul Cercueil
The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
Notes:
v2: No change
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9e8218f6a3f2..3ab604f5477e 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2278,6 +2278,31 @@ static const struct panel_desc sharp_lq150x1lg11 = {
.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
};
+static const struct display_timing sharp_ls020b1dd01d_timing = {
+ .pixelclock = { 2000000, 4200000, 5000000 },
+ .hactive = { 240, 240, 240 },
+ .hfront_porch = { 66, 66, 66 },
+ .hback_porch = { 1, 1, 1 },
+ .hsync_len = { 1, 1, 1 },
+ .vactive = { 160, 160, 160 },
+ .vfront_porch = { 52, 52, 52 },
+ .vback_porch = { 6, 6, 6 },
+ .vsync_len = { 10, 10, 10 },
+ .flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_LOW,
+};
+
+static const struct panel_desc sharp_ls020b1dd01d = {
+ .timings = &sharp_ls020b1dd01d_timing,
+ .num_timings = 1,
+ .bpc = 6,
+ .size = {
+ .width = 42,
+ .height = 28,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB565_1X16,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
.clock = 33300,
.hdisplay = 800,
@@ -2767,6 +2792,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "sharp,lq150x1lg11",
.data = &sharp_lq150x1lg11,
}, {
+ .compatible = "sharp,ls020b1dd01d",
+ .data = &sharp_ls020b1dd01d,
+ }, {
.compatible = "shelly,sca07010-bfn-lnn",
.data = &shelly_sca07010_bfn_lnn,
}, {
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 5/5] drm/panel: simple: Add GiantPlus GPM940B0 panel support
2019-03-14 12:26 [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
` (2 preceding siblings ...)
2019-03-14 12:26 ` [PATCH v2 4/5] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
@ 2019-03-14 12:26 ` Paul Cercueil
2019-03-28 15:39 ` Rob Herring
4 siblings, 0 replies; 11+ messages in thread
From: Paul Cercueil @ 2019-03-14 12:26 UTC (permalink / raw)
To: Thierry Reding, Rob Herring, Mark Rutland
Cc: od, dri-devel, devicetree, linux-kernel, Paul Cercueil
The GiantPlus GPM940B0 is a simple 3.0" 320x240 24-bit TFT panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
---
Notes:
v2: Change bus format to MEDIA_BUS_FMT_RGB888_3X8_BE
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ab604f5477e..18fa34b88a53 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1208,6 +1208,31 @@ static const struct panel_desc giantplus_gpg482739qs5 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
+static const struct display_timing giantplus_gpm940b0_timing = {
+ .pixelclock = { 13500000, 27000000, 27500000 },
+ .hactive = { 320, 320, 320 },
+ .hfront_porch = { 14, 686, 718 },
+ .hback_porch = { 50, 70, 255 },
+ .hsync_len = { 1, 1, 1 },
+ .vactive = { 240, 240, 240 },
+ .vfront_porch = { 1, 1, 179 },
+ .vback_porch = { 1, 21, 31 },
+ .vsync_len = { 1, 1, 6 },
+ .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW,
+};
+
+static const struct panel_desc giantplus_gpm940b0 = {
+ .timings = &giantplus_gpm940b0_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 60,
+ .height = 45,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_3X8_BE,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
+};
+
static const struct display_timing hannstar_hsd070pww1_timing = {
.pixelclock = { 64300000, 71100000, 82000000 },
.hactive = { 1280, 1280, 1280 },
@@ -2666,6 +2691,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "giantplus,gpg482739qs5",
.data = &giantplus_gpg482739qs5
}, {
+ .compatible = "giantplus,gpm940b0",
+ .data = &giantplus_gpm940b0,
+ }, {
.compatible = "hannstar,hsd070pww1",
.data = &hannstar_hsd070pww1,
}, {
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation
2019-03-14 12:26 [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
@ 2019-03-28 15:39 ` Rob Herring
2019-03-14 12:26 ` [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Paul Cercueil
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2019-03-28 15:39 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, Mark Rutland, od, dri-devel, devicetree,
linux-kernel, Paul Cercueil
On Thu, 14 Mar 2019 13:26:18 +0100, Paul Cercueil wrote:
> The LS020B1DD01D is a 2.0" 240x160 16-bit TFT LCD panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v2: New patch
>
> .../devicetree/bindings/display/panel/sharp,ls020b1dd01d.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls020b1dd01d.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation
@ 2019-03-28 15:39 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2019-03-28 15:39 UTC (permalink / raw)
Cc: Thierry Reding, Mark Rutland, od, dri-devel, devicetree,
linux-kernel, Paul Cercueil
On Thu, 14 Mar 2019 13:26:18 +0100, Paul Cercueil wrote:
> The LS020B1DD01D is a 2.0" 240x160 16-bit TFT LCD panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>
> Notes:
> v2: New patch
>
> .../devicetree/bindings/display/panel/sharp,ls020b1dd01d.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls020b1dd01d.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread