From: Jerome Brunet <jbrunet@baylibre.com> To: Linus Walleij <linus.walleij@linaro.org>, Kevin Hilman <khilman@baylibre.com> Cc: Jerome Brunet <jbrunet@baylibre.com>, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Guillaume La Roque <glaroque@baylibre.com> Subject: [PATCH 0/2] pinctrl: meson: add g12a drive strength support Date: Thu, 14 Mar 2019 17:37:23 +0100 [thread overview] Message-ID: <20190314163725.7918-1-jbrunet@baylibre.com> (raw) The purpose of this patchset is to add drive-strength support in meson pinconf driver. This is a new feature that was added on the g12a. It is critical for us to support this since many functions are failing with default pad drive-strength. Now the slightly annoying part :( The value achievable by the SoC are 0.5mA, 2.5mA, 3mA and 4mA and the DT property 'drive-strength' is expressed in mA. 1) Rounding down the value, we could be requesting a 0mA drive strength. That would look weird. 2) Rounding up, we can't distinguish between 2.5mA and 3mA To solve this issue in this in this v1, we chose to document that, on Amlogic, drive-strength is expressed in uA instead of mA. It works well and there is no impact on the other platforms but I'm not sure this is really OK with the DT rules ? Linus, if this is not OK with you, here are 2 other options we are considering. We would be very interested to get your opinion on the matter: 1) instead the generic 'drive-strength' property, we could add an amlogic specific property, 'amlogic,drive-strength'. It would be expressed in uA and parsed in amlogic specific code. I think this option is kind of overkill. Expressing drive strength in uA is not really amlogic specific so it does not make much sense, but it would work ... 2) Add another generic property "drive-strength-uA". The change to do so would be minimal and could be benefit to other platforms later on. Cheers Jerome Guillaume La Roque (2): dt-bindings: pinctrl: meson: Add drive-strength property pinctrl: meson: add support of drive-strength .../bindings/pinctrl/meson,pinctrl.txt | 3 + drivers/pinctrl/meson/pinctrl-meson-g12a.c | 36 ++-- drivers/pinctrl/meson/pinctrl-meson.c | 166 +++++++++++++----- drivers/pinctrl/meson/pinctrl-meson.h | 20 ++- 4 files changed, 165 insertions(+), 60 deletions(-) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com> To: Linus Walleij <linus.walleij@linaro.org>, Kevin Hilman <khilman@baylibre.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Guillaume La Roque <glaroque@baylibre.com>, linux-amlogic@lists.infradead.org, Jerome Brunet <jbrunet@baylibre.com> Subject: [PATCH 0/2] pinctrl: meson: add g12a drive strength support Date: Thu, 14 Mar 2019 17:37:23 +0100 [thread overview] Message-ID: <20190314163725.7918-1-jbrunet@baylibre.com> (raw) The purpose of this patchset is to add drive-strength support in meson pinconf driver. This is a new feature that was added on the g12a. It is critical for us to support this since many functions are failing with default pad drive-strength. Now the slightly annoying part :( The value achievable by the SoC are 0.5mA, 2.5mA, 3mA and 4mA and the DT property 'drive-strength' is expressed in mA. 1) Rounding down the value, we could be requesting a 0mA drive strength. That would look weird. 2) Rounding up, we can't distinguish between 2.5mA and 3mA To solve this issue in this in this v1, we chose to document that, on Amlogic, drive-strength is expressed in uA instead of mA. It works well and there is no impact on the other platforms but I'm not sure this is really OK with the DT rules ? Linus, if this is not OK with you, here are 2 other options we are considering. We would be very interested to get your opinion on the matter: 1) instead the generic 'drive-strength' property, we could add an amlogic specific property, 'amlogic,drive-strength'. It would be expressed in uA and parsed in amlogic specific code. I think this option is kind of overkill. Expressing drive strength in uA is not really amlogic specific so it does not make much sense, but it would work ... 2) Add another generic property "drive-strength-uA". The change to do so would be minimal and could be benefit to other platforms later on. Cheers Jerome Guillaume La Roque (2): dt-bindings: pinctrl: meson: Add drive-strength property pinctrl: meson: add support of drive-strength .../bindings/pinctrl/meson,pinctrl.txt | 3 + drivers/pinctrl/meson/pinctrl-meson-g12a.c | 36 ++-- drivers/pinctrl/meson/pinctrl-meson.c | 166 +++++++++++++----- drivers/pinctrl/meson/pinctrl-meson.h | 20 ++- 4 files changed, 165 insertions(+), 60 deletions(-) -- 2.20.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2019-03-14 16:37 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-14 16:37 Jerome Brunet [this message] 2019-03-14 16:37 ` [PATCH 0/2] pinctrl: meson: add g12a drive strength support Jerome Brunet 2019-03-14 16:37 ` [PATCH 1/2] dt-bindings: pinctrl: meson: Add drive-strength property Jerome Brunet 2019-03-14 16:37 ` Jerome Brunet 2019-03-31 6:40 ` Rob Herring 2019-03-31 6:40 ` Rob Herring 2019-03-31 7:04 ` Jerome Brunet 2019-03-31 7:04 ` Jerome Brunet 2019-04-04 3:42 ` Linus Walleij 2019-04-04 3:42 ` Linus Walleij 2019-04-04 3:42 ` Linus Walleij 2019-03-14 16:37 ` [PATCH 2/2] pinctrl: meson: add support of drive-strength Jerome Brunet 2019-03-14 16:37 ` Jerome Brunet 2019-03-18 13:12 ` Neil Armstrong 2019-03-18 13:12 ` Neil Armstrong 2019-03-25 9:44 ` [PATCH 0/2] pinctrl: meson: add g12a drive strength support Jerome Brunet 2019-03-25 9:44 ` Jerome Brunet 2019-03-25 9:44 ` Jerome Brunet 2019-04-04 3:41 ` Linus Walleij 2019-04-04 3:41 ` Linus Walleij 2019-04-04 3:41 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190314163725.7918-1-jbrunet@baylibre.com \ --to=jbrunet@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=glaroque@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linus.walleij@linaro.org \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.