All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
@ 2019-03-14 20:21 Antonio Argenziano
  2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Antonio Argenziano @ 2019-03-14 20:21 UTC (permalink / raw)
  To: igt-dev

Add a test for an invalid handle being passed to the IOCTL.

v2:
	- Expand test space. (Chris)

v3:
	- Add local IOCTL wrapper. (Chris)

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap_gtt.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index f6fbbe19..237308a2 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -821,6 +821,23 @@ run_without_prefault(int fd,
 	igt_enable_prefault();
 }
 
+static int
+err_gem_mmap_gtt(int i915, uint32_t handle, uint64_t size, uint64_t offset)
+{
+	struct drm_i915_gem_mmap arg = {
+				.handle = handle,
+				.size = size,
+				.offset = offset
+	};
+	int err = 0;
+
+	if(ioctl(i915, DRM_IOCTL_I915_GEM_MMAP_GTT, &arg))
+		err = -errno;
+
+	errno = 0;
+	return err;
+}
+
 int fd;
 
 igt_main
@@ -831,6 +848,25 @@ igt_main
 	igt_fixture
 		fd = drm_open_driver(DRIVER_INTEL);
 
+	igt_subtest("bad-object") {
+		int ret;
+
+		uint32_t real_handle = gem_create(fd, 4096);
+		uint32_t handles[20];
+		int i = 0;
+
+		handles[i++] = 0xdeadbeef;
+		for(int bit = 0; bit < 16; bit++)
+			handles[i++] = real_handle | (1 << (bit + 16));
+		handles[i] = real_handle + 1;
+
+		for (; i < 0; i--) {
+			igt_debug("Trying to mmap_gtt invalid handle: %x.\n", handles[i]);
+			ret = err_gem_mmap_gtt(fd, handles[i], 0, 4096);
+			igt_assert_eq(ret, -ENOENT);
+		}
+	}
+
 	igt_subtest("basic")
 		test_access(fd);
 	igt_subtest("basic-short")
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH i-g-t v3 2/3] tests/i915/gem_mmap: Add invalid parameters tests
  2019-03-14 20:21 [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
@ 2019-03-14 20:21 ` Antonio Argenziano
  2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/i915/gem_mmap_wc: Add invalid params tests Antonio Argenziano
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Antonio Argenziano @ 2019-03-14 20:21 UTC (permalink / raw)
  To: igt-dev

Add a couple of tests that supply invalid parameters to the mmap IOCTL.

v2:
	- Expand test space. (Chris)

v3:
	- Add local IOCTL wrapper. (Chris)

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap.c | 79 +++++++++++++++++++++++++++++++++++++++----
 1 file changed, 73 insertions(+), 6 deletions(-)

diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
index 0ed15878..636a9ba3 100644
--- a/tests/i915/gem_mmap.c
+++ b/tests/i915/gem_mmap.c
@@ -116,6 +116,23 @@ test_huge_bo(int huge)
 	free(cpu_pattern);
 }
 
+static int
+err_gem_mmap(int i915, uint32_t handle, uint64_t size, uint64_t offset)
+{
+	struct drm_i915_gem_mmap arg = {
+				.handle = handle,
+				.size = size,
+				.offset = offset
+	};
+	int err = 0;
+
+	if(ioctl(i915, DRM_IOCTL_I915_GEM_MMAP, &arg))
+		err = -errno;
+
+	errno = 0;
+	return err;
+}
+
 igt_main
 {
 	struct drm_i915_gem_mmap arg;
@@ -128,12 +145,62 @@ igt_main
 		fd = drm_open_driver(DRIVER_INTEL);
 
 	igt_subtest("bad-object") {
-		memset(&arg, 0, sizeof(arg));
-		arg.handle = 0x10101010;
-		arg.offset = 0;
-		arg.size = 4096;
-		ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
-		igt_assert(ret == -1 && errno == ENOENT);
+		uint32_t real_handle = gem_create(fd, 4096);
+		uint32_t handles[20];
+		int i = 0;
+
+		handles[i++] = 0xdeadbeef;
+		for(int bit = 0; bit < 16; bit++)
+			handles[i++] = real_handle | (1 << (bit + 16));
+		handles[i] = real_handle + 1;
+
+		for (; i < 0; i--) {
+			igt_debug("Trying mmap a bad object. Handle %x\n", handles[i]);
+			ret = err_gem_mmap(fd, handles[i], 4096, 0);
+			igt_assert_eq(ret, -EINVAL);
+		}
+	}
+
+	igt_subtest("bad-offset") {
+		struct bad_offset {
+			uint64_t size;
+			uint64_t offset;
+		} bad_offsets[] = {
+				{4096, 4096 + 1},
+				{4096, -4096},
+				{ 2 * 4096, -4096},
+				{ 4096, ~0},
+		};
+		uint32_t handle = gem_create(fd, 4096);
+
+		for (int i = 0; i < ARRAY_SIZE(bad_offsets); i++) {
+			igt_debug("Trying to mmap bad offset; size: %lu, offset: %lu\n",
+					bad_offsets[i].size, bad_offsets[i].offset);
+			ret = err_gem_mmap(fd, handle,
+							bad_offsets[i].size, bad_offsets[i].offset);
+			igt_assert_eq(ret, -EINVAL);
+		}
+	}
+
+	igt_subtest("bad-size") {
+		uint64_t bad_size[] = {
+			0,
+			-4096,
+			4096 + 1,
+			2 * 4096,
+			~0,
+		};
+		uint32_t handle = gem_create(fd, 4096);
+		uint64_t offset;
+
+		for (int i = 0; i < ARRAY_SIZE(bad_size); i++) {
+			//offset = (bad_size[i] - 1) % bad_size[i];
+
+			igt_debug("Trying to mmap bad size; size: %lu, offset %lu\n",
+					bad_size[i], offset);
+			ret = err_gem_mmap(fd, handle, bad_size[i], offset);
+			igt_assert_eq(ret, -EINVAL);
+		}
 	}
 
 	igt_subtest("basic") {
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH i-g-t v3 3/3] tests/i915/gem_mmap_wc: Add invalid params tests
  2019-03-14 20:21 [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
  2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
@ 2019-03-14 20:21 ` Antonio Argenziano
  2019-03-14 20:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Antonio Argenziano @ 2019-03-14 20:21 UTC (permalink / raw)
  To: igt-dev

Add some invalid parameters tests for the MMAP IOCTL when the MMAP_WC
flag is supplied.

v2:
	- Expand test space. (Chris)

v3:
	- Add local IOCTL wrapper. (Chris)

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap_wc.c | 85 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
index baa68aa8..8422b3b0 100644
--- a/tests/i915/gem_mmap_wc.c
+++ b/tests/i915/gem_mmap_wc.c
@@ -81,6 +81,24 @@ mmap_bo(int fd, uint32_t handle)
 	return ptr;
 }
 
+static int
+err_gem_mmap_wc(int i915, uint32_t handle, uint64_t size, uint64_t offset)
+{
+	struct drm_i915_gem_mmap arg = {
+				.handle = handle,
+				.size = size,
+				.offset = offset,
+				.flags = I915_MMAP_WC
+	};
+	int err = 0;
+
+	if(ioctl(i915, DRM_IOCTL_I915_GEM_MMAP, &arg))
+		err = -errno;
+
+	errno = 0;
+	return err;
+}
+
 static void *
 create_pointer(int fd)
 {
@@ -463,6 +481,73 @@ igt_main
 		gem_require_mmap_wc(fd);
 	}
 
+	igt_subtest_group {
+
+		igt_subtest("bad-object") {
+			int ret;
+			uint32_t real_handle = gem_create(fd, 4096);
+			uint32_t handles[20];
+			int i = 0;
+
+			handles[i++] = 0xdeadbeef;
+			for(int bit = 0; bit < 16; bit++)
+				handles[i++] = real_handle | (1 << (bit + 16));
+			handles[i] = real_handle + 1;
+
+			for (; i < 0; i--) {
+				igt_debug("Trying to mmap bad object. Handle: %x\n",
+						handles[i]);
+				ret = err_gem_mmap_wc(fd, handles[i], 4096, 0);
+				igt_assert_eq(ret, -EINVAL);
+			}
+		}
+
+		igt_subtest("bad-offset") {
+			int ret;
+			uint32_t handle = gem_create(fd, 4096);
+			struct bad_offset {
+				uint64_t size;
+				uint64_t offset;
+			} bad_offsets[] = {
+				{4096, 4096 + 1},
+				{4096, -4096},
+				{ 2 * 4096, -4096},
+				{ 4096, ~0},
+			};
+
+			for (int i = 0; i < ARRAY_SIZE(bad_offsets); i++) {
+				igt_debug("Trying to mmap bad offset; size: %lu, offset %lu\n",
+					bad_offsets[i].size, bad_offsets[i].offset);
+				ret = err_gem_mmap_wc(fd, handle,
+									bad_offsets[i].size, bad_offsets[i].offset);
+				igt_assert_eq(ret, -EINVAL);
+			}
+		}
+
+		igt_subtest("bad-size") {
+			int ret;
+			uint32_t handle = gem_create(fd, 4096);
+			uint64_t offset;
+			uint64_t bad_size[] = {
+				0,
+				-4096,
+				4096 + 1,
+				2 * 4096,
+				~0,
+			};
+
+			for (int i = 0; i < ARRAY_SIZE(bad_size); i++) {
+				offset = (bad_size[i] - 1) % bad_size[i];
+
+				igt_debug("Trying to mmap bad offset; size: %lu, offset %lu\n",
+				bad_size[i], offset);
+				ret = err_gem_mmap_wc(fd, handle,
+									bad_size[i], offset);
+				igt_assert_eq(ret, -EINVAL);
+			}
+		}
+	}
+
 	igt_subtest("invalid-flags")
 		test_invalid_flags(fd);
 	igt_subtest("close")
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
  2019-03-14 20:21 [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
  2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
  2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/i915/gem_mmap_wc: Add invalid params tests Antonio Argenziano
@ 2019-03-14 20:54 ` Patchwork
  2019-03-14 22:46 ` [igt-dev] [PATCH i-g-t v3 1/3] " Chris Wilson
  2019-03-15  7:54 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] " Patchwork
  4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-14 20:54 UTC (permalink / raw)
  To: Antonio Argenziano; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
URL   : https://patchwork.freedesktop.org/series/58019/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5749 -> IGTPW_2626
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58019/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2626 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-multi-fence:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] +18

  * igt@amdgpu/amd_basic@userptr:
    - fi-whl-u:           NOTRUN -> SKIP [fdo#109271] +41

  * igt@gem_exec_basic@gtt-bsd2:
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +57

  * igt@gem_exec_basic@readonly-bsd:
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] +76

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

  * igt@kms_busy@basic-flip-c:
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] +52

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     NOTRUN -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     NOTRUN -> FAIL [fdo#103191] / [fdo#107362] +1

  * igt@kms_psr@cursor_plane_move:
    - fi-skl-6260u:       NOTRUN -> SKIP [fdo#109271] +37
    - fi-whl-u:           NOTRUN -> FAIL [fdo#107383] +3

  * igt@runner@aborted:
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
#### Possible fixes ####

  * igt@i915_module_load@reload:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (39 -> 30)
------------------------------

  Additional (5): fi-byt-j1900 fi-skl-6260u fi-whl-u fi-pnv-d510 fi-byt-clapper 
  Missing    (14): fi-kbl-soraka fi-ilk-m540 fi-skl-gvtdvm fi-bsw-n3050 fi-hsw-4200u fi-bdw-gvtdvm fi-bsw-cyan fi-hsw-4770 fi-bxt-j4205 fi-skl-6700k2 fi-kbl-7560u fi-byt-n2820 fi-bsw-kefka fi-skl-6600u 


Build changes
-------------

    * IGT: IGT_4885 -> IGTPW_2626

  CI_DRM_5749: 83812f5bdb51f67d25560a70d534279f69e823b6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2626: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2626/
  IGT_4885: 1e057f43cd30ab6acfd40794673843942521c0c5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_mmap@bad-offset
+igt@gem_mmap@bad-size
+igt@gem_mmap_gtt@bad-object
+igt@gem_mmap_wc@bad-object
+igt@gem_mmap_wc@bad-offset
+igt@gem_mmap_wc@bad-size

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2626/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
  2019-03-14 20:21 [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
                   ` (2 preceding siblings ...)
  2019-03-14 20:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Patchwork
@ 2019-03-14 22:46 ` Chris Wilson
  2019-03-15  7:54 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] " Patchwork
  4 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-03-14 22:46 UTC (permalink / raw)
  To: Antonio Argenziano, igt-dev

Quoting Antonio Argenziano (2019-03-14 20:21:31)
> Add a test for an invalid handle being passed to the IOCTL.
> 
> v2:
>         - Expand test space. (Chris)
> 
> v3:
>         - Add local IOCTL wrapper. (Chris)
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/i915/gem_mmap_gtt.c | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index f6fbbe19..237308a2 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -821,6 +821,23 @@ run_without_prefault(int fd,
>         igt_enable_prefault();
>  }
>  
> +static int
> +err_gem_mmap_gtt(int i915, uint32_t handle, uint64_t size, uint64_t offset)
> +{
> +       struct drm_i915_gem_mmap arg = {
> +                               .handle = handle,
> +                               .size = size,
> +                               .offset = offset

Just one tab indent required.

> +       };
> +       int err = 0;
> +
> +       if(ioctl(i915, DRM_IOCTL_I915_GEM_MMAP_GTT, &arg))
            ^ space before (

Just give these a once over with the magic whitespace pen.

Later you have a mixture of
	{4096}
	{4096 }
	{ 4096}
	{ 2* 4096 }
etc which is catching my ocd.

> +               err = -errno;
Petri had to add
		igt_assume(err);
to this style to satisfy static analyzers.

> +
> +       errno = 0;
> +       return err;
> +}
> +
>  int fd;
>  
>  igt_main
> @@ -831,6 +848,25 @@ igt_main
>         igt_fixture
>                 fd = drm_open_driver(DRIVER_INTEL);
>  
> +       igt_subtest("bad-object") {
> +               int ret;
> +

Why the newline?

> +               uint32_t real_handle = gem_create(fd, 4096);
> +               uint32_t handles[20];
> +               int i = 0;
> +
> +               handles[i++] = 0xdeadbeef;
> +               for(int bit = 0; bit < 16; bit++)
> +                       handles[i++] = real_handle | (1 << (bit + 16));
> +               handles[i] = real_handle + 1;
> +
> +               for (; i < 0; i--) {
> +                       igt_debug("Trying to mmap_gtt invalid handle: %x.\n", handles[i]);
> +                       ret = err_gem_mmap_gtt(fd, handles[i], 0, 4096);
> +                       igt_assert_eq(ret, -ENOENT);

igt_assert_f(err_gem_mmap_gtt(fd, handles[i], 0, 4096) == -ENOENT,
             "Succeeded in trying to mmap_gtt invalid handle %x!\n,
	     handles[i]);
Maybe?

Provoke it to fail and see what you think gives the right amount of
information with least noise.

Anyway, series looks good to me, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

We just need to land the fixes first, and hope nothing breaks by being
fixed.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
  2019-03-14 20:21 [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
                   ` (3 preceding siblings ...)
  2019-03-14 22:46 ` [igt-dev] [PATCH i-g-t v3 1/3] " Chris Wilson
@ 2019-03-15  7:54 ` Patchwork
  4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-15  7:54 UTC (permalink / raw)
  To: Antonio Argenziano; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
URL   : https://patchwork.freedesktop.org/series/58019/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5749_full -> IGTPW_2626_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/58019/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2626_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@gem_mmap@bad-size} (NEW):
    - shard-kbl:          NOTRUN -> FAIL
    - shard-apl:          NOTRUN -> FAIL
    - shard-snb:          NOTRUN -> FAIL
    - shard-glk:          NOTRUN -> FAIL

  * {igt@gem_mmap_wc@bad-size} (NEW):
    - shard-snb:          NOTRUN -> CRASH
    - shard-apl:          NOTRUN -> CRASH
    - shard-glk:          NOTRUN -> CRASH
    - shard-hsw:          NOTRUN -> CRASH
    - shard-kbl:          NOTRUN -> CRASH

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@kms_plane@pixel-format-pipe-a-planes}:
    - shard-apl:          PASS -> FAIL

  
New tests
---------

  New tests have been introduced between CI_DRM_5749_full and IGTPW_2626_full:

### New IGT tests (6) ###

  * igt@gem_mmap@bad-offset:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@gem_mmap@bad-size:
    - Statuses : 4 fail(s)
    - Exec time: [0.01, 0.09] s

  * igt@gem_mmap_gtt@bad-object:
    - Statuses : 5 pass(s)
    - Exec time: [0.0, 0.00] s

  * igt@gem_mmap_wc@bad-object:
    - Statuses : 5 pass(s)
    - Exec time: [0.0] s

  * igt@gem_mmap_wc@bad-offset:
    - Statuses : 4 pass(s)
    - Exec time: [0.0] s

  * igt@gem_mmap_wc@bad-size:
    - Statuses : 5 crash(s)
    - Exec time: [0.01, 0.03] s

  

Known issues
------------

  Here are the changes found in IGTPW_2626_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          PASS -> SKIP [fdo#109271]

  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +11

  * igt@i915_pm_rpm@gem-execbuf-stress-extra-wait:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +149

  * igt@kms_atomic_transition@3x-modeset-transitions-fencing:
    - shard-hsw:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3

  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_busy@extended-modeset-hang-newfb-render-a:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#107956] +1

  * igt@kms_busy@extended-modeset-hang-newfb-render-b:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956] +1

  * igt@kms_busy@extended-modeset-hang-newfb-render-e:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
    - shard-snb:          NOTRUN -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-hang-newfb-render-a:
    - shard-apl:          NOTRUN -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-hang-newfb-render-e:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_chamelium@hdmi-crc-argb1555:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +5

  * igt@kms_color@pipe-a-legacy-gamma:
    - shard-apl:          PASS -> FAIL [fdo#104782] / [fdo#108145]

  * igt@kms_cursor_crc@cursor-128x128-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-256x256-onscreen:
    - shard-kbl:          PASS -> FAIL [fdo#103232] +2

  * igt@kms_cursor_crc@cursor-256x256-sliding:
    - shard-apl:          NOTRUN -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-hsw:          PASS -> INCOMPLETE [fdo#103540]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
    - shard-kbl:          PASS -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
    - shard-apl:          PASS -> FAIL [fdo#103167] +1

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-glk:          PASS -> FAIL [fdo#103167] +8

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-cpu:
    - shard-hsw:          NOTRUN -> SKIP [fdo#109271] +17

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-e:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +17

  * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
    - shard-glk:          PASS -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_setmode@basic:
    - shard-hsw:          PASS -> FAIL [fdo#99912]

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          PASS -> FAIL [fdo#104894] +2
    - shard-hsw:          PASS -> FAIL [fdo#104894]

  * igt@prime_vgem@sync-bsd1:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +35

  
#### Possible fixes ####

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          SKIP [fdo#109271] -> PASS

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-kbl:          INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-render-c:
    - shard-hsw:          DMESG-WARN [fdo#107956] -> PASS +1

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-kbl:          FAIL [fdo#107725] / [fdo#108145] -> PASS

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          FAIL [fdo#108145] -> PASS

  * igt@kms_color@pipe-a-ctm-max:
    - shard-apl:          FAIL [fdo#108147] -> PASS

  * igt@kms_color@pipe-c-degamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-128x42-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS +4

  * igt@kms_cursor_crc@cursor-64x64-random:
    - shard-kbl:          FAIL [fdo#103232] -> PASS +2

  * igt@kms_cursor_crc@cursor-size-change:
    - shard-glk:          FAIL [fdo#103232] -> PASS

  * igt@kms_flip@2x-modeset-vs-vblank-race:
    - shard-glk:          FAIL [fdo#103060] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-apl:          FAIL [fdo#103167] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          FAIL [fdo#103167] -> PASS +2

  * {igt@kms_plane@pixel-format-pipe-a-planes}:
    - shard-glk:          SKIP [fdo#109271] -> PASS

  * {igt@kms_plane@pixel-format-pipe-b-planes}:
    - shard-kbl:          FAIL -> PASS
    - shard-apl:          FAIL -> PASS

  * {igt@kms_plane@plane-position-covered-pipe-a-planes}:
    - shard-apl:          FAIL [fdo#110038] -> PASS

  * {igt@kms_plane@plane-position-covered-pipe-b-planes}:
    - shard-glk:          FAIL [fdo#110038] -> PASS

  * {igt@kms_plane_multiple@atomic-pipe-a-tiling-x}:
    - shard-apl:          FAIL [fdo#110037] -> PASS +2
    - shard-kbl:          FAIL [fdo#110037] -> PASS

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          DMESG-FAIL [fdo#105763] -> PASS

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS
    - shard-kbl:          FAIL [fdo#99912] -> PASS

  * igt@testdisplay:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS +1
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS +1

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
  [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 5)
------------------------------

  Missing    (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u 


Build changes
-------------

    * IGT: IGT_4885 -> IGTPW_2626
    * Piglit: piglit_4509 -> None

  CI_DRM_5749: 83812f5bdb51f67d25560a70d534279f69e823b6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2626: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2626/
  IGT_4885: 1e057f43cd30ab6acfd40794673843942521c0c5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2626/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-03-15  7:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 20:21 [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/i915/gem_mmap_wc: Add invalid params tests Antonio Argenziano
2019-03-14 20:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Patchwork
2019-03-14 22:46 ` [igt-dev] [PATCH i-g-t v3 1/3] " Chris Wilson
2019-03-15  7:54 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.