* [Buildroot] [PATCH] package/libpcap: disable dbus to break circular dependency
@ 2019-03-09 18:28 Baruch Siach
2019-03-14 21:03 ` Thomas Petazzoni
2019-03-25 20:40 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2019-03-09 18:28 UTC (permalink / raw)
To: buildroot
The optional dbus dependency of libpcap creates a circular dependency
chain:
$ make libpcap-show-recursive-depends
Recursion detected for : systemd
which is a dependency of: dbus
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/libpcap/libpcap.mk:55: libpcap-show-recursive-depends] Error 1
Of all these dependencies the one of libpcap on dbus seems to be less
useful. Drop it.
Fixes:
http://autobuild.buildroot.net/results/0b5d18bff816cbcee11e8645449701722d956de5/
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/libpcap/libpcap.mk | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/package/libpcap/libpcap.mk b/package/libpcap/libpcap.mk
index 126087220b02..83188c8c4847 100644
--- a/package/libpcap/libpcap.mk
+++ b/package/libpcap/libpcap.mk
@@ -16,6 +16,8 @@ LIBPCAP_CONF_ENV = \
CFLAGS="$(LIBPCAP_CFLAGS)"
LIBPCAP_CFLAGS = $(TARGET_CFLAGS)
LIBPCAP_CONF_OPTS = --disable-yydebug --with-pcap=linux --without-dag
+# Disable dbus to break recursive dependencies
+LIBPCAP_CONF_OPTS += --disable-dbus
LIBPCAP_CONFIG_SCRIPTS = pcap-config
# Omit -rpath from pcap-config output
@@ -32,13 +34,6 @@ else
LIBPCAP_CONF_OPTS += --disable-bluetooth
endif
-ifeq ($(BR2_PACKAGE_DBUS),y)
-LIBPCAP_CONF_OPTS += --enable-dbus
-LIBPCAP_DEPENDENCIES += dbus
-else
-LIBPCAP_CONF_OPTS += --disable-dbus
-endif
-
ifeq ($(BR2_PACKAGE_LIBNL),y)
LIBPCAP_DEPENDENCIES += libnl
LIBPCAP_CFLAGS += "-I$(STAGING_DIR)/usr/include/libnl3"
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/libpcap: disable dbus to break circular dependency
2019-03-09 18:28 [Buildroot] [PATCH] package/libpcap: disable dbus to break circular dependency Baruch Siach
@ 2019-03-14 21:03 ` Thomas Petazzoni
2019-03-25 20:40 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-14 21:03 UTC (permalink / raw)
To: buildroot
On Sat, 9 Mar 2019 20:28:14 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> The optional dbus dependency of libpcap creates a circular dependency
> chain:
>
> $ make libpcap-show-recursive-depends
>
> Recursion detected for : systemd
> which is a dependency of: dbus
> which is a dependency of: libpcap
> which is a dependency of: iptables
> which is a dependency of: systemd
> make: *** [package/libpcap/libpcap.mk:55: libpcap-show-recursive-depends] Error 1
>
> Of all these dependencies the one of libpcap on dbus seems to be less
> useful. Drop it.
>
> Fixes:
> http://autobuild.buildroot.net/results/0b5d18bff816cbcee11e8645449701722d956de5/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/libpcap/libpcap.mk | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/libpcap: disable dbus to break circular dependency
2019-03-09 18:28 [Buildroot] [PATCH] package/libpcap: disable dbus to break circular dependency Baruch Siach
2019-03-14 21:03 ` Thomas Petazzoni
@ 2019-03-25 20:40 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-03-25 20:40 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> The optional dbus dependency of libpcap creates a circular dependency
> chain:
> $ make libpcap-show-recursive-depends
> Recursion detected for : systemd
> which is a dependency of: dbus
> which is a dependency of: libpcap
> which is a dependency of: iptables
> which is a dependency of: systemd
> make: *** [package/libpcap/libpcap.mk:55: libpcap-show-recursive-depends] Error 1
> Of all these dependencies the one of libpcap on dbus seems to be less
> useful. Drop it.
> Fixes:
> http://autobuild.buildroot.net/results/0b5d18bff816cbcee11e8645449701722d956de5/
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-09 18:28 [Buildroot] [PATCH] package/libpcap: disable dbus to break circular dependency Baruch Siach
2019-03-14 21:03 ` Thomas Petazzoni
2019-03-25 20:40 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.