* [PATCH] staging: speakup: fix line over 80 characters.
@ 2019-03-17 3:39 Jules Irenge
2019-03-17 7:16 ` [Outreachy kernel] " Julia Lawall
2019-03-17 10:14 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Jules Irenge @ 2019-03-17 3:39 UTC (permalink / raw)
To: linux-kernel; +Cc: outreachy-kernel, gregkh
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
---
drivers/staging/speakup/kobjects.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 2eb5af3debb3..abeab64899db 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
continue;
}
- /* Do not replace with kstrtoul: here we need temp to be updated */
+/* Do not replace with kstrtoul: here we need temp to be updated */
index = simple_strtoul(cp, &temp, 10);
if (index > 255) {
rejected++;
@@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
continue;
}
- /* Do not replace with kstrtoul: here we need temp to be updated */
+/* Do not replace with kstrtoul: here we need temp to be updated */
index = simple_strtoul(cp, &temp, 10);
while ((temp < linefeed) && (*temp == ' ' || *temp == '\t'))
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: fix line over 80 characters.
2019-03-17 3:39 [PATCH] staging: speakup: fix line over 80 characters Jules Irenge
@ 2019-03-17 7:16 ` Julia Lawall
2019-03-17 10:14 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-03-17 7:16 UTC (permalink / raw)
To: Jules Irenge; +Cc: linux-kernel, outreachy-kernel, gregkh
On Sun, 17 Mar 2019, Jules Irenge wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
> ---
> drivers/staging/speakup/kobjects.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 2eb5af3debb3..abeab64899db 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
> continue;
> }
>
> - /* Do not replace with kstrtoul: here we need temp to be updated */
> +/* Do not replace with kstrtoul: here we need temp to be updated */
It's only a few characters over 80. Maybe you can rephrase the comment
instead.
julia
> index = simple_strtoul(cp, &temp, 10);
> if (index > 255) {
> rejected++;
> @@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
> continue;
> }
>
> - /* Do not replace with kstrtoul: here we need temp to be updated */
> +/* Do not replace with kstrtoul: here we need temp to be updated */
> index = simple_strtoul(cp, &temp, 10);
>
> while ((temp < linefeed) && (*temp == ' ' || *temp == '\t'))
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190317033946.12585-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: speakup: fix line over 80 characters.
2019-03-17 3:39 [PATCH] staging: speakup: fix line over 80 characters Jules Irenge
2019-03-17 7:16 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-17 10:14 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-03-17 10:14 UTC (permalink / raw)
To: Jules Irenge; +Cc: linux-kernel, outreachy-kernel
On Sun, Mar 17, 2019 at 03:39:46AM +0000, Jules Irenge wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
> ---
> drivers/staging/speakup/kobjects.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 2eb5af3debb3..abeab64899db 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
> continue;
> }
>
> - /* Do not replace with kstrtoul: here we need temp to be updated */
> +/* Do not replace with kstrtoul: here we need temp to be updated */
No, never put code or comments this far to the left. Instead, properly
line-wrap them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-17 10:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-17 3:39 [PATCH] staging: speakup: fix line over 80 characters Jules Irenge
2019-03-17 7:16 ` [Outreachy kernel] " Julia Lawall
2019-03-17 10:14 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.