All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH 3/6] block: check if page is mergeable in one helper
Date: Sun, 17 Mar 2019 16:05:28 +0800	[thread overview]
Message-ID: <20190317080526.GA11223@ming.t460p> (raw)
In-Reply-To: <20190311142356.GC7850@lst.de>

On Mon, Mar 11, 2019 at 03:23:56PM +0100, Christoph Hellwig wrote:
> > +static inline bool
> > +page_is_mergeable(const struct bio_vec *bv, struct page *page,
> > +		unsigned int len, unsigned int off, bool same_page)
> 
> Please follow the other function declarations in this file:
> 
> static inline bool page_is_mergeable(const struct bio_vec *bv,
> 		struct page *page, unsigned int len, unsigned int off,
> 		bool same_page)

OK.

> 
> > +	if (same_page && (vec_end_addr & PAGE_MASK) != page_addr)
> > +		return false;
> 
> No need for the inner braces here.

I think it is needed, given "!=" has higher precedence thank "&", see

	https://en.cppreference.com/w/c/language/operator_precedence

Also the line is more readable with inner braces.

Thanks,
Ming

  reply	other threads:[~2019-03-17  8:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09  1:37 [PATCH 0/6] block: enable multi-page bvec for passthrough IO Ming Lei
2019-03-09  1:37 ` Ming Lei
2019-03-09  1:37 ` [PATCH 1/6] block: pass page to xen_biovec_phys_mergeable Ming Lei
2019-03-09  1:37   ` Ming Lei
2019-03-11 14:16   ` Christoph Hellwig
2019-03-11 14:16     ` Christoph Hellwig
2019-03-11 19:57   ` Boris Ostrovsky
2019-03-11 19:57     ` Boris Ostrovsky
2019-03-09  1:37 ` [PATCH 2/6] block: don't merge adjacent bvecs to one segment in bio blk_queue_split Ming Lei
2019-03-09  1:37   ` Ming Lei
2019-03-11 14:21   ` Christoph Hellwig
2019-03-11 14:21     ` Christoph Hellwig
2019-03-12  1:22     ` Ming Lei
2019-03-12  1:22       ` Ming Lei
2019-03-11 19:58   ` Boris Ostrovsky
2019-03-11 19:58     ` Boris Ostrovsky
2019-03-09  1:37 ` [PATCH 3/6] block: check if page is mergeable in one helper Ming Lei
2019-03-11 14:23   ` Christoph Hellwig
2019-03-17  8:05     ` Ming Lei [this message]
2019-03-09  1:37 ` [PATCH 4/6] block: put the same page when adding it to bio Ming Lei
2019-03-11 14:28   ` Christoph Hellwig
2019-03-09  1:37 ` [PATCH 5/6] block: enable multi-page bvec for passthrough IO Ming Lei
2019-03-11 14:35   ` Christoph Hellwig
2019-03-12  1:06     ` Ming Lei
2019-03-09  1:37 ` [PATCH 6/6] block: don't check if adjacent bvecs in one bio can be mergeable Ming Lei
2019-03-11 14:40   ` Christoph Hellwig
2019-03-12  1:19     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190317080526.GA11223@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.