From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>, ris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org, Omar Sandoval <osandov@fb.com>, Christoph Hellwig <hch@lst.de> Subject: [PATCH 1/6] block: pass page to xen_biovec_phys_mergeable Date: Sat, 9 Mar 2019 09:37:32 +0800 [thread overview] Message-ID: <20190309013737.27741-2-ming.lei@redhat.com> (raw) In-Reply-To: <20190309013737.27741-1-ming.lei@redhat.com> xen_biovec_phys_mergeable() only needs .bv_page of the 2nd bio bvec for checking if the two bvecs can be merged, so pass page to xen_biovec_phys_mergeable() directly. No function change. Cc: ris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: xen-devel@lists.xenproject.org Cc: Omar Sandoval <osandov@fb.com> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk.h | 2 +- drivers/xen/biomerge.c | 5 +++-- include/xen/xen.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/blk.h b/block/blk.h index 5d636ee41663..e27fd1512e4b 100644 --- a/block/blk.h +++ b/block/blk.h @@ -75,7 +75,7 @@ static inline bool biovec_phys_mergeable(struct request_queue *q, if (addr1 + vec1->bv_len != addr2) return false; - if (xen_domain() && !xen_biovec_phys_mergeable(vec1, vec2)) + if (xen_domain() && !xen_biovec_phys_mergeable(vec1, vec2->bv_page)) return false; if ((addr1 | mask) != ((addr2 + vec2->bv_len - 1) | mask)) return false; diff --git a/drivers/xen/biomerge.c b/drivers/xen/biomerge.c index f3fbb700f569..05a286d24f14 100644 --- a/drivers/xen/biomerge.c +++ b/drivers/xen/biomerge.c @@ -4,12 +4,13 @@ #include <xen/xen.h> #include <xen/page.h> +/* check if @page can be merged with 'vec1' */ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, - const struct bio_vec *vec2) + const struct page *page) { #if XEN_PAGE_SIZE == PAGE_SIZE unsigned long bfn1 = pfn_to_bfn(page_to_pfn(vec1->bv_page)); - unsigned long bfn2 = pfn_to_bfn(page_to_pfn(vec2->bv_page)); + unsigned long bfn2 = pfn_to_bfn(page_to_pfn(page)); return bfn1 + PFN_DOWN(vec1->bv_offset + vec1->bv_len) == bfn2; #else diff --git a/include/xen/xen.h b/include/xen/xen.h index 0e2156786ad2..39a97f2eff75 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -44,6 +44,6 @@ extern struct hvm_start_info pvh_start_info; struct bio_vec; bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, - const struct bio_vec *vec2); + const struct page *page); #endif /* _XEN_XEN_H */ -- 2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: Juergen Gross <jgross@suse.com>, Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, ris Ostrovsky <boris.ostrovsky@oracle.com>, Christoph Hellwig <hch@lst.de>, Omar Sandoval <osandov@fb.com> Subject: [PATCH 1/6] block: pass page to xen_biovec_phys_mergeable Date: Sat, 9 Mar 2019 09:37:32 +0800 [thread overview] Message-ID: <20190309013737.27741-2-ming.lei@redhat.com> (raw) In-Reply-To: <20190309013737.27741-1-ming.lei@redhat.com> xen_biovec_phys_mergeable() only needs .bv_page of the 2nd bio bvec for checking if the two bvecs can be merged, so pass page to xen_biovec_phys_mergeable() directly. No function change. Cc: ris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: xen-devel@lists.xenproject.org Cc: Omar Sandoval <osandov@fb.com> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk.h | 2 +- drivers/xen/biomerge.c | 5 +++-- include/xen/xen.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/blk.h b/block/blk.h index 5d636ee41663..e27fd1512e4b 100644 --- a/block/blk.h +++ b/block/blk.h @@ -75,7 +75,7 @@ static inline bool biovec_phys_mergeable(struct request_queue *q, if (addr1 + vec1->bv_len != addr2) return false; - if (xen_domain() && !xen_biovec_phys_mergeable(vec1, vec2)) + if (xen_domain() && !xen_biovec_phys_mergeable(vec1, vec2->bv_page)) return false; if ((addr1 | mask) != ((addr2 + vec2->bv_len - 1) | mask)) return false; diff --git a/drivers/xen/biomerge.c b/drivers/xen/biomerge.c index f3fbb700f569..05a286d24f14 100644 --- a/drivers/xen/biomerge.c +++ b/drivers/xen/biomerge.c @@ -4,12 +4,13 @@ #include <xen/xen.h> #include <xen/page.h> +/* check if @page can be merged with 'vec1' */ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, - const struct bio_vec *vec2) + const struct page *page) { #if XEN_PAGE_SIZE == PAGE_SIZE unsigned long bfn1 = pfn_to_bfn(page_to_pfn(vec1->bv_page)); - unsigned long bfn2 = pfn_to_bfn(page_to_pfn(vec2->bv_page)); + unsigned long bfn2 = pfn_to_bfn(page_to_pfn(page)); return bfn1 + PFN_DOWN(vec1->bv_offset + vec1->bv_len) == bfn2; #else diff --git a/include/xen/xen.h b/include/xen/xen.h index 0e2156786ad2..39a97f2eff75 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -44,6 +44,6 @@ extern struct hvm_start_info pvh_start_info; struct bio_vec; bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, - const struct bio_vec *vec2); + const struct page *page); #endif /* _XEN_XEN_H */ -- 2.9.5 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-09 1:37 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-09 1:37 [PATCH 0/6] block: enable multi-page bvec for passthrough IO Ming Lei 2019-03-09 1:37 ` Ming Lei 2019-03-09 1:37 ` Ming Lei [this message] 2019-03-09 1:37 ` [PATCH 1/6] block: pass page to xen_biovec_phys_mergeable Ming Lei 2019-03-11 14:16 ` Christoph Hellwig 2019-03-11 14:16 ` Christoph Hellwig 2019-03-11 19:57 ` Boris Ostrovsky 2019-03-11 19:57 ` Boris Ostrovsky 2019-03-09 1:37 ` [PATCH 2/6] block: don't merge adjacent bvecs to one segment in bio blk_queue_split Ming Lei 2019-03-09 1:37 ` Ming Lei 2019-03-11 14:21 ` Christoph Hellwig 2019-03-11 14:21 ` Christoph Hellwig 2019-03-12 1:22 ` Ming Lei 2019-03-12 1:22 ` Ming Lei 2019-03-11 19:58 ` Boris Ostrovsky 2019-03-11 19:58 ` Boris Ostrovsky 2019-03-09 1:37 ` [PATCH 3/6] block: check if page is mergeable in one helper Ming Lei 2019-03-11 14:23 ` Christoph Hellwig 2019-03-17 8:05 ` Ming Lei 2019-03-09 1:37 ` [PATCH 4/6] block: put the same page when adding it to bio Ming Lei 2019-03-11 14:28 ` Christoph Hellwig 2019-03-09 1:37 ` [PATCH 5/6] block: enable multi-page bvec for passthrough IO Ming Lei 2019-03-11 14:35 ` Christoph Hellwig 2019-03-12 1:06 ` Ming Lei 2019-03-09 1:37 ` [PATCH 6/6] block: don't check if adjacent bvecs in one bio can be mergeable Ming Lei 2019-03-11 14:40 ` Christoph Hellwig 2019-03-12 1:19 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190309013737.27741-2-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@kernel.dk \ --cc=boris.ostrovsky@oracle.com \ --cc=hch@lst.de \ --cc=jgross@suse.com \ --cc=linux-block@vger.kernel.org \ --cc=osandov@fb.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.