[PATCH 1/2] staging: speakup: fix line over 80 characters.

[PATCH 1/2] staging: speakup: fix line over 80 characters.

[Jules Irenge]

Fix coding style issues, which solves checkpatch.pl warning:
    "WARNING: line over 80 characters".
---
 drivers/staging/speakup/kobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 11c704b27c3c..53c8793c382f 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
 			continue;
 		}
 
-		/* Do not replace with kstrtoul: here we need temp to be updated */
+		/* Do not replace with kstrtoul: temp need to be updated */
 		index = simple_strtoul(cp, &temp, 10);
 		if (index > 255) {
 			rejected++;
-- 
2.20.1

[PATCH 2/2] staging: speakup: fix line over 80 characters.

[Jules Irenge]

Fix coding style issues which solves checkpatch.pl warning:
    "WARNING: line over 80 characters".

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/speakup/kobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 53c8793c382f..1c3b0a257fe5 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
 			continue;
 		}
 
-		/* Do not replace with kstrtoul: here we need temp to be updated */
+		/* Do not replace with kstrtoul: temp need to be updated */
 		index = simple_strtoul(cp, &temp, 10);
 
 		while ((temp < linefeed) && (*temp == ' ' || *temp == '\t'))
-- 
2.20.1

Re: [Outreachy kernel] [PATCH 1/2] staging: speakup: fix line over 80 characters.

[Julia Lawall]

On Sun, 17 Mar 2019, Jules Irenge wrote:

> Fix coding style issues, which solves checkpatch.pl warning:
>     "WARNING: line over 80 characters".

You have two patches with the same subject.  Actually they do the same
thing, and work on the same file, so they could be merged into one patch.

Also you are missing the Signed-off-by.

julia

> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 11c704b27c3c..53c8793c382f 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
>  			continue;
>  		}
>
> -		/* Do not replace with kstrtoul: here we need temp to be updated */
> +		/* Do not replace with kstrtoul: temp need to be updated */
>  		index = simple_strtoul(cp, &temp, 10);
>  		if (index > 255) {
>  			rejected++;
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190317112857.18220-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH 1/2] staging: speakup: fix line over 80 characters.

[Greg KH]

On Sun, Mar 17, 2019 at 11:28:56AM +0000, Jules Irenge wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
>     "WARNING: line over 80 characters".
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

No signed off by?

> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 11c704b27c3c..53c8793c382f 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
>  			continue;
>  		}
>  
> -		/* Do not replace with kstrtoul: here we need temp to be updated */
> +		/* Do not replace with kstrtoul: temp need to be updated */

Original text is better than this, I do not know what your shortening of
the line now means :(

thanks,

greg k-h

Re: [PATCH 2/2] staging: speakup: fix line over 80 characters.

[Greg KH]

On Sun, Mar 17, 2019 at 11:28:57AM +0000, Jules Irenge wrote:
> Fix coding style issues which solves checkpatch.pl warning:
>     "WARNING: line over 80 characters".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 53c8793c382f..1c3b0a257fe5 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
>  			continue;
>  		}
>  
> -		/* Do not replace with kstrtoul: here we need temp to be updated */
> +		/* Do not replace with kstrtoul: temp need to be updated */

You sent 2 patches that did different things, yet they had the same
subject line?

Also, again, the original is better.

thanks,

greg k-h