All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] gtp: change NET_UDP_TUNNEL dependency to select
@ 2019-03-16  0:00 Matteo Croce
  2019-03-18 23:55 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2019-03-16  0:00 UTC (permalink / raw)
  To: netdev; +Cc: David S . Miller

Similarly to commit a7603ac1fc8c ("geneve: change NET_UDP_TUNNEL
dependency to select"), GTP has a dependency on NET_UDP_TUNNEL which
makes impossible to compile it if no other protocol depending on
NET_UDP_TUNNEL is selected.

Fix this by changing the depends to a select, and drop NET_IP_TUNNEL from
the select list, as it already depends on NET_UDP_TUNNEL.

Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 drivers/net/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 5e4ca082cfcd..7a96d168efc4 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -216,8 +216,8 @@ config GENEVE
 
 config GTP
 	tristate "GPRS Tunneling Protocol datapath (GTP-U)"
-	depends on INET && NET_UDP_TUNNEL
-	select NET_IP_TUNNEL
+	depends on INET
+	select NET_UDP_TUNNEL
 	---help---
 	  This allows one to create gtp virtual interfaces that provide
 	  the GPRS Tunneling Protocol datapath (GTP-U). This tunneling protocol
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] gtp: change NET_UDP_TUNNEL dependency to select
  2019-03-16  0:00 [PATCH net] gtp: change NET_UDP_TUNNEL dependency to select Matteo Croce
@ 2019-03-18 23:55 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-18 23:55 UTC (permalink / raw)
  To: mcroce; +Cc: netdev

From: Matteo Croce <mcroce@redhat.com>
Date: Sat, 16 Mar 2019 01:00:50 +0100

> Similarly to commit a7603ac1fc8c ("geneve: change NET_UDP_TUNNEL
> dependency to select"), GTP has a dependency on NET_UDP_TUNNEL which
> makes impossible to compile it if no other protocol depending on
> NET_UDP_TUNNEL is selected.
> 
> Fix this by changing the depends to a select, and drop NET_IP_TUNNEL from
> the select list, as it already depends on NET_UDP_TUNNEL.
> 
> Signed-off-by: Matteo Croce <mcroce@redhat.com>

Applied, thanks Matteo.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-18 23:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-16  0:00 [PATCH net] gtp: change NET_UDP_TUNNEL dependency to select Matteo Croce
2019-03-18 23:55 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.