From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH/RFC 07/15] dt-bindings: display: renesas: lvds: Add renesas,companion property
Date: Mon, 18 Mar 2019 16:22:40 +0200 [thread overview]
Message-ID: <20190318142240.GC12707@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdWfNk+v9PTMpE43DD8DvrmhZDeAocDReVNOsE=oh4P6uw@mail.gmail.com>
Hi Geert,
On Mon, Mar 18, 2019 at 11:21:15AM +0100, Geert Uytterhoeven wrote:
> On Thu, Mar 7, 2019 at 12:24 AM Laurent Pinchart wrote:
> > Add a new optional renesas,companion property to point to the companion
> > LVDS encoder. This is used to support dual-link operation where the main
> > LVDS encoder splits even-numbered and odd-numbered pixels between the
> > two LVDS encoders.
>
> Note that Documentation/devicetree/bindings/usb/generic.txt already
> describes a "companion" property without vendor prefix.
>
> > The new property doesn't control the mode of operation, it only
> > describes the relationship between the master and companion LVDS
> > encoders.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > index 900a884ad9f5..a720dbb5de69 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > @@ -45,6 +45,12 @@ OF graph bindings specified in Documentation/devicetree/bindings/graph.txt.
> >
> > Each port shall have a single endpoint.
> >
> > +Optional properties:
> > +
> > +- renesas,companion : phandle to the companion LVDS encoder. This property is
> > + valid for the first LVDS encoder D3 and E3 SoCs only, and points to the
>
> ... on D3 ...
>
> > + second encoder to be used as a companion in dual-link mode.
>
> Why restrict this to the first LVDS decoder, and not have a backlink in the
> other node,
Because there's no need to ? :-) Furthermore there's a need for the
master to know its a master, so have a link in a single direction is
pretty convenient. Otherwise I'd need an extra property to identify the
master.
> like for USB?
I'm not sure what USB does in that regard.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH/RFC 07/15] dt-bindings: display: renesas: lvds: Add renesas,companion property
Date: Mon, 18 Mar 2019 16:22:40 +0200 [thread overview]
Message-ID: <20190318142240.GC12707@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdWfNk+v9PTMpE43DD8DvrmhZDeAocDReVNOsE=oh4P6uw@mail.gmail.com>
Hi Geert,
On Mon, Mar 18, 2019 at 11:21:15AM +0100, Geert Uytterhoeven wrote:
> On Thu, Mar 7, 2019 at 12:24 AM Laurent Pinchart wrote:
> > Add a new optional renesas,companion property to point to the companion
> > LVDS encoder. This is used to support dual-link operation where the main
> > LVDS encoder splits even-numbered and odd-numbered pixels between the
> > two LVDS encoders.
>
> Note that Documentation/devicetree/bindings/usb/generic.txt already
> describes a "companion" property without vendor prefix.
>
> > The new property doesn't control the mode of operation, it only
> > describes the relationship between the master and companion LVDS
> > encoders.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > index 900a884ad9f5..a720dbb5de69 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > @@ -45,6 +45,12 @@ OF graph bindings specified in Documentation/devicetree/bindings/graph.txt.
> >
> > Each port shall have a single endpoint.
> >
> > +Optional properties:
> > +
> > +- renesas,companion : phandle to the companion LVDS encoder. This property is
> > + valid for the first LVDS encoder D3 and E3 SoCs only, and points to the
>
> ... on D3 ...
>
> > + second encoder to be used as a companion in dual-link mode.
>
> Why restrict this to the first LVDS decoder, and not have a backlink in the
> other node,
Because there's no need to ? :-) Furthermore there's a need for the
master to know its a master, so have a link in a single direction is
pretty convenient. Otherwise I'd need an extra property to identify the
master.
> like for USB?
I'm not sure what USB does in that regard.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-03-18 14:22 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 23:23 [PATCH/RFC 00/15] R-Car DU: LVDS dual-link mode support Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 01/15] drm: Clarify definition of the DRM_BUS_FLAG_(PIXDATA|SYNC)_* macros Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-04-24 8:15 ` Kieran Bingham
2019-04-24 8:15 ` Kieran Bingham
2019-03-06 23:23 ` [PATCH/RFC 02/15] drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-04-24 8:15 ` Kieran Bingham
2019-04-24 8:15 ` Kieran Bingham
2019-05-11 20:44 ` Laurent Pinchart
2019-05-11 20:44 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 03/15] drm/bridge: use bus flags in bridge timings Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-04-24 8:13 ` Kieran Bingham
2019-04-24 8:13 ` Kieran Bingham
2019-03-06 23:23 ` [PATCH/RFC 04/15] drm: bridge: Add dual_link field to the drm_bridge_timings structure Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-04-24 8:12 ` Kieran Bingham
2019-04-24 8:12 ` Kieran Bingham
2019-05-11 20:36 ` Laurent Pinchart
2019-05-11 20:36 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 05/15] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-08 16:49 ` Jacopo Mondi
2019-03-08 16:49 ` Jacopo Mondi
2019-03-08 17:57 ` Laurent Pinchart
2019-03-08 17:57 ` Laurent Pinchart
2019-03-09 11:23 ` Jacopo Mondi
2019-03-09 11:23 ` Jacopo Mondi
2019-03-09 11:51 ` Laurent Pinchart
2019-03-09 11:51 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-08 17:32 ` Jacopo Mondi
2019-03-08 17:32 ` Jacopo Mondi
2019-03-08 18:00 ` Laurent Pinchart
2019-03-08 18:00 ` Laurent Pinchart
2019-03-09 11:24 ` Jacopo Mondi
2019-03-09 11:24 ` Jacopo Mondi
2019-03-09 11:45 ` Laurent Pinchart
2019-03-09 11:45 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 07/15] dt-bindings: display: renesas: lvds: Add renesas, companion property Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 07/15] dt-bindings: display: renesas: lvds: Add renesas,companion property Laurent Pinchart
2019-03-18 10:21 ` Geert Uytterhoeven
2019-03-18 10:21 ` Geert Uytterhoeven
2019-03-18 14:22 ` Laurent Pinchart [this message]
2019-03-18 14:22 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 08/15] drm: rcar-du: lvds: Remove LVDS double-enable checks Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 09/15] drm: rcar-du: lvds: Adjust operating frequency for D3 and E3 Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-08 16:28 ` Jacopo Mondi
2019-03-08 16:28 ` Jacopo Mondi
2019-03-06 23:23 ` [PATCH/RFC 10/15] drm: rcar-du: lvds: Set LVEN and LVRES bits together on D3 Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-08 16:25 ` Jacopo Mondi
2019-03-08 16:25 ` Jacopo Mondi
2019-03-08 18:07 ` Laurent Pinchart
2019-03-08 18:07 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 11/15] drm: rcar-du: lvds: Add support for dual-link mode Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-08 17:20 ` Jacopo Mondi
2019-03-08 17:20 ` Jacopo Mondi
2019-03-08 18:12 ` Laurent Pinchart
2019-03-08 18:12 ` Laurent Pinchart
2019-03-09 11:11 ` Jacopo Mondi
2019-03-09 11:11 ` Jacopo Mondi
2019-03-09 11:25 ` Laurent Pinchart
2019-03-09 11:25 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 12/15] drm: rcar-du: Skip LVDS1 output on Gen3 when using dual-link LVDS mode Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 13/15] arm64: dts: renesas: r8a7799[05]: Point LVDS0 to its companion LVDS1 Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 14/15] [HACK] arm64: dts: renesas: draak: Enable LVDS dual-link operation Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
2019-03-06 23:23 ` [PATCH/RFC 15/15] [HACK] arm64: dts: renesas: ebisu: " Laurent Pinchart
2019-03-06 23:23 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318142240.GC12707@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.